From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 128E1C433E1 for ; Mon, 17 Aug 2020 22:50:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D0EF420578 for ; Mon, 17 Aug 2020 22:50:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="L6HZ4xjM"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="AhYAvsvo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D0EF420578 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=an8uWhATUnCf/Rn/AQwuHYnjBDAjYY1FOi+MtIxtvgE=; b=L6HZ4xjMgUlf3Lw/uwST558Gl ETd082JuBdYFV9qf5VU/zL+XmVP4qtoyEvh1Z4L6Vn60MJMIwWPISjOWUNyY8WZA9etGfR9y9nqOG ZpfP9u569Nw+SnbUNz4uuLL5JiAPphkco0lM+quCKiJqXAcYX+gl5dmhe9kwr7pklFJYCVc6ocURR JdlTU52+dq9EWdeg7V6XdYf3+8vo6X05+KbH/kgMDDoudACj9qAVekI4eopwnvZ7JcxyPRToFau5T DXrFUldwZ/8wIpTvtmO9C6UBV4k48pITrTtRRf1ZvWaZYawJ+9NgkzC5rnaKCVIxorpqzPTBBgec0 3InKksprg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7nwK-00043Z-E9; Mon, 17 Aug 2020 22:49:16 +0000 Received: from m43-7.mailgun.net ([69.72.43.7]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7nwB-00042O-9C for linux-arm-kernel@lists.infradead.org; Mon, 17 Aug 2020 22:49:13 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1597704553; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Cc: To: From: Date: Sender; bh=bSY85teeXyWnwAwUMOvoBRxC2ptQ9bAi7pCWHRp5PgM=; b=AhYAvsvomTIvom6tq6W/y36r+VVewqLl6OJwakWLKvrjnWzwc+jAj4Hq6Rbgro0XLLvb5LFH Za0LYxrtulzvUNuSJj4Bq3fG01zf1BtQZ7ElQalXRzXrDtXUOLvR6KdSjeqGg3Il+NnwEGT9 wfgM64X6+qoiru+CjcZte34ZlKI= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyJiYzAxZiIsICJsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n10.prod.us-west-2.postgun.com with SMTP id 5f3b09532889723bf8608c0f (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 17 Aug 2020 22:48:51 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 0B10DC433CA; Mon, 17 Aug 2020 22:48:50 +0000 (UTC) Received: from codeaurora.org (unknown [180.166.53.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: tingwei) by smtp.codeaurora.org (Postfix) with ESMTPSA id 05644C433CA; Mon, 17 Aug 2020 22:48:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 05644C433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=tingweiz@codeaurora.org Date: Tue, 18 Aug 2020 06:48:41 +0800 From: Tingwei Zhang To: Mathieu Poirier Subject: Re: [PATCH v8 17/24] coresight: cti: Fix remove sysfs link error Message-ID: <20200817224841.GA24974@codeaurora.org> References: <20200807111153.7784-1-tingwei@codeaurora.org> <20200807111153.7784-18-tingwei@codeaurora.org> <20200817161531.GB3614061@xps15> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200817161531.GB3614061@xps15> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200817_184913_277010_6FCF858A X-CRM114-Status: GOOD ( 27.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tsoni@codeaurora.org, Sai Prakash Ranjan , Kim Phillips , Mao Jinlong , Suzuki K Poulose , Alexander Shishkin , Greg Kroah-Hartman , coresight@lists.linaro.org, Randy Dunlap , Mian Yousaf Kaukab , Russell King , Tingwei Zhang , Leo Yan , linux-arm-kernel@lists.infradead.org, Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 18, 2020 at 12:15:31AM +0800, Mathieu Poirier wrote: > On Fri, Aug 07, 2020 at 07:11:46PM +0800, Tingwei Zhang wrote: > > From: Mike Leach > > > > CTI code to remove sysfs link to other devices on shutdown, incorrectly > > tries to remove a single ended link when these are all double ended. > This > > implementation leaves elements in the link info structure undefined > which > > results in a crash in recent tests for driver module unload. > > > > This patch corrects the link removal code. > > > > Fixes: 73274abb6557 (coresight: cti: Add in sysfs links to other > coresight devices) > > This should be: > > Fixes: 73274abb6557 ("coresight: cti: Add in sysfs links to other > coresight devices") > Sure. I'll put this into v9. Thanks, Tingwei > > Reported-by: Tingwei Zhang > > Signed-off-by: Mike Leach > > --- > > drivers/hwtracing/coresight/coresight-cti.c | 9 ++++++--- > > 1 file changed, 6 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/hwtracing/coresight/coresight-cti.c > b/drivers/hwtracing/coresight/coresight-cti.c > > index 1f470c47ba70..1c34db7d1b1b 100644 > > --- a/drivers/hwtracing/coresight/coresight-cti.c > > +++ b/drivers/hwtracing/coresight/coresight-cti.c > > @@ -511,12 +511,15 @@ static bool cti_add_sysfs_link(struct cti_drvdata > *drvdata, > > return !link_err; > > } > > > > -static void cti_remove_sysfs_link(struct cti_trig_con *tc) > > +static void cti_remove_sysfs_link(struct cti_drvdata *drvdata, > > + struct cti_trig_con *tc) > > { > > struct coresight_sysfs_link link_info; > > > > + link_info.orig = drvdata->csdev; > > link_info.orig_name = tc->con_dev_name; > > link_info.target = tc->con_dev; > > + link_info.target_name = dev_name(&drvdata->csdev->dev); > > coresight_remove_sysfs_link(&link_info); > > } > > > > @@ -606,7 +609,7 @@ void cti_remove_assoc_from_csdev(struct > coresight_device *csdev) > > ctidev = &ctidrv->ctidev; > > list_for_each_entry(tc, &ctidev->trig_cons, node) { > > if (tc->con_dev == csdev->ect_dev) { > > - cti_remove_sysfs_link(tc); > > + cti_remove_sysfs_link(ctidrv, tc); > > tc->con_dev = NULL; > > break; > > } > > @@ -658,7 +661,7 @@ static void cti_remove_conn_xrefs(struct cti_drvdata > *drvdata) > > if (tc->con_dev) { > > coresight_set_assoc_ectdev_mutex(tc->con_dev, > > NULL); > > - cti_remove_sysfs_link(tc); > > + cti_remove_sysfs_link(drvdata, tc); > > With the above: > > Reviewed-by: Mathieu Poirier > > > tc->con_dev = NULL; > > } > > } > > -- > > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora > Forum, > > a Linux Foundation Collaborative Project > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel