From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5B2CC433DF for ; Mon, 17 Aug 2020 22:57:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 942F52063A for ; Mon, 17 Aug 2020 22:57:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oq3+wkxY"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="GOGeWciU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 942F52063A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bxunQXu6FRrNmTUrhmZvCktiElF5KeDvx+Onr/GlU80=; b=oq3+wkxYxdKMAXGO62Lr0s56d x52zRoMhBQnJfpzZfZQeY/PXpUit3ueHOQAoBPOvzA7Vlk9EAggRSeJtBURaVC1MYbm2qmVbViqlq BUuVNZpdIxP9RJrqtHniKwTtMd5dtoya+objRVvfVSuQ2EM1ldsoNOCuMLpDS7TOSykGWeHUxkhFX J/cPvzw5R/PJRK0kvnm2ODuPMTLQO54jW7BLXL8U9vMaIupYL3adO80Rxtrx4XpdV0OVmaVOWx9pF zloJADir25YsdxOZKJvCOf8ZQ7MT3n/J/FGldrXfjKf/gm39m9/kFaM3W8Jpun0XoqVV1CFUPUCOd tiRK3XMkw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7o3T-0004hu-8Q; Mon, 17 Aug 2020 22:56:39 +0000 Received: from m43-7.mailgun.net ([69.72.43.7]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7o3P-0004h4-62 for linux-arm-kernel@lists.infradead.org; Mon, 17 Aug 2020 22:56:38 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1597704997; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Cc: To: From: Date: Sender; bh=kG5pX6yDgwlLdFCQZFcSsWaV4KiA+y6C+vkuJK3iISo=; b=GOGeWciUC6hFuAzVx2T2+JsjSZTUtXyJr1nDDgd8Kq5YS7FhSI9BJTRAW661OH87N804Py+K bTDx3PVH2/Q8JMfSR2aLHhwZl0NwuZnTi/uhbtE+PcD9ifDZlB+5un1NI+IjtE8aBz6i3eJ/ kUo7UnLhBwxUg2seH5v98q5EBPE= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyJiYzAxZiIsICJsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 5f3b0b1d3f2ce1102060be47 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 17 Aug 2020 22:56:29 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id E3495C433AF; Mon, 17 Aug 2020 22:56:28 +0000 (UTC) Received: from codeaurora.org (unknown [180.166.53.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: tingwei) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3E883C433CB; Mon, 17 Aug 2020 22:56:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3E883C433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=tingweiz@codeaurora.org Date: Tue, 18 Aug 2020 06:56:20 +0800 From: Tingwei Zhang To: Mathieu Poirier Subject: Re: [PATCH v8 24/24] coresight: allow the coresight core driver to be built as a module Message-ID: <20200817225620.GB24974@codeaurora.org> References: <20200807111153.7784-1-tingwei@codeaurora.org> <20200807111153.7784-25-tingwei@codeaurora.org> <20200817174722.GG3614061@xps15> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200817174722.GG3614061@xps15> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200817_185637_544955_BFE3D712 X-CRM114-Status: GOOD ( 35.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tsoni@codeaurora.org, Sai Prakash Ranjan , Kim Phillips , Mao Jinlong , Suzuki K Poulose , Alexander Shishkin , Greg Kroah-Hartman , coresight@lists.linaro.org, Randy Dunlap , Mian Yousaf Kaukab , Russell King , Tingwei Zhang , Leo Yan , linux-arm-kernel@lists.infradead.org, Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 18, 2020 at 01:47:22AM +0800, Mathieu Poirier wrote: > On Fri, Aug 07, 2020 at 07:11:53PM +0800, Tingwei Zhang wrote: > > Enhance coresight developer's efficiency to debug coresight drivers. > > - Kconfig becomes a tristate, to allow =m > > - append -core to source file name to allow module to > > be called coresight by the Makefile > > - modules can have only one init/exit, so we add the etm_perf > > register/unregister function calls to the core init/exit > > functions. > > - add a MODULE_DEVICE_TABLE for autoloading on boot > > > > Cc: Mathieu Poirier > > Cc: Leo Yan > > Cc: Alexander Shishkin > > Cc: Randy Dunlap > > Cc: Suzuki K Poulose > > Cc: Greg Kroah-Hartman > > Cc: Russell King > > Signed-off-by: Kim Phillips > > Signed-off-by: Tingwei Zhang > > Tested-by: Mike Leach > > Reviewed-by: Suzuki K Poulose > > --- > > drivers/hwtracing/coresight/Kconfig | 5 ++- > > drivers/hwtracing/coresight/Makefile | 5 ++- > > .../{coresight.c => coresight-core.c} | 42 ++++++++++++++----- > > .../hwtracing/coresight/coresight-etm-perf.c | 8 +++- > > .../hwtracing/coresight/coresight-etm-perf.h | 3 ++ > > 5 files changed, 48 insertions(+), 15 deletions(-) > > rename drivers/hwtracing/coresight/{coresight.c => coresight-core.c} > (98%) > > > > diff --git a/drivers/hwtracing/coresight/Kconfig > b/drivers/hwtracing/coresight/Kconfig > > index dfe407cde262..c1198245461d 100644 > > --- a/drivers/hwtracing/coresight/Kconfig > > +++ b/drivers/hwtracing/coresight/Kconfig > > @@ -3,7 +3,7 @@ > > # Coresight configuration > > # > > menuconfig CORESIGHT > > - bool "CoreSight Tracing Support" > > + tristate "CoreSight Tracing Support" > > depends on ARM || ARM64 > > depends on OF || ACPI > > select ARM_AMBA > > @@ -15,6 +15,9 @@ menuconfig CORESIGHT > > specification and configure the right series of components when > a > > trace source gets enabled. > > > > + To compile this driver as a module, choose M here: the > > + module will be called coresight. > > + > > if CORESIGHT > > config CORESIGHT_LINKS_AND_SINKS > > tristate "CoreSight Link and Sink drivers" > > diff --git a/drivers/hwtracing/coresight/Makefile > b/drivers/hwtracing/coresight/Makefile > > index 0359d5a1588f..1b35b55bd420 100644 > > --- a/drivers/hwtracing/coresight/Makefile > > +++ b/drivers/hwtracing/coresight/Makefile > > @@ -2,8 +2,9 @@ > > # > > # Makefile for CoreSight drivers. > > # > > -obj-$(CONFIG_CORESIGHT) += coresight.o coresight-etm-perf.o \ > > - coresight-platform.o coresight-sysfs.o > > +obj-$(CONFIG_CORESIGHT) += coresight.o > > +coresight-y := coresight-core.o coresight-etm-perf.o > coresight-platform.o \ > > + coresight-sysfs.o > > obj-$(CONFIG_CORESIGHT_LINK_AND_SINK_TMC) += coresight-tmc.o > > coresight-tmc-y := coresight-tmc-core.o coresight-tmc-etf.o \ > > coresight-tmc-etr.o > > diff --git a/drivers/hwtracing/coresight/coresight.c > b/drivers/hwtracing/coresight/coresight-core.c > > similarity index 98% > > rename from drivers/hwtracing/coresight/coresight.c > > rename to drivers/hwtracing/coresight/coresight-core.c > > index f9566d667261..045416ac962f 100644 > > --- a/drivers/hwtracing/coresight/coresight.c > > +++ b/drivers/hwtracing/coresight/coresight-core.c > > @@ -1462,16 +1462,6 @@ int coresight_timeout(void __iomem *addr, u32 > offset, int position, int value) > > } > > EXPORT_SYMBOL_GPL(coresight_timeout); > > > > -struct bus_type coresight_bustype = { > > - .name = "coresight", > > -}; > > - > > -static int __init coresight_init(void) > > -{ > > - return bus_register(&coresight_bustype); > > -} > > -postcore_initcall(coresight_init); > > - > > /* > > * coresight_release_platform_data: Release references to the devices > connected > > * to the output port of this device. > > @@ -1680,3 +1670,35 @@ char *coresight_alloc_device_name(struct > coresight_dev_list *dict, > > return name; > > } > > EXPORT_SYMBOL_GPL(coresight_alloc_device_name); > > + > > +struct bus_type coresight_bustype = { > > + .name = "coresight", > > +}; > > + > > +static int __init coresight_init(void) > > +{ > > + int ret; > > + > > + ret = bus_register(&coresight_bustype); > > + if (ret) > > + return ret; > > + > > + ret = etm_perf_init(); > > + if (ret) > > + bus_unregister(&coresight_bustype); > > + > > + return ret; > > +} > > + > > +static void __exit coresight_exit(void) > > +{ > > + etm_perf_exit(); > > + bus_unregister(&coresight_bustype); > > +} > > + > > +module_init(coresight_init); > > +module_exit(coresight_exit); > > + > > +MODULE_AUTHOR("Mathieu Poirier "); > > Pratik deserves credit too. > > With that: > > Reviewed-by: Mathieu Poirier > > I am done reviewing this set. > > Thank you for the patience, > Mathieu > Thanks for the review of this big patchset, Mathieu. Sorry for some silly mistakes. Thanks, Tingwei > > +MODULE_DESCRIPTION("Arm CoreSight tracer driver"); > > +MODULE_LICENSE("GPL v2"); > > diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c > b/drivers/hwtracing/coresight/coresight-etm-perf.c > > index 3728c44e5763..668b3ff11576 100644 > > --- a/drivers/hwtracing/coresight/coresight-etm-perf.c > > +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c > > @@ -591,7 +591,7 @@ void etm_perf_del_symlink_sink(struct > coresight_device *csdev) > > csdev->ea = NULL; > > } > > > > -static int __init etm_perf_init(void) > > +int __init etm_perf_init(void) > > { > > int ret; > > > > @@ -618,4 +618,8 @@ static int __init etm_perf_init(void) > > > > return ret; > > } > > -device_initcall(etm_perf_init); > > + > > +void __exit etm_perf_exit(void) > > +{ > > + perf_pmu_unregister(&etm_pmu); > > +} > > diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.h > b/drivers/hwtracing/coresight/coresight-etm-perf.h > > index 05f89723e282..3e4f2ad5e193 100644 > > --- a/drivers/hwtracing/coresight/coresight-etm-perf.h > > +++ b/drivers/hwtracing/coresight/coresight-etm-perf.h > > @@ -82,4 +82,7 @@ static inline void *etm_perf_sink_config(struct > perf_output_handle *handle) > > > > #endif /* CONFIG_CORESIGHT */ > > > > +int __init etm_perf_init(void); > > +void __exit etm_perf_exit(void); > > + > > #endif > > -- > > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora > Forum, > > a Linux Foundation Collaborative Project > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel