From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C602C433DF for ; Tue, 18 Aug 2020 12:36:57 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F2AB206B5 for ; Tue, 18 Aug 2020 12:36:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FlLffcBW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F2AB206B5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=96NFf2ldOmv/PpAud5oFNR6MtGztHrh56ySFeRwhxHY=; b=FlLffcBWUe6+DCGrhED4V0uSc grAOG0WM6nE/StYSVpXFrvtUOU5mXJo8UnAM7xqXSRbJNDvh1X8rnJ/KOplESQ7H22lb3Z7d51KPK 9I/Ky5rIgd7K04coxOWPRgaF9GTIfAi+zkwQd2wJ893Nv0i3Fbe4iNRtaraK7o5oDGlPBGD0JHJ4h zDXATTRV0ah4lJp89jQzJYGQFjgORddvO11UE70NawEGSRK3YvtjM5uU2pbzwwthm5X6sNUghLc/z DhHaZNZEMVJIyaiZH0rS73WVirhjWTeYaPLgmraCvyynYlJWP0SOF+m6EO1mxs1CEZs7b43uRUUaM ldnk+U5GA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k80pj-0000LA-OP; Tue, 18 Aug 2020 12:35:19 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k80pg-0000KO-Mj for linux-arm-kernel@lists.infradead.org; Tue, 18 Aug 2020 12:35:17 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 05AEF31B; Tue, 18 Aug 2020 05:35:13 -0700 (PDT) Received: from bogus (unknown [10.37.12.40]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 156243F6CF; Tue, 18 Aug 2020 05:35:09 -0700 (PDT) Date: Tue, 18 Aug 2020 13:35:07 +0100 From: Sudeep Holla To: Ulf Hansson Subject: Re: [PATCH] cpuidle: psci: Allow PM domain to be initialized even if no OSI mode Message-ID: <20200818123507.GD6873@bogus> References: <20200814123436.61851-1-ulf.hansson@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200814123436.61851-1-ulf.hansson@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200818_083516_813013_51177658 X-CRM114-Status: GOOD ( 24.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , Vincent Guittot , Benjamin Gaignard , linux-pm@vger.kernel.org, Stephen Boyd , Daniel Lezcano , "Rafael J . Wysocki" , Lina Iyer , Bjorn Andersson , linux-arm-kernel@lists.infradead.org, Sudeep Holla , Lukasz Luba Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 14, 2020 at 02:34:36PM +0200, Ulf Hansson wrote: > If the PSCI OSI mode isn't supported or fails to be enabled, the PM domain > topology with the genpd providers isn't initialized. This is perfectly fine > from cpuidle-psci point of view. > Indeed. > However, since the PM domain topology in the DTS files is a description of > the HW, no matter of whether the PSCI OSI mode is supported or not, other > consumers besides the CPUs may rely on it. > And why are they even registered as part of cpuidle-psci-domain ? If they have to be, can be decouple it completely from cpuidle then ? > Therefore, let's always allow the initialization of the PM domain topology > to succeed, independently of whether the PSCI OSI mode is supported. > Consequentially we need to track if we succeed to enable the OSI mode, as > to know when a domain idlestate can be selected. > I thought we had discussed this in past, why are we back to the same discussion ? I may need to read those again to get the context. > Note that, CPU devices are still not being attached to the PM domain > topology, unless the PSCI OSI mode is supported. > > Signed-off-by: Ulf Hansson > --- > drivers/cpuidle/cpuidle-psci-domain.c | 49 +++++++++++++-------------- > 1 file changed, 24 insertions(+), 25 deletions(-) > > diff --git a/drivers/cpuidle/cpuidle-psci-domain.c b/drivers/cpuidle/cpuidle-psci-domain.c > index b6e9649ab0da..55653c110e3a 100644 > --- a/drivers/cpuidle/cpuidle-psci-domain.c > +++ b/drivers/cpuidle/cpuidle-psci-domain.c > @@ -28,6 +28,7 @@ struct psci_pd_provider { > > static LIST_HEAD(psci_pd_providers); > static bool psci_pd_allow_domain_state; > +static bool psci_osi_mode_enabled; > > static int psci_pd_power_off(struct generic_pm_domain *pd) > { > @@ -37,7 +38,7 @@ static int psci_pd_power_off(struct generic_pm_domain *pd) > if (!state->data) > return 0; > > - if (!psci_pd_allow_domain_state) > + if (!psci_pd_allow_domain_state || !psci_osi_mode_enabled) I really don't like this check. Why do we have to keep checking psci_osi_mode_enabled every single time and that is the reason IIRC I was against this and just don't add the domains. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel