From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56F85C433DF for ; Tue, 18 Aug 2020 17:06:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 27C9F20786 for ; Tue, 18 Aug 2020 17:06:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mrNqXtFf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27C9F20786 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TCujPDbWhGqGfj8G3J7BrD8JTUjmaQLss4MpMPaWLo4=; b=mrNqXtFfzYZoFepxaWRzKG+cr qdpxSwxxGVQ3jsKVowxYDBSbT2o1MkE6am+Fpg4okSPH7GO7pXQBEP2ZkeSTZIsq4T+IKJe+jMOeS JNOGDLuGQ5ZsPevQyDIWldVSv0ApH9rNtw00QZREfRjh71ACDiYUOJNUIi43rwcRZGTsQafQphj4S YO3bQ7CkDYyoVou1v+IG+NpIvLHEM6GdReKgD/NZS6hxF5N1PyUp352tRqgZgHJdBNtOMsWQFFq/t Yd2RSGe9fcvzegooOwuNUgLzubJbYe731st0bzNC38YT5F/5DVV7DkKJdZnkaSWvT4EZ7bJ/VG932 /1lv44edA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k852y-0003sE-7p; Tue, 18 Aug 2020 17:05:16 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k852v-0003qk-Nv for linux-arm-kernel@lists.infradead.org; Tue, 18 Aug 2020 17:05:14 +0000 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1k852W-009wPo-DE; Tue, 18 Aug 2020 19:04:48 +0200 Date: Tue, 18 Aug 2020 19:04:48 +0200 From: Andrew Lunn To: YueHaibing Subject: Re: [PATCH v2] net: stmmac: Fix signedness bug in stmmac_probe_config_dt() Message-ID: <20200818170448.GH2330298@lunn.ch> References: <20200818143952.50752-1-yuehaibing@huawei.com> <20200818151500.51548-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200818151500.51548-1-yuehaibing@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200818_130513_812581_5370B642 X-CRM114-Status: GOOD ( 10.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.torgue@st.com, ajayg@nvidia.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, kuba@kernel.org, peppe.cavallaro@st.com, davem@davemloft.net, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 18, 2020 at 11:15:00PM +0800, YueHaibing wrote: > The "plat->phy_interface" variable is an enum and in this context GCC > will treat it as an unsigned int so the error handling is never > triggered. > > Fixes: b9f0b2f634c0 ("net: stmmac: platform: fix probe for ACPI devices") > Signed-off-by: YueHaibing Hi YueHaibing Please take a look at: commit 0c65b2b90d13c1deaee6449304dd367c5d4eb8ae Author: Andrew Lunn Date: Mon Nov 4 02:40:33 2019 +0100 net: of_get_phy_mode: Change API to solve int/unit warnings You probably want to follow this basic idea. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel