From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7749EC433E1 for ; Tue, 18 Aug 2020 23:43:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 458EB20738 for ; Tue, 18 Aug 2020 23:43:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NMxVSS9y"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="XCdRDquM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 458EB20738 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3MMscRn9CEyrtYEcaYMd6J+YyJtqJPrkhfbpGVsmWrI=; b=NMxVSS9yNPs2ls/wI7wnSDpQw oG25ErJJ2Ua3VdOUT5qgXFxTgEcz6o3lmVw3/a3pivS38YgSOVGwE0hxxWi1YHj5UBpFAz/UXNsqV IBTSUrNfVniY+S/otczDGcKGsdjLc5LaSzwhv4j8Nwz68tOEZlSUlCfT1fiy+c3qSbpakOoGJVYAj ptJgo0wSx1rX2hjBUS9AdQMdrP7zvL6TwuZFjbeYq8h4EHgwcy0Lhtml7XYWoAtodjAtqDF9BEi05 fZ4Bsz7cOAKDV1c1prj93C9TQaByDfTOBV/hPIrUy7VZLRLXHJKbT7KqjzsXPuLAiXaB45z644tej uqeMkX9PQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8BEa-0001KS-23; Tue, 18 Aug 2020 23:41:40 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8BER-0001Gp-0c for linux-arm-kernel@lists.infradead.org; Tue, 18 Aug 2020 23:41:32 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2B0A529E; Wed, 19 Aug 2020 01:41:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1597794085; bh=FL8lTdjHtNTiufyBf6aXCHIrsCwhOgHhz0pNGh2e54s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XCdRDquMGv+gJsaSyEoULngie1MWFCogUObH2TduN68bXUx3CbYVqgvWW3ihvEdn2 yekt8RuVzSktM+UmrKjZF9Byn6WgoiSnzxFNdQx+I38UZIVcvivXin6nYuvCRYSJn7 9VvEbVvl3tBn5vZqvr1BM5ovN1I/GXhB9OA5Ioss= Date: Wed, 19 Aug 2020 02:41:07 +0300 From: Laurent Pinchart To: Wei Yongjun Subject: Re: [PATCH -next] dmaengine: xilinx: dpdma: Make symbol 'dpdma_debugfs_reqs' static Message-ID: <20200818234107.GC2360@pendragon.ideasonboard.com> References: <20200818112217.43816-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200818112217.43816-1-weiyongjun1@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200818_194131_214582_5A2E5DAB X-CRM114-Status: GOOD ( 18.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Hyun Kwon , Michal Simek , Hulk Robot , Vinod Koul , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Wei, Thank you for the patch. On Tue, Aug 18, 2020 at 07:22:17PM +0800, Wei Yongjun wrote: > The sparse tool complains as follows: > > drivers/dma/xilinx/xilinx_dpdma.c:349:37: warning: > symbol 'dpdma_debugfs_reqs' was not declared. Should it be static? > > This variable is not used outside of xilinx_dpdma.c, so this commit > marks it static. > > Reported-by: Hulk Robot > Fixes: 1d220435cab3 ("dmaengine: xilinx: dpdma: Add debugfs support") > Signed-off-by: Wei Yongjun Looks good to me. Reviewed-by: Laurent Pinchart Vinod, could you pick this up as a v5.9 fix ? > --- > drivers/dma/xilinx/xilinx_dpdma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/xilinx/xilinx_dpdma.c b/drivers/dma/xilinx/xilinx_dpdma.c > index 7db70d226e89..81ed1e482878 100644 > --- a/drivers/dma/xilinx/xilinx_dpdma.c > +++ b/drivers/dma/xilinx/xilinx_dpdma.c > @@ -346,7 +346,7 @@ static int xilinx_dpdma_debugfs_desc_done_irq_write(char *args) > } > > /* Match xilinx_dpdma_testcases vs dpdma_debugfs_reqs[] entry */ > -struct xilinx_dpdma_debugfs_request dpdma_debugfs_reqs[] = { > +static struct xilinx_dpdma_debugfs_request dpdma_debugfs_reqs[] = { > { > .name = "DESCRIPTOR_DONE_INTR", > .tc = DPDMA_TC_INTR_DONE, > -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel