From: Vinod Koul <vkoul@kernel.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Hyun Kwon <hyun.kwon@xilinx.com>,
Michal Simek <michal.simek@xilinx.com>,
Hulk Robot <hulkci@huawei.com>,
Wei Yongjun <weiyongjun1@huawei.com>,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH -next] dmaengine: xilinx: dpdma: Make symbol 'dpdma_debugfs_reqs' static
Date: Wed, 19 Aug 2020 09:56:01 +0530 [thread overview]
Message-ID: <20200819042601.GB2639@vkoul-mobl> (raw)
In-Reply-To: <20200818234107.GC2360@pendragon.ideasonboard.com>
On 19-08-20, 02:41, Laurent Pinchart wrote:
> Hi Wei,
>
> Thank you for the patch.
>
> On Tue, Aug 18, 2020 at 07:22:17PM +0800, Wei Yongjun wrote:
> > The sparse tool complains as follows:
> >
> > drivers/dma/xilinx/xilinx_dpdma.c:349:37: warning:
> > symbol 'dpdma_debugfs_reqs' was not declared. Should it be static?
> >
> > This variable is not used outside of xilinx_dpdma.c, so this commit
> > marks it static.
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Fixes: 1d220435cab3 ("dmaengine: xilinx: dpdma: Add debugfs support")
> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>
> Looks good to me.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Vinod, could you pick this up as a v5.9 fix ?
This is not 5.9 fix. The debugfs patch will go into next for 5.10 so
this is applied to next as well
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-19 4:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 11:22 [PATCH -next] dmaengine: xilinx: dpdma: Make symbol 'dpdma_debugfs_reqs' static Wei Yongjun
2020-08-18 19:32 ` Hyun Kwon
2020-08-18 23:41 ` Laurent Pinchart
2020-08-19 4:26 ` Vinod Koul [this message]
2020-08-19 4:24 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200819042601.GB2639@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=hulkci@huawei.com \
--cc=hyun.kwon@xilinx.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=michal.simek@xilinx.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox