From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 479B3C433DF for ; Wed, 19 Aug 2020 13:25:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 14AED205CB for ; Wed, 19 Aug 2020 13:25:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UK2q6p3E"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="EuDaDJ4F" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 14AED205CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3f97LLca7lx6Xenzj48rhydlhG4uoJ52csAg4oK5Hls=; b=UK2q6p3EcEhjuFNcROKslqOJk cz5VJGcXqeUHdrZ7TmzyNRMxQvW79UcdSy6QwF6+otVsfiG8YjekzmiIg/inI4Vl8hQnVWwB+KBwi fdf49SBHbQ7C/sRybgtKJJytpppnBJuE+smx1kslwLHvi2697YCRtXF1iZCHYO0f6E56lTxbphiMr LtXmkWpeRs7KFLigMXULfpl8dmtmqG2BosDmSDuLdpLsIGtSapI6dcKR1DHi3v3I9T87eobaLrbWE JLS6BaUv6swK6SsBWFlGHYXFf9YbFslkTQaE3YFM7tKG9BhwVxjfbPGFzAi0ialGMuprSoG/EywBQ sKsOxxyQg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8O41-0006xL-D5; Wed, 19 Aug 2020 13:23:37 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8O3z-0006ws-8c for linux-arm-kernel@lists.infradead.org; Wed, 19 Aug 2020 13:23:36 +0000 Received: from dragon (unknown [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 170D9205CB; Wed, 19 Aug 2020 13:23:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597843413; bh=GUAK/3Erqnn4v6wmDx98GtQrAlIyBXmM7AhYh906syU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EuDaDJ4FYqnTEo41N6XrhzVujSM53sGEQYAhMSZjrC/NTp+E+XRXFxddwKP1wZ2Po UtW1kppzqKMmPWgTaTLRlKxTtvvsB2S9RknaW/qOE+t00MZ7UBbolUu+R+/VsJkOkL HZH9u8xjRg1IMeqtbAT+d+rr291T41+/20blr6BM= Date: Wed, 19 Aug 2020 21:23:19 +0800 From: Shawn Guo To: "Franck LENORMAND (OSS)" Subject: Re: [PATCH v2 0/5] Add support of SECVIO from SNVS on iMX8q/x Message-ID: <20200819132317.GA7114@dragon> References: <1595344835-67746-1-git-send-email-franck.lenormand@oss.nxp.com> <1597737122.73802.3.camel@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1597737122.73802.3.camel@oss.nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200819_092335_428453_A0AB1BAC X-CRM114-Status: GOOD ( 30.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: aisheng.dong@nxp.com, peng.fan@nxp.com, qiangqing.zhang@nxp.com, abel.vesa@nxp.com, Anson.Huang@nxp.com, daniel.baluta@nxp.com, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, linux@rempel-privat.de, linux-imx@nxp.com, kernel@pengutronix.de, leonard.crestez@nxp.com, festevam@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 18, 2020 at 09:52:02AM +0200, Franck LENORMAND (OSS) wrote: > Hello, > = > Peng was able to do a firt pass of review on my patchset which led to this > second version. I hope a maintainer will be able to take a look at this > patchset once rested after all the work they did for 5.9. @Peng, are you okay with this version? @Aisheng, have a review on this? Shawn > = > On mar., 2020-07-21 at 17:20 +0200, franck.lenormand@oss.nxp.com wrote: > > From: Franck LENORMAND > > = > > This patchset aims to add support for the SECurity VIOlation (SECVIO) o= f the > > SNVS. A secvio is a signal emitted by the SNVS when a hardware attack > > is detected. On imx8x and imx8q SoC, the SNVS is controlled by the > > SECO and it is possible to interact with it using the SCU using the SC = APIs. > > = > > For the driver to communicate with the SNVS via the SCU and the SECO, I= had to: > > =A0- Add support for exchange of big message with the SCU (needed for > > imx_scu_irq_get_status) > > =A0- Add API to check linux can control the SECVIO (imx_sc_rm_is_resour= ce_owned) > > =A0- Add APIs for the driver to read the state of the SECVIO registers = of the > > SNVS and DGO (imx_sc_seco_secvio_enable and imx_sc_seco_secvio_enable). > > = > > To check the state of the SECVIO IRQ in the SCU, I added the > > imx_scu_irq_get_status API. > > = > > The secvio driver is designed to receive the IRQ produced by the > > SNVS in case of hardware attack and notify the status to the > > audit framework which can be used by the user. > > = > > The goal of the driver is to be self suficient but can be extended by t= he > > user to perform custom operations on values read (imx_sc_seco_secvio_en= able) > > = > > v2: > > =A0- Removed (firmware: imx: scu-rm: Add Resource Management APIs) > > -> Code required is already present > > =A0- Removed (firmware: imx: scu: Support reception of messages of any = size) > > -> The imx-scu is already working in fast-ipc mode > > =A0- (soc: imx8: Add the SC SECVIO driver): > > - Fixed the warnings reported by kernel test robot > > = > > Franck LENORMAND (5): > > =A0 firmware: imx: scu-seco: Add SEcure Controller APIS > > =A0 firmware: imx: scu-irq: Add API to retrieve status of IRQ > > =A0 dt-bindings: firmware: imx-scu: Add SECVIO resource > > =A0 dt-bindings: arm: imx: Documentation of the SC secvio driver > > =A0 soc: imx8: Add the SC SECVIO driver > > = > > =A0.../bindings/arm/freescale/fsl,imx-sc-secvio.yaml=A0=A0|=A0=A034 + > > =A0drivers/firmware/imx/Makefile=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0|=A0=A0=A02 +- > > =A0drivers/firmware/imx/imx-scu-irq.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0|=A0=A037 +- > > =A0drivers/firmware/imx/imx-scu.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0|=A0=A0=A03 + > > =A0drivers/firmware/imx/seco.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0| 275 +++++++ > > =A0drivers/soc/imx/Kconfig=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0|=A0=A010 + > > =A0drivers/soc/imx/Makefile=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0|=A0=A0=A01 + > > =A0drivers/soc/imx/secvio/Kconfig=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0|=A0=A010 + > > =A0drivers/soc/imx/secvio/Makefile=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0|=A0=A0=A03 + > > =A0drivers/soc/imx/secvio/imx-secvio-audit.c=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0|=A0=A039 + > > =A0drivers/soc/imx/secvio/imx-secvio-debugfs.c=A0=A0=A0=A0=A0=A0=A0=A0|= 379 +++++++++ > > =A0drivers/soc/imx/secvio/imx-secvio-sc-int.h=A0=A0=A0=A0=A0=A0=A0=A0= =A0|=A0=A084 ++ > > =A0drivers/soc/imx/secvio/imx-secvio-sc.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0| 858 +++++++++++++++++++++ > > =A0include/dt-bindings/firmware/imx/rsrc.h=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0|=A0=A0=A03 +- > > =A0include/linux/firmware/imx/ipc.h=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0|=A0=A0=A01 + > > =A0include/linux/firmware/imx/sci.h=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0|=A0=A0=A05 + > > =A0include/linux/firmware/imx/svc/seco.h=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0|=A0=A073 ++ > > =A0include/soc/imx/imx-secvio-sc.h=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0| 177 +++++ > > =A018 files changed, 1991 insertions(+), 3 deletions(-) > > =A0create mode 100644 Documentation/devicetree/bindings/arm/freescale/f= sl,imx-sc- > > secvio.yaml > > =A0create mode 100644 drivers/firmware/imx/seco.c > > =A0create mode 100644 drivers/soc/imx/secvio/Kconfig > > =A0create mode 100644 drivers/soc/imx/secvio/Makefile > > =A0create mode 100644 drivers/soc/imx/secvio/imx-secvio-audit.c > > =A0create mode 100644 drivers/soc/imx/secvio/imx-secvio-debugfs.c > > =A0create mode 100644 drivers/soc/imx/secvio/imx-secvio-sc-int.h > > =A0create mode 100644 drivers/soc/imx/secvio/imx-secvio-sc.c > > =A0create mode 100644 include/linux/firmware/imx/svc/seco.h > > =A0create mode 100644 include/soc/imx/imx-secvio-sc.h > > = > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel