From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F11E2C433E1 for ; Wed, 19 Aug 2020 22:06:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE9CC2078D for ; Wed, 19 Aug 2020 22:06:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CaxuWJ9v"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="en2ThmGi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE9CC2078D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Owner; bh=mq2gmlhJQhUkcBOvrA5B9KXjVKEYmRo6wAvkbkI9lt0=; b=CaxuWJ9vEIZQRKovK+8JYibPAW JMcfnH727fSh2ioshnJxHFcSYXI+0H5LWIK60VdfAv3CY7DTmLwdl46Dm7txIj4cNUO0OF2YhZfnP BbxzCUPCCS8zDXqENGAtel1zbP3QkOZBMmKui5Yx6RCGFvvmE2Csan0E4TtZUcXxy5VkduDwO9s0n H3Gyd5LC1WUeI+jteVxKBGZi5l8L6Xe+EMSQfV+J6yeTyxYW0m4VnzeMHeFkHIB/dsgYYIZCCleu3 Id10ZUDKPNBEqsjPoNdI+nwUf2uGXBhhWbxw6TwEkcDnSWIgwZQZTQHV8Oez4KleY+kx4cbHvqefy N6j2WTgw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8WCa-0006jY-39; Wed, 19 Aug 2020 22:05:00 +0000 Received: from mail-qv1-xf41.google.com ([2607:f8b0:4864:20::f41]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8WCX-0006is-L1 for linux-arm-kernel@lists.infradead.org; Wed, 19 Aug 2020 22:04:58 +0000 Received: by mail-qv1-xf41.google.com with SMTP id v1so89309qvn.3 for ; Wed, 19 Aug 2020 15:04:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=Dp7h7oN6bJQbgtFUrgZmZSTkRI+AzXaoCGABHad+icc=; b=en2ThmGi3K7Q8VujxuS/X99FHM6shoqQH2+BDQ6hQj96EP1G0I+e8cV9uqctQ5dIqw L9CQKDqxS/8w4JBfSAVoaCzZKHtQxOGNb3exMfNNIDEPKxpaQm2nrWbIfS/iDF1G92iD n1+SY3dt6PLfJY+eUyCFpMpMSPUBoFwAO/nm3uNR/M40a5dpvALAUBMEigdDQvjfZMsQ UfJ9/D6EQMglPLuucVMkoTpGKycZ0MmH2gwUXq8LLA/GR39flWJ95sWOnW1X1gL0sN/d iUY+QS5DmL1HQbf+ksmIJr6MTFVYIdTd3CDh2hxQuSLip3gNkKiI6aQgQQYhJkdYgbT6 if4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Dp7h7oN6bJQbgtFUrgZmZSTkRI+AzXaoCGABHad+icc=; b=E+gevshDSfj0Me3i00Y48skewFXaPw7iurSaoxGqI+pFHdYRDLOTZZliBmAPJheNfa CEyRW89YW2D30u/b1aczhGlQ6nmuu/Ia6qZp4DsBDOqysbiXllQngBYIkpdWGIjLKQ5K yuKjAS9mAaOacWK/ITFeyJViYtMnuyC8bgQCKazkkwklY2b6ww9hVjiQT0bAjMZaJ1NC 7otUFvEUr+pHgb6QKF/cPTCPjcRJLXSwb/xnLsFTWGZiGoCKmtoyB8QtuxM/YZUeomfY +za7VK2Kq9NpnsUoshjQcQBDjSL7ZcTx9pa8k+OAajrmrdXrcEYrRHOUUVuZl+UuNd6G APkQ== X-Gm-Message-State: AOAM532jtHdyiqRyjx5c676qTfHBA7zm3yRS7OfnF/1a/3QB+T7p7lhl TLMnQfPLCJLzWjPUlQIhKQg= X-Google-Smtp-Source: ABdhPJzAZnAW+2dqpeWKdQUkGV7lhAjY/2PvEu90IwsNNbZnaQFnSZZ5cd58LqPnLQ8JSWd1icathQ== X-Received: by 2002:ad4:4ea7:: with SMTP id ed7mr373881qvb.8.1597874694964; Wed, 19 Aug 2020 15:04:54 -0700 (PDT) Received: from localhost.localdomain ([177.194.72.74]) by smtp.gmail.com with ESMTPSA id u8sm41986qkj.9.2020.08.19.15.04.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2020 15:04:54 -0700 (PDT) From: Fabio Estevam To: shawnguo@kernel.org Subject: [PATCH] arm64: dts: imx8m: Fix the SPI chipselect polarity Date: Wed, 19 Aug 2020 19:02:19 -0300 Message-Id: <20200819220219.13251-1-festevam@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200819_180457_824353_DFCAFFAA X-CRM114-Status: GOOD ( 17.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fabio Estevam , linus.walleij@linaro.org, cphealy@gmail.com, kernel@pengutronix.de, ford173@gmail.com, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The conversion of the spi-imx driver to use GPIO descriptors in commit 8cdcd8aeee28 ("spi: imx/fsl-lpspi: Convert to GPIO descriptors") helped to detect the following SPI chipselect polarity mismatch on an imx6q-sabresd for example: [ 4.854337] m25p80@0 enforce active low on chipselect handle Prior to the above commit, the chipselect polarity passed via cs-gpios property was ignored and considered active-low. The reason for such mismatch is clearly explained in the comments inside drivers/gpio/gpiolib-of.c: * SPI children have active low chip selects * by default. This can be specified negatively * by just omitting "spi-cs-high" in the * device node, or actively by tagging on * GPIO_ACTIVE_LOW as flag in the device * tree. If the line is simultaneously * tagged as active low in the device tree * and has the "spi-cs-high" set, we get a * conflict and the "spi-cs-high" flag will * take precedence. To properly represent the SPI chipselect polarity, change it to active-low when the "spi-cs-high" property is absent. Signed-off-by: Fabio Estevam --- arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi | 2 +- arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi index baa5f997d018..9ac17b284f20 100644 --- a/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi @@ -70,7 +70,7 @@ &ecspi2 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_espi2>; - cs-gpios = <&gpio5 9 0>; + cs-gpios = <&gpio5 9 GPIO_ACTIVE_LOW>; status = "okay"; eeprom@0 { diff --git a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dts b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dts index 6b3581366d67..bfad4b885905 100644 --- a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dts +++ b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dts @@ -15,7 +15,7 @@ &ecspi1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_ecspi1>; - cs-gpios = <&gpio5 9 GPIO_ACTIVE_HIGH>; + cs-gpios = <&gpio5 9 GPIO_ACTIVE_LOW>; status = "okay"; #address-cells = <1>; #size-cells = <0>; -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel