From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AD8CC433E1 for ; Thu, 20 Aug 2020 12:38:44 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 249AB207DA for ; Thu, 20 Aug 2020 12:38:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pdeTiF6z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 249AB207DA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bTcSxySadNX5g/o69EdniIHwlK5X2MoD0fFclhRPy8c=; b=pdeTiF6z2JJtp3ZlzY7KMiUQt EqbSFtKxADO/h16KfGO9vdDWpfPlOV0jWKqHR6tSrRxZsiHSxa1JCk78oXTgZQapHU+TY/W7gaGfm Tq4b2fJhoSPU6RX63u+wL+oLbfhpWe6Q0S2BcOCJj5XQke88a3rgdoWzzmuBo31iTksGMb3OwA7Nd YdsNK5FtMq4D7cu/yvdqz1lzmJyVJSD/GI96H/VsPcL2G5lqfxyR9P/E2uJJJ2Mv6uLekl3uYM6/z hd/1RQHOQ+WuiwB1R6c1rbGp7fIpnidYgLZm7fdVVDK54mv04cKFLBHENqhSHmdOh00NDq2iRk3KO RAi8yvcww==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8jov-0007Fd-1N; Thu, 20 Aug 2020 12:37:29 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8jos-0007Ez-HA for linux-arm-kernel@lists.infradead.org; Thu, 20 Aug 2020 12:37:27 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5A69C30E; Thu, 20 Aug 2020 05:37:21 -0700 (PDT) Received: from bogus (unknown [10.37.8.132]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E62643F66B; Thu, 20 Aug 2020 05:37:18 -0700 (PDT) Date: Thu, 20 Aug 2020 13:37:11 +0100 From: Sudeep Holla To: Viresh Kumar Subject: Re: [Patch] cpufreq: replace cpu_logical_map with read_cpuid_mpir Message-ID: <20200820123711.GA19989@bogus> References: <1597174997-22505-1-git-send-email-sumitg@nvidia.com> <20200820053945.xlwtpkvbt4o23flk@vireshk-i7> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200820053945.xlwtpkvbt4o23flk@vireshk-i7> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200820_083726_653051_00E0EF6B X-CRM114-Status: GOOD ( 15.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bbasu@nvidia.com, wangkefeng.wang@huawei.com, linux-pm@vger.kernel.org, catalin.marinas@arm.com, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, jonathanh@nvidia.com, thierry.reding@gmail.com, Sudeep Holla , linux-tegra@vger.kernel.org, Sumit Gupta , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 20, 2020 at 11:09:45AM +0530, Viresh Kumar wrote: > On 12-08-20, 01:13, Sumit Gupta wrote: > > Commit eaecca9e7710 ("arm64: Fix __cpu_logical_map undefined issue") > > fixes the issue with building tegra194 cpufreq driver as module. But > > the fix might cause problem while supporting physical cpu hotplug[1]. > > > > This patch fixes the original problem by avoiding use of cpu_logical_map(). > > Instead calling read_cpuid_mpidr() to get MPIDR on target cpu. > > > > [1] https://lore.kernel.org/linux-arm-kernel/20200724131059.GB6521@bogus/ > > > > Reviewed-by: Sudeep Holla > > Signed-off-by: Sumit Gupta > > --- > > drivers/cpufreq/tegra194-cpufreq.c | 10 +++++++--- > > 1 file changed, 7 insertions(+), 3 deletions(-) > > Applied. Thanks. Just to confirm, is this going as a fix ? We want to drop exporting cpu_logical_map in v5.9 so this needs to go as fix. I missed it earlier, actually, Fixes: df320f89359c ("cpufreq: Add Tegra194 cpufreq driver") is appropriate here so that we can drop export symbol which was part of Commit eaecca9e7710 ("arm64: Fix __cpu_logical_map undefined issue") as a workaround to fix the build. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel