From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alex Dewar <alex.dewar90@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org,
Markus Mayer <mmayer@broadcom.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] memory: brcmstb_dpfe: Fix memory leak
Date: Thu, 20 Aug 2020 20:52:41 +0200 [thread overview]
Message-ID: <20200820185241.GA2833@kozik-lap> (raw)
In-Reply-To: <20200820172118.781324-1-alex.dewar90@gmail.com>
On Thu, Aug 20, 2020 at 06:21:18PM +0100, Alex Dewar wrote:
> In brcmstb_dpfe_download_firmware(), memory is allocated to variable fw by
> firmware_request_nowarn(), but never released. Fix up to release fw on
> all return paths.
>
> Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
> ---
> v2: Don't assign ret unnecessarily (Krzysztof)
> ---
> drivers/memory/brcmstb_dpfe.c | 16 ++++++++++------
Thanks, applied with acks, CC stable and Fixes tag.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-08-20 18:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 17:21 [PATCH v2] memory: brcmstb_dpfe: Fix memory leak Alex Dewar
2020-08-20 17:44 ` Markus Mayer
2020-08-20 17:48 ` Florian Fainelli
2020-08-20 18:52 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200820185241.GA2833@kozik-lap \
--to=krzk@kernel.org \
--cc=alex.dewar90@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmayer@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).