From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DC89C433E1 for ; Thu, 20 Aug 2020 18:53:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E3FA0207DE for ; Thu, 20 Aug 2020 18:53:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dIiFdO2Q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E3FA0207DE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pXa3LLaM5ERAvOV6M/O1ru9899PASGQcCSVRlWKTNkg=; b=dIiFdO2QkCoNNoo0z7mAv3UQF bBU3u1V7PulAbLet644nO9ZReEviKpXTyNBZIU01B37/dyAHmTZfJwCbp9WFPWtZXXtgTTIO9dCUN +SoGvAXjO7M6KNyz0S3iMqsaNfrtzQTA32QRL6aysbZ4PmeaFiLSfRAhBp1uwijqSmMQ4/0RQkh0+ /TGl2sc9VDyrienkFClsZxcIutNzn6u/9z5PIo9GspmFQHQG3XRyew2S+v9bfPDZqk55F9r/PjjsK RVdEXJXCTY9yuEvjqgqhTZjFDhK2VQ8O2BlkrQxP33spoaxjTQQVJJ71doTneHedEyBrInaGa345/ 8OuBPFfkw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8pg7-0005Sv-Gt; Thu, 20 Aug 2020 18:52:47 +0000 Received: from mail-wr1-f65.google.com ([209.85.221.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8pg5-0005Rp-44 for linux-arm-kernel@lists.infradead.org; Thu, 20 Aug 2020 18:52:45 +0000 Received: by mail-wr1-f65.google.com with SMTP id r4so3120409wrx.9 for ; Thu, 20 Aug 2020 11:52:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=BJ095o2R3pfLHrGrBkg75D4r4m29RUPbdiOfPVS83Ok=; b=CyNDEY+HSK//40lYZpwC0UorjpXX1n4/KfLg0cPFPOqAUNT9Q18ZIQ7I1zPdcDp6vG euNdn65D1hfLKr8Rn+sZjrE71t2PfsrApX+V1zCC+rLpL5jKfukX1F/aFRUQlRYB3Z4E sv2Aev5fX/1sDkwXo7I7M94m1cdNoJEBf1FJKVB/6FCaEooj1syoIMtORzfN1xIpL3o/ vVMGM3TWHNURGKCIsOz+fYEFJ9Nm0qjh8HgkjXh9nGNKZ/kuzx1G0P1w/Xe+loVRHgWQ Kd20DgpN0i23C0JfskgCxhIuS329UXzpQa/mL41jb6tGc9YezRcn9CgZ/HCPSHYq73p4 wj0g== X-Gm-Message-State: AOAM530eMxzs9HORgBpBoDIP3P5STMHA9TnpTKur9dEn+Hd55lrfuAXi 6M6kvMIcCG1MHUt+O+AyjZUalrnLzIDuhA== X-Google-Smtp-Source: ABdhPJzkDPZAouwqIHWPOQHYosJiqPAJhKrgroO2UbF2yZfw92R8S8xfuBRKKq1Q9umYszmavSEPPw== X-Received: by 2002:a5d:49c9:: with SMTP id t9mr111645wrs.302.1597949563855; Thu, 20 Aug 2020 11:52:43 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id m20sm22707438wmc.1.2020.08.20.11.52.42 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 20 Aug 2020 11:52:43 -0700 (PDT) Date: Thu, 20 Aug 2020 20:52:41 +0200 From: Krzysztof Kozlowski To: Alex Dewar Subject: Re: [PATCH v2] memory: brcmstb_dpfe: Fix memory leak Message-ID: <20200820185241.GA2833@kozik-lap> References: <20200820172118.781324-1-alex.dewar90@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200820172118.781324-1-alex.dewar90@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200820_145245_197942_393734A4 X-CRM114-Status: GOOD ( 11.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, Markus Mayer , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 20, 2020 at 06:21:18PM +0100, Alex Dewar wrote: > In brcmstb_dpfe_download_firmware(), memory is allocated to variable fw by > firmware_request_nowarn(), but never released. Fix up to release fw on > all return paths. > > Signed-off-by: Alex Dewar > --- > v2: Don't assign ret unnecessarily (Krzysztof) > --- > drivers/memory/brcmstb_dpfe.c | 16 ++++++++++------ Thanks, applied with acks, CC stable and Fixes tag. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel