From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71712C433DF for ; Thu, 20 Aug 2020 22:23:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 38D0E207DF for ; Thu, 20 Aug 2020 22:23:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JZuG8U4B"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="knEda3aC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38D0E207DF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID:Subject:To:From: Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References:List-Owner; bh=4KP8RmoIgE1UeGPuhxC5rD1uulLgwHCN8tGKMjc7wRQ=; b=JZuG8U4BCHtLhpqLmqks220C6 Yq206/0r0lCESyiKeucjohdS9H5LR9JxpMZED6dXzjIA3LUw41zCPL/udAhMqc1dKI6dt/cZAY4uJ KgKPUQbRBEm2h7KJi1BGLSx/9T3xrIPoGLmct9kr23L7w4Y/31yrXlpKcTospmGD7oO/0uRhwgNOl 0i83V3IyKyWtydnmYJuw6pBDruJ3c1BSQFLeOdBylKdFvj27S9LZfT/ImYx5xRJI10N6SoGnLJbnk bBn2V8uZaQebq9Fz52Qn6EeS1KeizdpAUhZwj015XwXPzPuKwHv1r9mJZzxm9hMJBM4X5obG9xwTd bM/DYwUpQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8swA-0004Wt-6f; Thu, 20 Aug 2020 22:21:34 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8sw8-0004WC-21 for linux-arm-kernel@lists.infradead.org; Thu, 20 Aug 2020 22:21:32 +0000 Received: from localhost (104.sub-72-107-126.myvzw.com [72.107.126.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F0C832075E; Thu, 20 Aug 2020 22:21:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597962091; bh=YZFXjRScFns5Q/JX8kMKWW0SqdzIXgtS9wkbdlVq+aY=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=knEda3aCkNQRb87lx+sMgW3yN3C0Y6JlzUzcCgx8GpjQ10pVHNJ4crvidnJ1gmard 5v3EkkglnDiXCky0Pjvo1GthcdGBaGo/AMvK4GnWaK1ckhnJ7Kws0ZkiAgZ0Z2+TtX yfwNjy/fqDviqP4iGN/YePrORscJex7NxAo+wTqo= Date: Thu, 20 Aug 2020 17:21:29 -0500 From: Bjorn Helgaas To: Jonathan Cameron Subject: Re: [PATCH v9 4/6] ACPI: HMAT: Fix handling of changes from ACPI 6.2 to ACPI 6.3 Message-ID: <20200820222129.GA1571389@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200819145111.1715026-5-Jonathan.Cameron@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200820_182132_259060_7BE443C0 X-CRM114-Status: GOOD ( 19.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: rafael@kernel.org, Lorenzo Pieralisi , linux-acpi@vger.kernel.org, linux-api@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, linux-mm@kvack.org, Ingo Molnar , Brice Goglin , Bjorn Helgaas , Thomas Gleixner , Dan Williams , linux-arm-kernel@lists.infradead.org, Sean V Kelley Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 19, 2020 at 10:51:09PM +0800, Jonathan Cameron wrote: > In ACPI 6.3, the Memory Proximity Domain Attributes Structure > changed substantially. One of those changes was that the flag > for "Memory Proximity Domain field is valid" was deprecated. > > This was because the field "Proximity Domain for the Memory" > became a required field and hence having a validity flag makes > no sense. > > So the correct logic is to always assume the field is there. > Current code assumes it never is. > > Signed-off-by: Jonathan Cameron > --- > drivers/acpi/numa/hmat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/numa/hmat.c b/drivers/acpi/numa/hmat.c > index 2c32cfb72370..07cfe50136e0 100644 > --- a/drivers/acpi/numa/hmat.c > +++ b/drivers/acpi/numa/hmat.c > @@ -424,7 +424,7 @@ static int __init hmat_parse_proximity_domain(union acpi_subtable_headers *heade > pr_info("HMAT: Memory Flags:%04x Processor Domain:%u Memory Domain:%u\n", > p->flags, p->processor_PD, p->memory_PD); > > - if (p->flags & ACPI_HMAT_MEMORY_PD_VALID && hmat_revision == 1) { > + if ((p->flags & ACPI_HMAT_MEMORY_PD_VALID && hmat_revision == 1) || hmat_revision == 2) { I hope/assume the spec is written in such a way that p->memory_PD is required for any revision > 1? So maybe this should be: if ((p->flags & ACPI_HMAT_MEMORY_PD_VALID && hmat_revision == 1) || hmat_revision > 1) { > target = find_mem_target(p->memory_PD); > if (!target) { > pr_debug("HMAT: Memory Domain missing from SRAT\n"); > -- > 2.19.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel