From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 709AEC433E1 for ; Fri, 21 Aug 2020 16:04:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 40BAE207BB for ; Fri, 21 Aug 2020 16:04:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="seGg072E"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Md3AbSOL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 40BAE207BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=L6sOa3YDSe2Y01bh4Z1qkHJJhTZ1HkaUfajPTurY73Q=; b=seGg072EJieA9Ei6yFOshw+xH /RZekLihBDAh+gtKPJxBQS82m4ZnPmKfwuumZcEJaKXLxe3qU9hjsTR/CPHIoHnW1w/zpc2sAaUvI r/6o9S6WJWQ/UZx7PxZxPPadxD+puJvU+AYqojD00n7b2UiokN6o4qy0lEFYKHIBE1+htfOGYeauE LRnBeND24kEXwDGvq6RdBUTYPwjpRXKP+KzeVC1np7Fp+qWipE9uhfeGuCkEWA6s2AgllilsTFtad dzAY4pC+cROk903x4arqsYgNtu+d12/zNUhK3hsFYhAnY9LMpIor5R6Hmm/YsmRmitHRufwUsMl3D MqurosZfw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k99VY-000819-D7; Fri, 21 Aug 2020 16:03:12 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k99VV-00080Z-VR for linux-arm-kernel@lists.infradead.org; Fri, 21 Aug 2020 16:03:11 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B0EB2207BB; Fri, 21 Aug 2020 16:03:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598025789; bh=/0EVJxsGaOLAUjJMMd+W1WG/wnkFH9iB3kYrAwJx2dE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Md3AbSOL4gseoxDQxxOac6Jg7vlI+70Z2ZhL3uA4uw+rFmNAyvK+xqjaQmFm2LXSh pCkqfIdppeIHo5fZ6QVcjKGvyDHybsUMPYf/W5LGMRKaVqVTkDRITpGmiiGY922pJL /wCDsCiWONqJk1Jy19dG8bNrki9gTV+6+s7x/b+I= Date: Fri, 21 Aug 2020 17:03:05 +0100 From: Will Deacon To: Shaokun Zhang Subject: Re: [PATCH] drivers/perf: arm_pmu: Show PMU version on boot Message-ID: <20200821160304.GD21517@willie-the-truck> References: <1596106041-7688-1-git-send-email-zhangshaokun@hisilicon.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1596106041-7688-1-git-send-email-zhangshaokun@hisilicon.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200821_120310_432178_9889C39D X-CRM114-Status: GOOD ( 16.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 30, 2020 at 06:47:21PM +0800, Shaokun Zhang wrote: > The @pmuver field has been initialized and can tell the PMU version. > Let's show it on boot and the user obtains this information directly. > > Cc: Will Deacon > Cc: Mark Rutland > Signed-off-by: Shaokun Zhang > --- > drivers/perf/arm_pmu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c > index df352b334ea7..36f7fad7ba5a 100644 > --- a/drivers/perf/arm_pmu.c > +++ b/drivers/perf/arm_pmu.c > @@ -870,8 +870,8 @@ int armpmu_register(struct arm_pmu *pmu) > if (!__oprofile_cpu_pmu) > __oprofile_cpu_pmu = pmu; > > - pr_info("enabled with %s PMU driver, %d counters available\n", > - pmu->name, pmu->num_events); > + pr_info("enabled with %s PMU driver, %d counters available, version is %d\n", > + pmu->name, pmu->num_events, pmu->pmuver); Hmm. I'm suspicious about this. Who is using this, and what for? We're better off exposing things in the existing sysfs directory we have if it's actually needed by tools. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel