From: Shawn Guo <shawnguo@kernel.org>
To: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Li Yang <leoyang.li@nxp.com>
Subject: Re: [PATCH] arm: dts: ls1021a: fix QuadSPI-memory reg range
Date: Sat, 22 Aug 2020 12:02:24 +0800 [thread overview]
Message-ID: <20200822040224.GC27575@dragon> (raw)
In-Reply-To: <20200728105006.7952-1-matthias.schiffer@ew.tq-group.com>
On Tue, Jul 28, 2020 at 12:50:06PM +0200, Matthias Schiffer wrote:
> According to the Reference Manual, the correct size is 512 MiB.
>
> Without this fix, probing the QSPI fails:
>
> fsl-quadspi 1550000.spi: ioremap failed for resource
> [mem 0x40000000-0x7fffffff]
> fsl-quadspi 1550000.spi: Freescale QuadSPI probe failed
> fsl-quadspi: probe of 1550000.spi failed with error -12
>
> Fixes: 85f8ee78ab72 ("ARM: dts: ls1021a: Add support for QSPI with ls1021a SoC")
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Idiomatically we use 'ARM: ...' for arm32 DTS patch prefix.
I fixed it up and applied the patch.
Shawn
> ---
> arch/arm/boot/dts/ls1021a.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
> index b2ff27af090e..9435ce527e85 100644
> --- a/arch/arm/boot/dts/ls1021a.dtsi
> +++ b/arch/arm/boot/dts/ls1021a.dtsi
> @@ -181,7 +181,7 @@
> #address-cells = <1>;
> #size-cells = <0>;
> reg = <0x0 0x1550000 0x0 0x10000>,
> - <0x0 0x40000000 0x0 0x40000000>;
> + <0x0 0x40000000 0x0 0x20000000>;
> reg-names = "QuadSPI", "QuadSPI-memory";
> interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>;
> clock-names = "qspi_en", "qspi";
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-08-22 4:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 10:50 [PATCH] arm: dts: ls1021a: fix QuadSPI-memory reg range Matthias Schiffer
2020-08-22 4:02 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200822040224.GC27575@dragon \
--to=shawnguo@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.schiffer@ew.tq-group.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).