* [PATCH] arm: dts: ls1021a: fix QuadSPI-memory reg range
@ 2020-07-28 10:50 Matthias Schiffer
2020-08-22 4:02 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Matthias Schiffer @ 2020-07-28 10:50 UTC (permalink / raw)
To: Shawn Guo, Li Yang; +Cc: Matthias Schiffer, linux-kernel, linux-arm-kernel
According to the Reference Manual, the correct size is 512 MiB.
Without this fix, probing the QSPI fails:
fsl-quadspi 1550000.spi: ioremap failed for resource
[mem 0x40000000-0x7fffffff]
fsl-quadspi 1550000.spi: Freescale QuadSPI probe failed
fsl-quadspi: probe of 1550000.spi failed with error -12
Fixes: 85f8ee78ab72 ("ARM: dts: ls1021a: Add support for QSPI with ls1021a SoC")
Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
---
arch/arm/boot/dts/ls1021a.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
index b2ff27af090e..9435ce527e85 100644
--- a/arch/arm/boot/dts/ls1021a.dtsi
+++ b/arch/arm/boot/dts/ls1021a.dtsi
@@ -181,7 +181,7 @@
#address-cells = <1>;
#size-cells = <0>;
reg = <0x0 0x1550000 0x0 0x10000>,
- <0x0 0x40000000 0x0 0x40000000>;
+ <0x0 0x40000000 0x0 0x20000000>;
reg-names = "QuadSPI", "QuadSPI-memory";
interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>;
clock-names = "qspi_en", "qspi";
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] arm: dts: ls1021a: fix QuadSPI-memory reg range
2020-07-28 10:50 [PATCH] arm: dts: ls1021a: fix QuadSPI-memory reg range Matthias Schiffer
@ 2020-08-22 4:02 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2020-08-22 4:02 UTC (permalink / raw)
To: Matthias Schiffer; +Cc: linux-kernel, linux-arm-kernel, Li Yang
On Tue, Jul 28, 2020 at 12:50:06PM +0200, Matthias Schiffer wrote:
> According to the Reference Manual, the correct size is 512 MiB.
>
> Without this fix, probing the QSPI fails:
>
> fsl-quadspi 1550000.spi: ioremap failed for resource
> [mem 0x40000000-0x7fffffff]
> fsl-quadspi 1550000.spi: Freescale QuadSPI probe failed
> fsl-quadspi: probe of 1550000.spi failed with error -12
>
> Fixes: 85f8ee78ab72 ("ARM: dts: ls1021a: Add support for QSPI with ls1021a SoC")
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Idiomatically we use 'ARM: ...' for arm32 DTS patch prefix.
I fixed it up and applied the patch.
Shawn
> ---
> arch/arm/boot/dts/ls1021a.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
> index b2ff27af090e..9435ce527e85 100644
> --- a/arch/arm/boot/dts/ls1021a.dtsi
> +++ b/arch/arm/boot/dts/ls1021a.dtsi
> @@ -181,7 +181,7 @@
> #address-cells = <1>;
> #size-cells = <0>;
> reg = <0x0 0x1550000 0x0 0x10000>,
> - <0x0 0x40000000 0x0 0x40000000>;
> + <0x0 0x40000000 0x0 0x20000000>;
> reg-names = "QuadSPI", "QuadSPI-memory";
> interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>;
> clock-names = "qspi_en", "qspi";
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-22 4:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-28 10:50 [PATCH] arm: dts: ls1021a: fix QuadSPI-memory reg range Matthias Schiffer
2020-08-22 4:02 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).