From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69E95C433E1 for ; Sat, 22 Aug 2020 16:47:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 36796206C0 for ; Sat, 22 Aug 2020 16:47:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dF4L//R+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36796206C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xFZBX4k7MBj6nIKH9H5DtKw3cOR+UwtIYst2eHX11xM=; b=dF4L//R+F9e/zs4yVBtL2oiL7 bhJ+JtQxYCiJsabJyrBmREq3h56m4OxYRAGBejcN1SAUPi0mZrp4RjeXuujJOjlbtpWgYG/AKJV3l EZpR2TC8GH/18TrQFYaYoI3euRgnMYT1c/BH39Duz8abaQdaP/9JusBA0OzUfMlPQiQuCl9hT64kz AG/3qkRj6l7ByG8YkjsDTR+iZAobeUC+tp4Yo8tyamA0C03UPUhMiHTFphgy9TbhnGitArzGTtCX+ mZ9+nopc6uBCEFAF9rd1edbX7SPItHjJmLUKXKraXtNS5Wn8f8D3fwrEYSp/B+ZtFfpzp0tyostIc MlP4iwdHw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k9Wew-0001eg-JR; Sat, 22 Aug 2020 16:46:26 +0000 Received: from mail-wr1-f65.google.com ([209.85.221.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k9Wet-0001e4-Le for linux-arm-kernel@lists.infradead.org; Sat, 22 Aug 2020 16:46:24 +0000 Received: by mail-wr1-f65.google.com with SMTP id 88so4695436wrh.3 for ; Sat, 22 Aug 2020 09:46:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5R45WyIAnbqcbbG55mI98dayf3fujaKdC3EcpGTogHM=; b=aHN/uW0eqMWF8Y0a6mqbIbJl4G1LtNxfacuuofKIf//rOPW9zukfK8Z3XbqTHQOjXw +GsH7GbAuy3hpYWD538ki+lUI5/HlLvksaDPfA0SCG75nmshZVKUg6v9y4GCqyF0Iz2w G5lcuqmozr2vHNdnhBmxKVKttbrPjczOPZuGyM/r0HaNG2FAb63UQjzd8v2jtqy4gKTp by1Awj7Wp0CMbNwnkoUHp4lIP17w4L04k6j0bokgTbEtUQ7096fxQwYGH07i4xvkCIli cXirfjpuQhricNSYrKOnC95FOFkxjnkntAOfZ05Ur9dMiOTygyjDzQVI+MRBA3cQPVoD K2iw== X-Gm-Message-State: AOAM533skRB/596GASOzmq17Hjbk0LjwmjiVbmM+KkZdv7i5MRfIh/gw RY4k9cHdB31opCw3GqNQkBc= X-Google-Smtp-Source: ABdhPJwrLlDLzKRAEQOAmkFk//RPAmiqV9qKTB3cvU2qzDP1KwESo/2+/t7CkhIrX4XhQve2+P3TPA== X-Received: by 2002:a5d:5485:: with SMTP id h5mr2710942wrv.247.1598114782209; Sat, 22 Aug 2020 09:46:22 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id z207sm14816477wmc.2.2020.08.22.09.46.21 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 22 Aug 2020 09:46:21 -0700 (PDT) Date: Sat, 22 Aug 2020 18:46:19 +0200 From: Krzysztof Kozlowski To: Markus Mayer Subject: Re: [PATCH v2] memory: brcmstb_dpfe: fix array index out of bounds Message-ID: <20200822164619.GA24669@kozik-lap> References: <20200821165221.32267-1-mmayer@broadcom.com> <20200822115636.GA19975@kozik-lap> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200822_124623_722140_C1721269 X-CRM114-Status: GOOD ( 21.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Colin Ian King , Florian Fainelli , BCM Kernel Feedback , Linux Kernel , Linux ARM Kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Aug 22, 2020 at 09:40:59AM -0700, Markus Mayer wrote: > On Sat, 22 Aug 2020 at 04:56, Krzysztof Kozlowski wrote: > > > > On Fri, Aug 21, 2020 at 09:52:21AM -0700, Markus Mayer wrote: > > > We would overrun the error_text array if we hit a TIMEOUT condition, > > > because we were using the error code "ETIMEDOUT" (which is 110) as an > > > array index. > > > > > > We fix the problem by correcting the array index and by providing a > > > function to retrieve error messages rather than accessing the array > > > directly. The function includes a bounds check that prevents the array > > > from being overrun. > > > > > > This patch was prepared in response to > > > https://lkml.org/lkml/2020/8/18/505. > > > > > > Signed-off-by: Markus Mayer > > > > Your Signed-off-by does not match From field. Please run > > scripts/checkpatch on every patch you send. > > > > I fixed it up, assuming markus.mayer@broadcom.com is the valid email > > address. > > No. I have always been using mmayer@broadcom.com since it is shorter. > That's also what's in the MAINTAINERS file. Please change it back. I > accidentally used the long form for one of my e-mail replies which is > where the confusion must have originated. I'll drop the patch then. You need to resend with SoB matching email. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel