From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66DDBC433E1 for ; Sat, 22 Aug 2020 20:48:18 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 342A42072D for ; Sat, 22 Aug 2020 20:48:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UZJHExPg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 342A42072D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7AKw5ijE3x6t1SmJzuACGYBzGPqOMKJKYo2UgpwTGss=; b=UZJHExPgkZc0HyLxrGC0QP9Lg G2X45IxXCkr22UVmhQUyN3A3h0oKTj0gwkmq+B1w46ch9c1FfhaBxs6aWmU3rjECPQeeRCLPVG7HC yWbMPR4QfjxbUcmMvBZAOapbRIToyhasITlX52tDbfbVaCd9R+WqENsufsoKlbw55Q2HCQnVMqAY5 pWViJT+WYmYgzlLH4/udy/5MpBJoQMIaT8Ms3BwCYV6ucf+vKFzObdC97eMct0nSaC608Tjb4ciUF +XoPpl1RpEDwQqR0XsxJmPSM9/iqCSs0TQuZm/BXtXYmuy7gOgMiPbqCl4SU+oRkxKRiqfZL1v3Yq vJTAOMhXA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k9aPX-0003OM-CM; Sat, 22 Aug 2020 20:46:47 +0000 Received: from mail-wr1-f66.google.com ([209.85.221.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k9aPU-0003Ny-BS for linux-arm-kernel@lists.infradead.org; Sat, 22 Aug 2020 20:46:45 +0000 Received: by mail-wr1-f66.google.com with SMTP id c15so4992849wrs.11 for ; Sat, 22 Aug 2020 13:46:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=9Gr2xPffZVQRfoQAWmaOU6SNPwZWSiCj059azzpqn7w=; b=Pug54qbefKBq36opTzas/mey6i1JamzIUFGaWqKhSL76QxBT4Pf6kmJZXWHrsj9Dg8 xvqg6QH3NeiNqm0Pp98LaLWn2nYw1kKRKl+dWF3gfzYe5JrRxE3w3hJ9eXf7Zc4rsbdP EMN3PnjsMd4V4BnMEMw9lT53GnarVvKaZTgsa+LH70WNJUnzRbXyrjc7JbpZwTPPXDuY /C9qtOJn/escykMiOzpPhddPym2pELYYKsLniSctBbgBHGsNv4xxoPbWx0JW5RoSucl/ 1QPqrPhGBFeKQHD7sJ0fEGGsexqHfpINLj+MITjXpGEaGxxbmpqqQ7OfqyIQucX/PHR7 /h4g== X-Gm-Message-State: AOAM530xnZFFlMtP6Yoxyoz6p/ipOSV3rfJ6jNy9ZDy9pBj+Cs2FV4ox mUHNScgk5IYEGLTTbaDLWrU= X-Google-Smtp-Source: ABdhPJzJ7F1ohCnzWKk78wVbBNfSi0oqyaDYqHUrkCC9qOsbkeGL9hUiLgDPy+LNElntvl6nwoGmmw== X-Received: by 2002:adf:e7c9:: with SMTP id e9mr8503345wrn.10.1598129202990; Sat, 22 Aug 2020 13:46:42 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id j24sm14532716wrb.49.2020.08.22.13.46.42 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 22 Aug 2020 13:46:42 -0700 (PDT) Date: Sat, 22 Aug 2020 22:46:40 +0200 From: Krzysztof Kozlowski To: Florian Fainelli Subject: Re: [PATCH v2] memory: brcmstb_dpfe: fix array index out of bounds Message-ID: <20200822204640.GA8064@kozik-lap> References: <20200821165221.32267-1-mmayer@broadcom.com> <20200822115636.GA19975@kozik-lap> <20200822164619.GA24669@kozik-lap> <81b2ad54-d4ef-cf98-886c-61c79e4cac62@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <81b2ad54-d4ef-cf98-886c-61c79e4cac62@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200822_164644_465211_C0337BF1 X-CRM114-Status: GOOD ( 32.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Colin Ian King , BCM Kernel Feedback , Linux ARM Kernel , Markus Mayer , Linux Kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Aug 22, 2020 at 01:21:47PM -0700, Florian Fainelli wrote: > > > On 8/22/2020 1:14 PM, Markus Mayer wrote: > > On Sat, 22 Aug 2020 at 09:46, Krzysztof Kozlowski wrote: > > > > > > On Sat, Aug 22, 2020 at 09:40:59AM -0700, Markus Mayer wrote: > > > > On Sat, 22 Aug 2020 at 04:56, Krzysztof Kozlowski wrote: > > > > > > > > > > On Fri, Aug 21, 2020 at 09:52:21AM -0700, Markus Mayer wrote: > > > > > > We would overrun the error_text array if we hit a TIMEOUT condition, > > > > > > because we were using the error code "ETIMEDOUT" (which is 110) as an > > > > > > array index. > > > > > > > > > > > > We fix the problem by correcting the array index and by providing a > > > > > > function to retrieve error messages rather than accessing the array > > > > > > directly. The function includes a bounds check that prevents the array > > > > > > from being overrun. > > > > > > > > > > > > This patch was prepared in response to > > > > > > https://lkml.org/lkml/2020/8/18/505. > > > > > > > > > > > > Signed-off-by: Markus Mayer > > > > > > > > > > Your Signed-off-by does not match From field. Please run > > > > > scripts/checkpatch on every patch you send. > > > > > > > > > > I fixed it up, assuming markus.mayer@broadcom.com is the valid email > > > > > address. > > > > > > > > No. I have always been using mmayer@broadcom.com since it is shorter. > > > > That's also what's in the MAINTAINERS file. Please change it back. I > > > > accidentally used the long form for one of my e-mail replies which is > > > > where the confusion must have originated. > > > > > > I'll drop the patch then. You need to resend with SoB matching email. > > > > Oh, I am starting to see what's happening here. This is new and > > apparently due to some changes with the mail server setup on our end. > > > > I have this in my patch file: > > > > $ head 0001-memory-brcmstb_dpfe-fix-array-index-out-of-bounds.patch > > From 6b424772d4c84fa56474b2522d0d3ed6b2b2b360 Mon Sep 17 00:00:00 2001 > > From: Markus Mayer > > Date: Fri, 21 Aug 2020 08:56:52 -0700 Which means your patch actually passed checkpatch on your computer so my comment about running it was not smart... :) > > Sending patches like this used to work. Clearly our SMTP server has > > now taken it upon itself to rewrite the sender e-mail address. I > > wasn't expecting that. Let me look into it. Sorry for the hassle. It > > was not intentional. > > Yes, if you used to use the SMTP relay server which did not require > authentication for internal hosts, and now you use smtp.gmail.com with your > broadcom.com username, the SMTP server will rewrite the From: to match the > username used to authenticate with the server. Markus' patch did not go via GMail. It was the Broadcom server which mangled the things. The email headers: Received: by mail.kernel.org (Postfix) Received: from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com [192.19.229.170]) by mail.kernel.org (Postfix) with ESMTPS id D5B3B20702 Received: from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net [10.75.242.48]) Received: from lbrmn-mmayer.ric.broadcom.net (lbrmn-mmayer.ric.broadcom.net [10.136.28.150]) From: Markus Mayer Neither kernel.org nor my final server (Gmail) cares about usernames in >From fields of some specific domain. I guess you could try configure you git send email to use email of "markus.mayer" while keeping Author "mmayer". You have to configure git send email for this and such configuration results in proper two "From" fields which maybe smtp broadcom won't change. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel