From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFF8CC433E1 for ; Sat, 22 Aug 2020 20:58:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A7532054F for ; Sat, 22 Aug 2020 20:58:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tFasNVhu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A7532054F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HbZg1fYW5liVx5ys3oo0uiBdgjeJX7D3flOD4sOxRFA=; b=tFasNVhuYudJ/ciWym/Y68GQJ 7wC1xtEQF63s1QgjcKPxpsNu6FmP3p2yb5Q0BFqjiD5otNwV/vxXKpc0+rgeLUzZiNSkjTo1HnU/G ZSoYY3a0xGrxWeKrMy/yOE3XaR4CdoNiws9Jn/czo78qqEHEAGQ5Y6ov3Uzr72bFZdER6QDtcVxQh umRz0ZfemM+7E9RNJZg4wS2sHfKDVcc+XJpDnTUKAmnX/pyzoJrLJdYG1UsqXsxLj9DPNRt6NXK0N TVXCyR0NVR/IUl9P9bqP4XPLNXErs+qEtPZ0jIqfjumc87i8cbifaY/PXxYKw9rNcOoTF+o62/+IU 8KjmIo8dQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k9aZ8-0004qg-Ax; Sat, 22 Aug 2020 20:56:42 +0000 Received: from mail-wr1-f66.google.com ([209.85.221.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k9aZ4-0004qA-L2 for linux-arm-kernel@lists.infradead.org; Sat, 22 Aug 2020 20:56:39 +0000 Received: by mail-wr1-f66.google.com with SMTP id f7so5067364wrw.1 for ; Sat, 22 Aug 2020 13:56:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=msxGa2IzZ+LQXZdwx/mj0NMbaUdlVNLfYIuR/2n+dNk=; b=qEHZm4uts6mbgmGqUPGOIA0E95R8oYve+2U/+7MI0O2Q9vZj0m5yATKPxXZNYDg5Wz n7NBtzdpSA3iy0FUZRr2cW3FziFDPX9TBz4iP7MDOBdZBpw1+HdArOo8O0eOSqRENZAR +v1W58ig/5Xw3BTFwowri/ErYOLW4hNrq5pLePPYjT9IhZ3zagXU30OTIge5Sx7phUWb zXoEwKc5Xh9qd8qnhWysCV1Dh0GEalVQ0kZS//t8Kfo3stggU7BUCm/C8IkgqHh5bYg0 MgmlTF2qBV//nULrUPnhvRrtQdozydP/xLov6M5TRRdO3jpyY27JDevWR9KCtMuB5taj vgJA== X-Gm-Message-State: AOAM532T02BrquyXDCeHXLCUv8Z3kGYW/SCXKI2QuxOXKk0YOpqALhjy 20Ln58gn2dXZyUv9v7xTLRQ= X-Google-Smtp-Source: ABdhPJxvXYFo8xjpn3BGJ6lHN0doaw/yA/+qpEQwDwyFBU5mHN+qOQsObLghzXpjaevzPBbYVgvfSA== X-Received: by 2002:a5d:4dcb:: with SMTP id f11mr4076853wru.9.1598129796472; Sat, 22 Aug 2020 13:56:36 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id h5sm14754940wrc.97.2020.08.22.13.56.35 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 22 Aug 2020 13:56:35 -0700 (PDT) Date: Sat, 22 Aug 2020 22:56:33 +0200 From: Krzysztof Kozlowski To: Markus Mayer Subject: Re: [PATCH v3] memory: brcmstb_dpfe: fix array index out of bounds Message-ID: <20200822205633.GA8809@kozik-lap> References: <20200822205000.15841-1-mmayer@broadcom.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200822205000.15841-1-mmayer@broadcom.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200822_165638_788605_0D9948E6 X-CRM114-Status: GOOD ( 18.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Colin Ian King , Florian Fainelli , BCM Kernel Feedback , Linux Kernel , Linux ARM Kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Aug 22, 2020 at 01:50:00PM -0700, Markus Mayer wrote: > We would overrun the error_text array if we hit a TIMEOUT condition, > because we were using the error code "ETIMEDOUT" (which is 110) as an > array index. > > We fix the problem by correcting the array index and by providing a > function to retrieve error messages rather than accessing the array > directly. The function includes a bounds check that prevents the array > from being overrun. > > This patch was prepared in response to > https://lkml.org/lkml/2020/8/18/505. > > Signed-off-by: Markus Mayer > Acked-by: Florian Fainelli > Fixes: 2f330caff577 ("memory: brcmstb: Add driver for DPFE") > Reported-by: Colin Ian King > --- > > Changes since v2: > - Added "Fixes:" and "Reported-by:" > - Fixed "From" address > - No changes to the code > > Changes since v1: > - Added link of the coverity report to the commit message. > - Added Florian's ack. > - Removed second "const" from get_error_text() return type > (thanks to the kernel test robot). > > drivers/memory/brcmstb_dpfe.c | 23 ++++++++++++++++------- > 1 file changed, 16 insertions(+), 7 deletions(-) "From" and SoB look good now. Thanks, applied. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel