From: Shawn Guo <shawnguo@kernel.org>
To: Chris Healy <cphealy@gmail.com>
Cc: devicetree@vger.kernel.org, andrew.smirnov@gmail.com,
s.hauer@pengutronix.de, linux-kernel@vger.kernel.org,
stefan@agner.ch, robh+dt@kernel.org,
srinivas.kandagatla@linaro.org, stable@vger.kernel.org,
kernel@pengutronix.de, festevam@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/2] dt-bindings: nvmem: Add syscon to Vybrid OCOTP driver
Date: Sun, 23 Aug 2020 11:12:28 +0800 [thread overview]
Message-ID: <20200823031227.GT30094@dragon> (raw)
In-Reply-To: <20200821212102.137991-1-cphealy@gmail.com>
On Fri, Aug 21, 2020 at 02:21:01PM -0700, Chris Healy wrote:
> From: Chris Healy <cphealy@gmail.com>
>
> Add syscon compatibility with Vybrid OCOTP driver binding. This is
> required to access the UID.
>
> Fixes: fa8d20c8dbb77 ("ARM: dts: vfxxx: Add node corresponding to OCOTP")
The bindings doc was not added by this commit though.
> Cc: stable@vger.kernel.org
> Signed-off-by: Chris Healy <cphealy@gmail.com>
> ---
> Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt b/Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt
> index 56ed481c3e26..5db39f399568 100644
> --- a/Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt
> +++ b/Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt
> @@ -11,7 +11,7 @@ Required Properties:
> Example for Vybrid VF5xx/VF6xx:
>
> ocotp: ocotp@400a5000 {
> - compatible = "fsl,vf610-ocotp";
> + compatible = "fsl,vf610-ocotp", "syscon";
It's not only about fixing example. More important one is "compatible"
property of the bindings.
Shawn
> #address-cells = <1>;
> #size-cells = <1>;
> reg = <0x400a5000 0xCF0>;
> --
> 2.26.2
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-08-23 3:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 21:21 [PATCH v3 1/2] dt-bindings: nvmem: Add syscon to Vybrid OCOTP driver Chris Healy
2020-08-21 21:21 ` [PATCH v3 2/2] ARM: dts: vfxxx: Add syscon compatible with OCOTP Chris Healy
2020-08-23 3:13 ` Shawn Guo
2020-08-23 3:12 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200823031227.GT30094@dragon \
--to=shawnguo@kernel.org \
--cc=andrew.smirnov@gmail.com \
--cc=cphealy@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=srinivas.kandagatla@linaro.org \
--cc=stable@vger.kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox