From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67D54C433E1 for ; Sun, 23 Aug 2020 18:52:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 328A720706 for ; Sun, 23 Aug 2020 18:52:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cWRIgtCK"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T+y2mGrE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 328A720706 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Owner; bh=4noldmInSVxAoGPOSGt3b69ZUNBpvWF71Iltea91cUA=; b=cWRIgtCKbUFa4n1S2R6/rEO+kz 0kjBxKdtXse7QmqbdzWdQxqIM+Muea3slAOyx1G6hY5+vGlbiIVSEmNAcMuvsk3i36I2y9Gp+Jkti 4EFexY75Ov/MasYR3+p+IgwkYFT1MAAWL71MRYNsi5Tb/Cq3disPGSfDc9ZUqVq63P9HPXIm/hmoI i+uEvhKouxo0Rwpu3qU4+tZ24Wu0utFemPnn587yZTzgrHvL5FoHMMQmQFJfGMr/qKlDL38zXZ0TX wSFeN+AmowuR37e/Z2bQUyuweyHdkZxeMsNqCebCZyd36G9xlZNU/rASKdsvsc11ncXbBoHiH8FX5 V/A8v7nA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k9v5D-0008OZ-Ik; Sun, 23 Aug 2020 18:51:11 +0000 Received: from mail-pj1-x1043.google.com ([2607:f8b0:4864:20::1043]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k9v59-0008LJ-Sf; Sun, 23 Aug 2020 18:51:09 +0000 Received: by mail-pj1-x1043.google.com with SMTP id q1so3038727pjd.1; Sun, 23 Aug 2020 11:51:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=wyU9tpC675HB0ixAAkXh4+zgCwIcMMcXIhj+1AOnOR8=; b=T+y2mGrEVr3tz7PLuTgcYkJwIC5IeEx/hSpwak1i56n6onfu7wNEQacYGOUsksCnSK gIlJQAsHS+JwZ5GaMMJbKk6TLlk90nA61uboFEsGFaUNEKNjyQc0eOiusrgcuSz27dmD Em8M9lUKz4Mjqcgp2V2oHAW7Lkz5wxsAb0fc4d/uCFZ+1R5XQdYFLHwEjNvXp39WmEC8 owsUxAW2xm4CkegIi0/KuYVAYGKdq8u9XcrwR0p/rX3w1l6AObuM2w2tEnos07ulT974 x2AlLnStHMVE5GPytevXmWOJsnguZsjstl5C4mRWPW1sSEXuqAu11MK7r7OiN5km2n72 2KwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=wyU9tpC675HB0ixAAkXh4+zgCwIcMMcXIhj+1AOnOR8=; b=hstc9/UVl++cGQTNJtEa60PkKsoIGdlU4w9ttazdB03fLU1iCenwO0PIRQPWRh2Ik8 raJf58mlwDYU8BqsKDtRM3nIYDYvaP4EFP96DakglOh3crOLbtmk0rpFJ8HND66LNTy5 w2aJ2p/bW2J99Ksg3HkI/dLCimjsQtgy4QzgDlfyfFoDYY05EnxDKxWcJaWlFiL21SLY gmianVQzZ5S53gFA8B6wtMWVnnQ8Z7IL6mAgFnAeww4TdFg6n7PK/0/uQvZ9qtmkesJE cE/oiE3sHIaCCWMvEFcvn1l6F8Hhr4zQTfQ25PPQ5t+KW/ZBCfwYAcrDA0LBBMBmWvdF 5hXg== X-Gm-Message-State: AOAM53039pEqpT2QKW5X9PJmVbKuJJW7J4WeD44JstXWXB/XHRywOF0a mzxizaQfJs8LWKaPNf3MTvA= X-Google-Smtp-Source: ABdhPJyaXB8AyrP/r8i55ExjjRdmeAd9G4Y9G2Cu8hHrxOKgTyf3tRAZ4Qd1pUWDrt9kNSOh62DXCA== X-Received: by 2002:a17:902:16a:: with SMTP id 97mr1516013plb.207.1598208665945; Sun, 23 Aug 2020 11:51:05 -0700 (PDT) Received: from localhost.localdomain ([49.207.217.77]) by smtp.gmail.com with ESMTPSA id s8sm861116pfm.180.2020.08.23.11.51.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Aug 2020 11:51:05 -0700 (PDT) From: Sumera Priyadarsini To: davem@davemloft.net Subject: [PATCH V2] net: dsa: Add of_node_put() before break statement Date: Mon, 24 Aug 2020 00:20:56 +0530 Message-Id: <20200823185056.16641-1-sylphrenadin@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200823_145108_045432_7F4782AF X-CRM114-Status: GOOD ( 13.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andrew@lunn.ch, f.fainelli@gmail.com, Sumera Priyadarsini , netdev@vger.kernel.org, sean.wang@mediatek.com, linux-kernel@vger.kernel.org, Julia.Lawall@lip6.fr, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, kuba@kernel.org, vivien.didelot@gmail.com, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Every iteration of for_each_child_of_node() decrements the reference count of the previous node, however when control is transferred from the middle of the loop, as in the case of a return or break or goto, there is no decrement thus ultimately resulting in a memory leak. Fix a potential memory leak in mt7530.c by inserting of_node_put() before the break statement. Issue found with Coccinelle. --- Changes in v2: Add another of_node_put() in for_each_child_of_node() as pointed out by Andrew. --- Signed-off-by: Sumera Priyadarsini --- drivers/net/dsa/mt7530.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c index 8dcb8a49ab67..e81198a65c26 100644 --- a/drivers/net/dsa/mt7530.c +++ b/drivers/net/dsa/mt7530.c @@ -1327,6 +1327,7 @@ mt7530_setup(struct dsa_switch *ds) if (phy_node->parent == priv->dev->of_node->parent) { ret = of_get_phy_mode(mac_np, &interface); if (ret && ret != -ENODEV) + of_node_put(mac_np) return ret; id = of_mdio_parse_addr(ds->dev, phy_node); if (id == 0) @@ -1334,6 +1335,7 @@ mt7530_setup(struct dsa_switch *ds) if (id == 4) priv->p5_intf_sel = P5_INTF_SEL_PHY_P4; } + of_node_put(mac_np); of_node_put(phy_node); break; } -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel