From: Andrew Lunn <andrew@lunn.ch>
To: Sumera Priyadarsini <sylphrenadin@gmail.com>
Cc: f.fainelli@gmail.com, netdev@vger.kernel.org,
sean.wang@mediatek.com, linux-kernel@vger.kernel.org,
vivien.didelot@gmail.com, Julia.Lawall@lip6.fr,
linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com,
kuba@kernel.org, davem@davemloft.net,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2] net: dsa: Add of_node_put() before break statement
Date: Sun, 23 Aug 2020 21:13:08 +0200 [thread overview]
Message-ID: <20200823191308.GG2588906@lunn.ch> (raw)
In-Reply-To: <20200823185056.16641-1-sylphrenadin@gmail.com>
> diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
> index 8dcb8a49ab67..e81198a65c26 100644
> --- a/drivers/net/dsa/mt7530.c
> +++ b/drivers/net/dsa/mt7530.c
> @@ -1327,6 +1327,7 @@ mt7530_setup(struct dsa_switch *ds)
> if (phy_node->parent == priv->dev->of_node->parent) {
> ret = of_get_phy_mode(mac_np, &interface);
> if (ret && ret != -ENODEV)
> + of_node_put(mac_np)
> return ret;
> id = of_mdio_parse_addr(ds->dev, phy_node);
> if (id == 0)
You are missing some { }. And a ; . I'm surprised gcc did not warn
you!
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-23 19:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-23 18:50 [PATCH V2] net: dsa: Add of_node_put() before break statement Sumera Priyadarsini
2020-08-23 19:13 ` Andrew Lunn [this message]
2020-08-23 22:39 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200823191308.GG2588906@lunn.ch \
--to=andrew@lunn.ch \
--cc=Julia.Lawall@lip6.fr \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sean.wang@mediatek.com \
--cc=sylphrenadin@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).