From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87FFEC433E1 for ; Sun, 23 Aug 2020 23:27:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5589820720 for ; Sun, 23 Aug 2020 23:27:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="vkofAzDi"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="kOIZkfXL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5589820720 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ncza5pBKD6NjAoFWGcEZ9bsCqtcJ116/cyXEofb4JsI=; b=vkofAzDips4geVsJtXmlBu0JH 4at/yjTbdvHL1ShVJavdIVX16BYJiE9mjh8CIU2JutnxGtUKITP9qgjbgOOF6wER1x0sAPOdTeYbP B4qmldiPK2QUZ/CYDdgkci9hdWMLoqJLxYzX7uOc24sZDtKG917lZRGMpU8hoS+TIngUBlVNy+0Mr Dco4kUKRDOLCXPSX51BgeOGhQRIeLtRd3g8CyQQNHTmmu2+MbxMnYS/BjZXqHjpP/3MQevjLoExTJ FBL5eHOgEw2/ZIHuVQ7qb7/15XoluqZ/nHPQtzA8g2ug037j7X99OVQMRGXeu9QohfKBzuFRnWTgt dxXdwlztg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k9zNZ-0004Sk-Q9; Sun, 23 Aug 2020 23:26:25 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k9zNW-0004Q1-VG for linux-arm-kernel@lists.infradead.org; Sun, 23 Aug 2020 23:26:23 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id AC160279; Mon, 24 Aug 2020 01:26:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1598225181; bh=j95pElnESYCX30E2SE8Ad9EQbgQWT6k8KuqUviG92Tw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kOIZkfXLKzc45KI4X227eqB/o2OnHF3xIepJZTqUBMksikgV0fFuVsRMauhsUSJKY A5x7FWdDQxB+KbHtTPXLaNqwkmo1cuIl7xnlS5WqyYkSPNicGlqDYJUfT3iFkYI5IU K3+CH12kgV3mkwjfTXX2LD1s+tC8C6MECkJy5mVA= Date: Mon, 24 Aug 2020 02:26:03 +0300 From: Laurent Pinchart To: Stefan Agner Subject: Re: [PATCH 2/8] dt-bindings: display: mxsfb: Add and fix compatible strings Message-ID: <20200823232603.GO6002@pendragon.ideasonboard.com> References: <20200813012910.13576-1-laurent.pinchart@ideasonboard.com> <20200813012910.13576-3-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200823_192623_163242_16193355 X-CRM114-Status: GOOD ( 22.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , devicetree@vger.kernel.org, Guido =?utf-8?Q?G=C3=BCnther?= , dri-devel@lists.freedesktop.org, Rob Herring , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Stefan, On Fri, Aug 21, 2020 at 04:53:56PM +0200, Stefan Agner wrote: > On 2020-08-13 03:29, Laurent Pinchart wrote: > > Additional compatible strings have been added in DT source for the > > i.MX6SL, i.MX6SLL, i.MX6UL and i.MX7D without updating the bindings. > > Most of the upstream DT sources use the fsl,imx28-lcdif compatible > > string, which mostly predates the realization that the LCDIF in the > > i.MX6 and newer SoCs have extra features compared to the i.MX28. > > Agreed, we should add fsl,imx6sx-lcdif for those devices. > > But shouldn't we also keep fsl,imx28-lcdif? From what I can tell, the > devices can be driven by a driver only supporting fsl,imx28-lcdif > semantics, right? Isn't it kept by this patch ? > > Update the bindings to add the missing compatible strings, with the > > correct fallback values. This fails to validate some of the upstream DT > > sources. Instead of adding the incorrect compatible fallback to the > > binding, the sources should be updated separately. > > > > Signed-off-by: Laurent Pinchart > > --- > > .../devicetree/bindings/display/mxsfb.yaml | 18 +++++++++++++----- > > 1 file changed, 13 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/display/mxsfb.yaml > > b/Documentation/devicetree/bindings/display/mxsfb.yaml > > index 202381ec5bb7..ec6533b1d4a3 100644 > > --- a/Documentation/devicetree/bindings/display/mxsfb.yaml > > +++ b/Documentation/devicetree/bindings/display/mxsfb.yaml > > @@ -15,11 +15,19 @@ description: | > > > > properties: > > compatible: > > - enum: > > - - fsl,imx23-lcdif > > - - fsl,imx28-lcdif > > - - fsl,imx6sx-lcdif > > - - fsl,imx8mq-lcdif > > + oneOf: > > + - enum: > > + - fsl,imx23-lcdif > > + - fsl,imx28-lcdif Here -----------------^ The binding now support any of "fsl,imx23-lcdif", "fsl,imx28-lcdif" or "fsl,imx6sx-lcdif" alone, or "fsl,imx6sx-lcdif" with another device-specific compatible string. The driver supports the three base compatible strings, for V3, V4 and V6 of the IP core. > > + - fsl,imx6sx-lcdif > > + - items: > > + - enum: > > + - fsl,imx6sl-lcdif > > + - fsl,imx6sll-lcdif > > + - fsl,imx6ul-lcdif > > + - fsl,imx7d-lcdif > > + - fsl,imx8mq-lcdif > > + - const: fsl,imx6sx-lcdif > > > > reg: > > maxItems: 1 -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel