From: David Miller <davem@davemloft.net>
To: sylphrenadin@gmail.com
Cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org,
sean.wang@mediatek.com, linux-kernel@vger.kernel.org,
Julia.Lawall@lip6.fr, linux-mediatek@lists.infradead.org,
matthias.bgg@gmail.com, kuba@kernel.org,
vivien.didelot@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V3] net: dsa: Add of_node_put() before break and return statements
Date: Mon, 24 Aug 2020 06:20:52 -0700 (PDT) [thread overview]
Message-ID: <20200824.062052.523630350034926727.davem@davemloft.net> (raw)
In-Reply-To: <20200823193054.29336-1-sylphrenadin@gmail.com>
From: Sumera Priyadarsini <sylphrenadin@gmail.com>
Date: Mon, 24 Aug 2020 01:00:54 +0530
> ---
>
> Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
>
> Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
You only need one Signed-off-by:
You must not put the signoff after the "---" otherwise GIT will remove
it from the commit log message when I try to apply your patch.
Combine this with the fact that your change didn't even compile
properly up until even V2, I wish you would put more effort and
care into your patch submission. It feels to reviewers like
you are just throwing this patch onto the mailing list without
much care or testing at all.
Thank you.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-24 13:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-23 19:30 [PATCH V3] net: dsa: Add of_node_put() before break and return statements Sumera Priyadarsini
2020-08-24 13:20 ` David Miller [this message]
2020-08-24 13:35 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824.062052.523630350034926727.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Julia.Lawall@lip6.fr \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sean.wang@mediatek.com \
--cc=sylphrenadin@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox