Re: [PATCH V2 1/2] opp: Allow dev_pm_opp_get_opp_table() to return -EPROBE_DEFER

Viresh Kumar
2020-10-28T04:09:01Z

On 27-10-20, 15:24, Guenter Roeck wrote:
> Trying again through different e-mail provider. My previous e-mail
> got stuck in spam filters. Apologies if this is received multiple
> times.

I received only once :)

> On Mon, Aug 24, 2020 at 02:39:32PM +0530, Viresh Kumar wrote:
> > From: Stephan Gerhold <stephan@gerhold.net>
> >
> [ ... ]

You removed way too much and this lost the context. Keeping the
routine's prototype line would have been useful.

> >
> > opp_table = dev_pm_opp_get_opp_table(dev);
> > - if (!opp_table)
> > - return ERR_PTR(-ENOMEM);
> > + if (!IS_ERR(opp_table))
> > + return opp_table;
>
> This should have been
>
> if (IS_ERR(opp_table))
> return opp_table;

I believe this is the delta from dev_pm_opp_register_set_opp_helper()
?

A proper fix is already pushed in linux-next for this yesterday.

--
viresh