From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DC12C433E1 for ; Mon, 24 Aug 2020 10:48:57 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EE1FA2071E for ; Mon, 24 Aug 2020 10:48:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="abwWBRdT"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="c/6rJ9cD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE1FA2071E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=A5isCDqMRfmiT7pdxs634td1cwAT4ccVegYnx+YKZ3M=; b=abwWBRdT4WawmkPr+BDS7L4+v IBP1Xtv7JOE+UKpy4j0HacfwD3vsAdBV730GBbT0V46qJkArvTFNxUrRA7w82sQSAQMKtadZRnmNf 2Q2lX8H4qcn6Xg3NzGaRPm3cc64QL2xRhhvXv1CQ2NbdNrRnJ2EoLnHL5Kfnep7IigT6U0bLHkny1 O+0ELDkh3p7XTIarfqX48Hz58pvyqDIHyi5of7a6cZ1MRtcvxm/SlV/CLmFH+mw52Ndmve/Fr3SL7 r+rTirUPFyV1vhTW5PSVVwUMIpVwAQrQOuVaTg7zY/ceosecD9gWAItBqLmgqpgQBIu+u71MvcB9c M1tECi18w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAA0o-0004P1-UJ; Mon, 24 Aug 2020 10:47:38 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAA0m-0004OG-4W for linux-arm-kernel@lists.infradead.org; Mon, 24 Aug 2020 10:47:37 +0000 Received: from dragon (unknown [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BF57F2071E; Mon, 24 Aug 2020 10:47:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598266054; bh=G1EuT7WRdVE2XHuuoDboS9gTa7E+TX7S2m2v/JaoZTs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c/6rJ9cDMEh8WN0Di+Ss8+wulQMZcrXJZ0RtbJ2Vrqj5eS7W1BzvgoSEphYrUwT6g ovdc8a8Scnywli4DYjN6NP+FsiIvAf0m4qROJ2f25yKKjb6HBg4B4XZjUFfeFYgCBm 1681B+Y0+T30BwX6IYJJ4CqYVscfn7ZLEeKU5dAc= Date: Mon, 24 Aug 2020 18:47:19 +0800 From: Shawn Guo To: Krzysztof Kozlowski Subject: Re: [PATCH v2 4/4] arm64: dts: imx8mm-var-som-symphony: Add Variscite Symphony board with VAR-SOM-MX8MM Message-ID: <20200824104718.GC12776@dragon> References: <20200817070120.4937-1-krzk@kernel.org> <20200817070120.4937-4-krzk@kernel.org> <20200823020051.GJ30094@dragon> <20200823085847.GC2886@kozik-lap> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200823085847.GC2886@kozik-lap> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200824_064736_367759_28E7D735 X-CRM114-Status: GOOD ( 27.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Anson Huang , Sascha Hauer , linux-kernel@vger.kernel.org, Li Yang , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Aug 23, 2020 at 10:58:47AM +0200, Krzysztof Kozlowski wrote: > On Sun, Aug 23, 2020 at 10:00:51AM +0800, Shawn Guo wrote: > > On Mon, Aug 17, 2020 at 09:01:20AM +0200, Krzysztof Kozlowski wrote: > > > Add a DTS for Variscite Symphony evaluation kit with VAR-SOM-MX8MM > > > System on Module. > > > > > > Signed-off-by: Krzysztof Kozlowski > > > > > > --- > > > > > > Changes since v1: > > > 1. Remove duplicated "leds" node, > > > 2. Fix heartbeat to active low, > > > 3. Add nxp,ptn5150 extcon. > > > --- > > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > > .../dts/freescale/imx8mm-var-som-symphony.dts | 248 ++++++++++++++++++ > > > 2 files changed, 249 insertions(+) > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dts > > > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > > > index a39f0a1723e0..dcfb8750cd78 100644 > > > --- a/arch/arm64/boot/dts/freescale/Makefile > > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > > @@ -29,6 +29,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-qds.dtb > > > dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mn-ddr4-evk.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk.dtb > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dts b/arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dts > > > new file mode 100644 > > > index 000000000000..2d3c30ac5e04 > > > --- /dev/null > > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dts > > > @@ -0,0 +1,248 @@ > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > +/* > > > + * Copyright (C) 2020 Krzysztof Kozlowski > > > + */ > > > + > > > +/dts-v1/; > > > + > > > +#include "imx8mm-var-som.dtsi" > > > + > > > +/ { > > > + model = "Variscite VAR-SOM-MX8MM Symphony evaluation board"; > > > + compatible = "variscite,var-som-mx8mm-symphony", "variscite,var-som-mx8mm", "fsl,imx8mm"; > > > + > > > + reg_usdhc2_vmmc: regulator-1 { > > > > regulator-usdhc2-vmmc > > You mean the node name? If so, it's not correct with device tree > specification: > "The node-name (...) should describe the general class of device.: > If appropriate, the name should be one of the following choices: > (...) > - regulator" > > Adding specific function/type/usage to the name of the node is a > opposite choice to "general class". Well, the node is named in general class, i.e. regulator-xxx, and we would like the suffix to be a bit more specific. We have been using this name schema for fixed-regulator on i.MX platforms for long time. Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel