From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AEB0C433DF for ; Mon, 24 Aug 2020 10:54:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF1A12071E for ; Mon, 24 Aug 2020 10:54:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Tv68Wegg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF1A12071E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bHdLBpduuNPG35InAwN8xcOHkBp1C/TnFd5Rfx1ghbo=; b=Tv68WegguFllDAgw5rRf6Bs9B dsGLwAPIqlnITPb1F1Ba3lFV4rdrgryeQJnnQQDw6meh3RvUHvt128kydFmTeewS9xz405GW+0aAU RITV1Hl++EwWlTHI+eVPy1rgJG0+AcSiieQn2z067T2DK842mLy7nE2EFUFawckjcpvr4I5WzYspG Wad7oWTQksbVFmzAlxNKmyPHFmHR+uRDxx6q3ZztrEZskTLs+OJtM9FcZaM9IZaIfHfC0BiuRa7jo exbATGrCMx/H4XqEkpja1uqyOQwJykvDgT9DCSqVyMfSfjgqEUz/d4JhfqxzvojmBijzWIdQ8kk4Q sdaCziTHQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAA69-0005LV-3k; Mon, 24 Aug 2020 10:53:09 +0000 Received: from mail-wm1-f67.google.com ([209.85.128.67]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAA67-0005Kw-Fo for linux-arm-kernel@lists.infradead.org; Mon, 24 Aug 2020 10:53:08 +0000 Received: by mail-wm1-f67.google.com with SMTP id y8so1971776wma.0 for ; Mon, 24 Aug 2020 03:53:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=8tUXtK9Uo1WfECoGzPEeRZ8dUOgvco4xZiJV1j3yK2Y=; b=chwkIIbV+LuwlNf8Em/Pg8SJB2oBUqbqku79SUqWeUudfloWBy+SXR9Ex8bUX1AMSO KWJIV2TvlYW0EiQZMZiCIqjsEpZcrJ2OEUVHWGB4GUVe2HIFAwyD4C+AlfvoQJrrHHbC Zct56TP7+3Lh6DH2cJob8WUf2qaPzeIpiSnZrgmaHyBITtpNsfFm7qH2IbpexH+oO4Sm JLsrgXZOstsLzNOEsL2OmmXKXFV0c13N8m5tlYYjURa3BbAWJUKkZKB8SpTtP/7H1C1b 8Qax0DGQyR0F09e+TP8klJbRX5Jlb/4UqYgQqFSq1x6B9JXk0h6Dk1n6vEFf+xOPQldR wdMQ== X-Gm-Message-State: AOAM533oyXQTaxDURLFyP7TdcYFU6DF0oF5F3nPx0lmIK2IEMndl7/8Q ZniTD0EpBKcZKHR2isHFQ60Qh194cwI= X-Google-Smtp-Source: ABdhPJxWWIX9hAxIRnMQN/xNYUKKY4EpLDyOC668+DgpUXg2I6pfWXrVb3ipIlX9lnWcCo3YPXiVDQ== X-Received: by 2002:a7b:c1c1:: with SMTP id a1mr5187679wmj.137.1598266386477; Mon, 24 Aug 2020 03:53:06 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id m1sm22881072wmc.28.2020.08.24.03.53.05 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 24 Aug 2020 03:53:05 -0700 (PDT) Date: Mon, 24 Aug 2020 12:53:03 +0200 From: Krzysztof Kozlowski To: Shawn Guo Subject: Re: [PATCH v2 4/4] arm64: dts: imx8mm-var-som-symphony: Add Variscite Symphony board with VAR-SOM-MX8MM Message-ID: <20200824105303.GA32211@kozik-lap> References: <20200817070120.4937-1-krzk@kernel.org> <20200817070120.4937-4-krzk@kernel.org> <20200823020051.GJ30094@dragon> <20200823085847.GC2886@kozik-lap> <20200824104718.GC12776@dragon> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200824104718.GC12776@dragon> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200824_065307_536405_B1CA63D5 X-CRM114-Status: GOOD ( 32.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Anson Huang , Sascha Hauer , linux-kernel@vger.kernel.org, Li Yang , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 24, 2020 at 06:47:19PM +0800, Shawn Guo wrote: > On Sun, Aug 23, 2020 at 10:58:47AM +0200, Krzysztof Kozlowski wrote: > > On Sun, Aug 23, 2020 at 10:00:51AM +0800, Shawn Guo wrote: > > > On Mon, Aug 17, 2020 at 09:01:20AM +0200, Krzysztof Kozlowski wrote: > > > > Add a DTS for Variscite Symphony evaluation kit with VAR-SOM-MX8MM > > > > System on Module. > > > > > > > > Signed-off-by: Krzysztof Kozlowski > > > > > > > > --- > > > > > > > > Changes since v1: > > > > 1. Remove duplicated "leds" node, > > > > 2. Fix heartbeat to active low, > > > > 3. Add nxp,ptn5150 extcon. > > > > --- > > > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > > > .../dts/freescale/imx8mm-var-som-symphony.dts | 248 ++++++++++++++++++ > > > > 2 files changed, 249 insertions(+) > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dts > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > > > > index a39f0a1723e0..dcfb8750cd78 100644 > > > > --- a/arch/arm64/boot/dts/freescale/Makefile > > > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > > > @@ -29,6 +29,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-qds.dtb > > > > dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb > > > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb > > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mn-ddr4-evk.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk.dtb > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dts b/arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dts > > > > new file mode 100644 > > > > index 000000000000..2d3c30ac5e04 > > > > --- /dev/null > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dts > > > > @@ -0,0 +1,248 @@ > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > > +/* > > > > + * Copyright (C) 2020 Krzysztof Kozlowski > > > > + */ > > > > + > > > > +/dts-v1/; > > > > + > > > > +#include "imx8mm-var-som.dtsi" > > > > + > > > > +/ { > > > > + model = "Variscite VAR-SOM-MX8MM Symphony evaluation board"; > > > > + compatible = "variscite,var-som-mx8mm-symphony", "variscite,var-som-mx8mm", "fsl,imx8mm"; > > > > + > > > > + reg_usdhc2_vmmc: regulator-1 { > > > > > > regulator-usdhc2-vmmc > > > > You mean the node name? If so, it's not correct with device tree > > specification: > > "The node-name (...) should describe the general class of device.: > > If appropriate, the name should be one of the following choices: > > (...) > > - regulator" > > > > Adding specific function/type/usage to the name of the node is a > > opposite choice to "general class". > > Well, the node is named in general class, i.e. regulator-xxx, and we > would like the suffix to be a bit more specific. We have been using > this name schema for fixed-regulator on i.MX platforms for long time. Name "regulator-usdhc2-vmmc" is not general, it is specific. The DT specification gives the example of generic name and it is "regulator". It is the same with CPU nodes having names "cpu@0", not "cpu-a53@0" or whatever other suffix. It is the same reason why I2C is "i2c@12345678", not "i2c_1@" or "i2c_for_abcd". The suffix is not needed as Linux does not use it (instead uses regulator-name which is specific). Humans on the other hand can understand the specifics from the label and from the regulator name. Therefore they also do not need the suffix. I know that other i.MX DTSes follow this pattern but it is still not the recommended one. It's a pattern which should be replaced. Anyway, if the names of regulators stop this patch from being applied, I will change them to expected. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel