From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB4FDC433DF for ; Mon, 24 Aug 2020 12:03:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC9C72078D for ; Mon, 24 Aug 2020 12:03:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="12H3yfFS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC9C72078D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Bbd7IUOYH5Qsgtn2ft9b4YXWDcm4yOoQ7Wx0sFXwIso=; b=12H3yfFSMOmjthqiSoVG+21LL 71wm4SgHuIV7UD6fpQrRrvVnX2c/EJLliiCAB2oeXOCz7M+QU5PrxMdDYwCrdKUX51uyr5kV9tm2L gWvuLE+Vq44cZ7BiefQmMxmEfnJsU8x59lx0qOEk7l5HrjSiqdAuZlWmyMAQA9mVQYyJhFZSU8DuI CEs0yxb1UbhWk7yO7zcP4p1SDtUK3eDnldKPtgXYwitV6SZEVD2Zh5T42i6Qmp52xp0ih6bApAmX9 DQuv8vYniRuZcCK8GhSqkJh0IVPCTmAHDTXCL2IAMN7mHFE+DgVg2sGBUk3LNBNn7makQMj1IRYuK Q/xrPwcHw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kABAy-00062u-4v; Mon, 24 Aug 2020 12:02:12 +0000 Received: from mail-wm1-f66.google.com ([209.85.128.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kABAw-00062B-DN for linux-arm-kernel@lists.infradead.org; Mon, 24 Aug 2020 12:02:11 +0000 Received: by mail-wm1-f66.google.com with SMTP id x9so3999702wmi.2 for ; Mon, 24 Aug 2020 05:02:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ShrC8bNE0fWXwV7cdyP50z+72KVJ6UwIOeGyUMMXgFg=; b=gfrH73y1Pxjvhh4QZDjlYqWgdMPlc1dMWkwEWb9U5IP0TrmmtPg9wG6NaRcNarJLAU pktcAl83SHmijEWcFS61MCc+17ANwK6CBz2BDbTq9foWPz4EyZcCzg1MXwrfWupO1x6E DaUoOdkkqMTZjvG9C5oTXJTadQ/wBBZuzMaqAtQDloDQu8n0CETRC8R3kuGKQniczSZt C2ucprcdk1pZnMeYLVxknYjrM8jAeG79ZLrPzovbhdIc96RLqTpBBkjQVva57XWY+JQY 8fW0Un0IP/aul3SNtKUOAu+69YvHPw7eOfBfeLs6kvMwNVnb9kVN6QtDziqBqUK8h1Qe XvdA== X-Gm-Message-State: AOAM531vJQZ3+jyssKO28yRSn1dcZ6MSKqo7cuzOJ4Fr+NvyQ7beWa1F A9JS82NYii6CPiyEi4SjcOxTeJKWLlE= X-Google-Smtp-Source: ABdhPJzF1cM0Zjw0kxDgr2wLhdwUVnQA5czSUo+QkX5E+42+jzTSTB2poBG97XmO5GaNvpJJfYU/Wg== X-Received: by 2002:a1c:48c2:: with SMTP id v185mr5294620wma.5.1598270528919; Mon, 24 Aug 2020 05:02:08 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id y2sm25347861wmg.25.2020.08.24.05.01.48 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 24 Aug 2020 05:02:08 -0700 (PDT) Date: Mon, 24 Aug 2020 14:01:39 +0200 From: Krzysztof Kozlowski To: Lukasz Luba Subject: Re: [PATCH 2/3] memory: samsung: exynos5422-dmc: remove unused exynos5_dmc members Message-ID: <20200824115815.GA5258@kozik-lap> References: <20200822163218.21857-1-krzk@kernel.org> <20200822163218.21857-2-krzk@kernel.org> <6c61572d-ef7a-ca0a-2253-7a3c0736f0a5@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6c61572d-ef7a-ca0a-2253-7a3c0736f0a5@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200824_080210_478516_297CECE4 X-CRM114-Status: GOOD ( 22.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, Kukjin Kim , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 24, 2020 at 12:43:33PM +0100, Lukasz Luba wrote: > Hi Krzysztof, > > On 8/22/20 5:32 PM, Krzysztof Kozlowski wrote: > > The struct exynos5_dmc members bypass_rate, mx_mspll_ccore_phy, > > mout_mx_mspll_ccore_phy and opp_bypass are not actually used. > > > > Apparently there was a plan to store the OPP for the bypass mode in > > opp_bypass member, but drivers fails to do it and instead always sets > > target voltage during bypass mode. > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > drivers/memory/samsung/exynos5422-dmc.c | 9 --------- > > 1 file changed, 9 deletions(-) > > > > diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c > > index 31864ce59b25..df02afa8aa90 100644 > > --- a/drivers/memory/samsung/exynos5422-dmc.c > > +++ b/drivers/memory/samsung/exynos5422-dmc.c > > @@ -123,9 +123,7 @@ struct exynos5_dmc { > > struct mutex lock; > > unsigned long curr_rate; > > unsigned long curr_volt; > > - unsigned long bypass_rate; > > struct dmc_opp_table *opp; > > - struct dmc_opp_table opp_bypass; > > int opp_count; > > u32 timings_arr_size; > > u32 *timing_row; > > @@ -143,8 +141,6 @@ struct exynos5_dmc { > > struct clk *mout_bpll; > > struct clk *mout_mclk_cdrex; > > struct clk *mout_mx_mspll_ccore; > > - struct clk *mx_mspll_ccore_phy; > > - struct clk *mout_mx_mspll_ccore_phy; > > struct devfreq_event_dev **counter; > > int num_counters; > > u64 last_overflow_ts[2]; > > @@ -455,9 +451,6 @@ static int exynos5_dmc_align_bypass_voltage(struct exynos5_dmc *dmc, > > unsigned long target_volt) > > { > > int ret = 0; > > - unsigned long bypass_volt = dmc->opp_bypass.volt_uv; > > - > > - target_volt = max(bypass_volt, target_volt); > > > Could you explain which use cases you considered when you decided to > remove these lines? There are no use cases attached to these. These are simply not used, never assigned a value. For example max(0, target_volt) is always equal to target_volt for unsigned numbers... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel