From: Krzysztof Kozlowski <krzk@kernel.org>
To: Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Adam Ford <aford173@gmail.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Anson Huang <Anson.Huang@nxp.com>,
Robin Gong <yibin.gong@nxp.com>, Li Jun <jun.li@nxp.com>,
Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Han Xu <han.xu@nxp.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Subject: [PATCH 02/16] dt-bindings: mtd: gpmi-nand: Fix matching of clocks on different SoCs
Date: Mon, 24 Aug 2020 21:06:47 +0200 [thread overview]
Message-ID: <20200824190701.8447-2-krzk@kernel.org> (raw)
In-Reply-To: <20200824190701.8447-1-krzk@kernel.org>
Driver requires different amount of clocks for different SoCs. Describe
these requirements properly to fix dtbs_check warnings like:
arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dt.yaml: nand-controller@33002000: clock-names:1: 'gpmi_apb' was expected
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
.../devicetree/bindings/mtd/gpmi-nand.yaml | 76 +++++++++++++++----
1 file changed, 61 insertions(+), 15 deletions(-)
diff --git a/Documentation/devicetree/bindings/mtd/gpmi-nand.yaml b/Documentation/devicetree/bindings/mtd/gpmi-nand.yaml
index 28ff8c581837..9d764e654e1d 100644
--- a/Documentation/devicetree/bindings/mtd/gpmi-nand.yaml
+++ b/Documentation/devicetree/bindings/mtd/gpmi-nand.yaml
@@ -9,9 +9,6 @@ title: Freescale General-Purpose Media Interface (GPMI) binding
maintainers:
- Han Xu <han.xu@nxp.com>
-allOf:
- - $ref: "nand-controller.yaml"
-
description: |
The GPMI nand controller provides an interface to control the NAND
flash chips. The device tree may optionally contain sub-nodes
@@ -58,22 +55,10 @@ properties:
clocks:
minItems: 1
maxItems: 5
- items:
- - description: SoC gpmi io clock
- - description: SoC gpmi apb clock
- - description: SoC gpmi bch clock
- - description: SoC gpmi bch apb clock
- - description: SoC per1 bch clock
clock-names:
minItems: 1
maxItems: 5
- items:
- - const: gpmi_io
- - const: gpmi_apb
- - const: gpmi_bch
- - const: gpmi_bch_apb
- - const: per1_bch
fsl,use-minimum-ecc:
type: boolean
@@ -107,6 +92,67 @@ required:
unevaluatedProperties: false
+allOf:
+ - $ref: "nand-controller.yaml"
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - fsl,imx23-gpmi-nand
+ - fsl,imx28-gpmi-nand
+ then:
+ properties:
+ clocks:
+ items:
+ - description: SoC gpmi io clock
+ clock-names:
+ items:
+ - const: gpmi_io
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - fsl,imx6q-gpmi-nand
+ - fsl,imx6sx-gpmi-nand
+ then:
+ properties:
+ clocks:
+ items:
+ - description: SoC gpmi io clock
+ - description: SoC gpmi apb clock
+ - description: SoC gpmi bch clock
+ - description: SoC gpmi bch apb clock
+ - description: SoC per1 bch clock
+ clock-names:
+ items:
+ - const: gpmi_io
+ - const: gpmi_apb
+ - const: gpmi_bch
+ - const: gpmi_bch_apb
+ - const: per1_bch
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: fsl,imx7d-gpmi-nand
+ then:
+ properties:
+ clocks:
+ items:
+ - description: SoC gpmi io clock
+ - description: SoC gpmi bch apb clock
+ clock-names:
+ minItems: 2
+ maxItems: 2
+ items:
+ - const: gpmi_io
+ - const: gpmi_bch_apb
+
examples:
- |
nand-controller@8000c000 {
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-24 19:09 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 19:06 [PATCH 01/16] dt-bindings: mfd: rohm, bd71847-pmic: Correct clock properties requirements Krzysztof Kozlowski
2020-08-24 19:06 ` Krzysztof Kozlowski [this message]
2020-08-25 6:40 ` [PATCH 02/16] dt-bindings: mtd: gpmi-nand: Fix matching of clocks on different SoCs Sascha Hauer
2020-08-25 6:49 ` Krzysztof Kozlowski
2020-08-24 19:06 ` [PATCH 03/16] arm64: dts: imx8mm-beacon-som.dtsi: Align regulator names with schema Krzysztof Kozlowski
2020-08-25 6:51 ` Vaittinen, Matti
2020-08-25 7:25 ` krzk
2020-08-25 7:45 ` krzk
2020-08-25 7:50 ` krzk
2020-08-25 8:22 ` Vaittinen, Matti
2020-08-25 8:27 ` krzk
2020-08-25 9:35 ` Vaittinen, Matti
2020-08-25 8:29 ` Krzysztof Kozlowski
2020-08-24 19:06 ` [PATCH 04/16] arm64: dts: imx8mm-beacon-baseboard: Correct SPI CS polarity Krzysztof Kozlowski
2020-08-24 20:07 ` Fabio Estevam
2020-08-24 19:06 ` [PATCH 05/16] arm64: dts: imx8mm-beacon: Align pin configuration group names with schema Krzysztof Kozlowski
2020-08-24 19:06 ` [PATCH 06/16] arm64: dts: imx8mm-evk: Add 32.768 kHz clock to PMIC Krzysztof Kozlowski
2020-08-24 19:06 ` [PATCH 07/16] arm64: dts: imx8mm-evk: Align pin configuration group names with schema Krzysztof Kozlowski
2020-08-24 19:06 ` [PATCH 08/16] arm64: dts: imx8mm-ddr4-evk: " Krzysztof Kozlowski
2020-08-24 19:06 ` [PATCH 09/16] arm64: dts: imx8mn-evk: " Krzysztof Kozlowski
2020-08-24 19:06 ` [PATCH 10/16] arm64: dts: imx8mq-evk: " Krzysztof Kozlowski
2020-08-24 19:06 ` [PATCH 11/16] arm64: dts: imx8mq-librem5-devkit: " Krzysztof Kozlowski
2020-08-24 19:06 ` [PATCH 12/16] arm64: dts: imx8mq-phanbell: " Krzysztof Kozlowski
2020-08-24 19:06 ` [PATCH 13/16] arm64: dts: imx8mq-pico-pi: " Krzysztof Kozlowski
2020-08-24 19:06 ` [PATCH 14/16] arm64: dts: imx8mq-sr-som: " Krzysztof Kozlowski
2020-08-24 19:07 ` [PATCH 15/16] arm64: dts: imx8mq-hummingboard-pulse: " Krzysztof Kozlowski
2020-08-24 19:07 ` [PATCH 16/16] arm64: dts: imx8qxp-colibri: " Krzysztof Kozlowski
2020-08-25 6:23 ` [PATCH 01/16] dt-bindings: mfd: rohm, bd71847-pmic: Correct clock properties requirements Vaittinen, Matti
2020-08-25 6:55 ` krzk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824190701.8447-2-krzk@kernel.org \
--to=krzk@kernel.org \
--cc=Anson.Huang@nxp.com \
--cc=aford173@gmail.com \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=han.xu@nxp.com \
--cc=jun.li@nxp.com \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=vigneshr@ti.com \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).