From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C222C433E1 for ; Mon, 24 Aug 2020 23:32:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1A13F2074D for ; Mon, 24 Aug 2020 23:32:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BDNrpXCk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A13F2074D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=H6nGBysoWIgtEL6UpyE/OIPFtsSlQ8QMkzy4qarUaAI=; b=BDNrpXCk9Bzb7W/hkNhFt7I0S 66ZjuJQueb5lHbpHzf/rZI6QT9Q78mdQ6Uxt44vKev8CLhGKMF6+DpPe/F7082dzf7sp6QQKbYwAY z34qNKWuFJHRViFdAqoYVXZivxw0a5UxO98A5G9FQQp4aDxSW+t8v4TW52Nkn1JNAF10wlaAY4/dF fWvBxCtk4BGnoMW8AYbBIp6fw1NBRVMIqH0SWzH44zRu8UaHUNqA+1bVR3M5dDM1FzHBaDRjJZPfK sR3Agu6ugjuQrcnsWxQ8rkC7PQrgimTrsAB0oBbqUtVqh/dXDbufXJfEOItIUTkr+CaDn0TdV0JLp 0TWBx9DrQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kALvL-0005XJ-RI; Mon, 24 Aug 2020 23:30:47 +0000 Received: from mail-io1-f65.google.com ([209.85.166.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kALvI-0005Wa-SH for linux-arm-kernel@lists.infradead.org; Mon, 24 Aug 2020 23:30:46 +0000 Received: by mail-io1-f65.google.com with SMTP id h4so10592425ioe.5 for ; Mon, 24 Aug 2020 16:30:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ul5vsSQ0AC/DUuwVVIoms1HCf2oN0/YEUiAq/yjQxDE=; b=YuekdGdaVv7ywjt77sKUcwIFFYfYb1p65DRiL12W3F7wlftJLnZCeDIqvhJ2YbuqYz Uuh7z3dTf5RSHY2rzaIPbADoQNgLzEdIIgeR05Uv45E7Dz0LAafVKqjZuCgB5Dvri58O XaflFlAfGiPqSpAMea/r07YwFxnaxfg6NYCqfnJphXrjMfJkTXEX0ta3Glj0zFMJx+qy HLABQFl72kttsu/nhwiRVzcq6ItC2JWO9z1U8JKOJRJzVTU1SFC/IprVzK7hehAB+yEp yjoWPdzMtpn3+8+OPflzMR6NmYJKMJf7jeIOutmvWTuhT/ZrWJ/ouQ2Srr8sip7J2eca hoGw== X-Gm-Message-State: AOAM533qQjvxSItlQCVeS1byE297bYV1yGic7ujv06EpqtupAZqUbIqL tmafoAPYHytvq83CUpLch0PJ8dAYuQ== X-Google-Smtp-Source: ABdhPJz+NQ1qdajPag/8+NvwhC0VZ3vzxnBW9ciupDP5U8wTD1qPKcV07ZiSre5zNxPrU8kgre3VRQ== X-Received: by 2002:a6b:e009:: with SMTP id z9mr6755255iog.124.1598311843191; Mon, 24 Aug 2020 16:30:43 -0700 (PDT) Received: from xps15 ([64.188.179.249]) by smtp.gmail.com with ESMTPSA id e6sm7517181iod.53.2020.08.24.16.30.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2020 16:30:42 -0700 (PDT) Received: (nullmailer pid 3540232 invoked by uid 1000); Mon, 24 Aug 2020 23:30:40 -0000 Date: Mon, 24 Aug 2020 17:30:40 -0600 From: Rob Herring To: Al Cooper Subject: Re: [PATCH 1/3] dt-bindings: Add support for Broadcom USB pin map driver Message-ID: <20200824233040.GA3532378@bogus> References: <20200812202018.49046-1-alcooperx@gmail.com> <20200812202018.49046-2-alcooperx@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200812202018.49046-2-alcooperx@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200824_193045_048513_366E9B57 X-CRM114-Status: GOOD ( 22.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Florian Fainelli , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 12, 2020 at 04:20:16PM -0400, Al Cooper wrote: > Add DT bindings for the Broadcom USB pin map driver. This driver allows > some USB input and output signals to be mapped to any GPIO instead > of the normal dedicated pins to/from the XHCI controller. Is this a driver or h/w block because bindings are for h/w blocks? > > Signed-off-by: Al Cooper > --- > .../bindings/usb/brcm,usb-pinmap.yaml | 63 +++++++++++++++++++ > 1 file changed, 63 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/brcm,usb-pinmap.yaml > > diff --git a/Documentation/devicetree/bindings/usb/brcm,usb-pinmap.yaml b/Documentation/devicetree/bindings/usb/brcm,usb-pinmap.yaml > new file mode 100644 > index 000000000000..19cf6ad36373 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/brcm,usb-pinmap.yaml > @@ -0,0 +1,63 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/usb/brcm,usb-pinmap.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Broadcom USB pin map Controller Device Tree Bindings > + > +maintainers: > + - Al Cooper > + > +properties: > + compatible: > + items: > + - const: brcm,usb-pinmap 2 space indentation please. > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + description: Must be defined if any out-gpios are specified. 'dependencies' can express this in schema. > + > + in-gpios: > + description: Array of one or more GPIO pins used for input signals. You need to define how many GPIOs are valid. > + > + in-names: > + description: Array of input signal names, one per gpio in in-gpios. No, this isn't how we name GPIOs. The part before '-gpios' is how. > + > + in-masks: > + description: Array of enable and mask pairs, one per gpio in-gpios. Needs a vendor prefix. > + > + out-gpios: > + description: Array of one or more GPIO pins used for output signals. > + > + out-names: > + description: Array of output signal names, one per gpio in out-gpios. > + > + out-masks: > + description: Array of enable, value, changed and clear masks, one > + per gpio in out-gpios. > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + usb_pinmap: usb-pinmap@22000d0 { > + compatible = "brcm,usb-pinmap"; > + reg = <0x22000d0 0x4>; > + in-gpios = <&gpio 18 0>, <&gpio 19 0>; > + in-names = "VBUS", "PWRFLT"; > + in-masks = <0x8000 0x40000 0x10000 0x80000>; > + out-gpios = <&gpio 20 0>; > + out-names = "PWRON"; > + out-masks = <0x20000 0x800000 0x400000 0x200000>; > + interrupts = <0x0 0xb2 0x4>; > + }; > + > +... > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel