From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05603C433E5 for ; Tue, 25 Aug 2020 00:31:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C5FE42065F for ; Tue, 25 Aug 2020 00:31:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FbMtTuG/"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A602o3fT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C5FE42065F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7/E8ruy5KRvKn6c96lhW9CuqPRIbU9G9B4PUasy2HcU=; b=FbMtTuG/6TvstKqWguerAc0Z1 4fEpg903n2c7JDt+qVEjAIbVucSlOGRMaJmFZYxGSWjMdZ4pc/xH4X5eUBqkx72AXVrHpa/UXApAC iD3HyGsElL8pp61HNBarTJ2J/Q35LH9x2k+8bZkp2gzpts8ev49lsiax/VqlWl5Ly+CuuUpYzqJZp 1xu2DeWEWlTLELMjPAxYlY1xIMNvtFmohjWvOGFhbtpt+TRPTeIDn5Y8r6G5ZYXUKDdmLnkQrIh6R BzytO33F4fPVxc2vDShe3EhDHKL2xIetcErDnJMakdU4bz6/5j24dr7djOkWOaKxXx5NhMA1a//vk NWg2H5kEw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAMqN-0004Jb-Qn; Tue, 25 Aug 2020 00:29:43 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAMqG-0004A0-6P for linux-arm-kernel@lists.infradead.org; Tue, 25 Aug 2020 00:29:39 +0000 Received: by mail-pf1-x444.google.com with SMTP id f193so5916617pfa.12 for ; Mon, 24 Aug 2020 17:29:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=4OK9wqCxSJjyrNizd8dpdRQRhpsdvkAgYgmSJK2pX/I=; b=A602o3fTTqtvQvBCYa15f6U8wdaVYPJIG3RChgggzl+hM4aI4Z0TdRD4MCqdI7Djag t66KpcjIibHp/FlIy1hAIepMx36TXjv3gaFiOtJrSrwgcq+6rUG4VTQyfMvqXhu2Xzko lOJDP2Cq3nP5flJF6AtwmPY3TWQ8JgXFNKnuk5MDOMdcvZxMlfWF8uMMmLdW0YppvKEa d1GMeVJtsBEoia2tXnpi4WN+zVdX0CyY7vBwVIXgHe33W2hCdHnY7uc8PcO/J2aHDwz1 hzOWTAuHo60B+v+y2vx7kRuYVHl0ZROSQDsFBitDVzg3NTgdfSKPxBU6W3j/rslEw6FL MbGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=4OK9wqCxSJjyrNizd8dpdRQRhpsdvkAgYgmSJK2pX/I=; b=ft59UdsPay4Gi2yI/H3lSDT8sM8ylK2FyorUeTAXBRsTwnvrYbkZd1dVkBWhYoqnZC sOBBQqiDCr/BnaIFKlHvB7Eo+3MwNpO8t7oEBmKdP+E40GCeHJqS+xLz4w71+n2WTc0w DHkzMtyhlPZwqXYhUaWq8wZSXrACQXUFjaiPrJb9XKQw7nfwZrtSwvxuOxiCNnbgOJ7c lI/wBPp4othPgmTnDNSrBiUUYv7zv6u+ONSkkJ6ozvF3JEIewIdecxiufHOnQa65OnAW xPjZK+NJynkHfvRJfolii0qjmxaK6OLwgbYVsP/80XKQcBaMAU+2I0a1O/yHWuIiPw0n TSTQ== X-Gm-Message-State: AOAM533wl/ZneD/Lryts5g7yTUgXIuS53+NoI+JiLhLRDFAMG39z/0sc yvF5R195EW33VGsjjYM6Lc8= X-Google-Smtp-Source: ABdhPJx3IEBPWOcxnTmynKfeLklP2uogPTigHsxpdHRSUJIdmdFCc41avCpDY7fWRSum09IztIZB1A== X-Received: by 2002:a17:902:be12:: with SMTP id r18mr5407607pls.116.1598315368862; Mon, 24 Aug 2020 17:29:28 -0700 (PDT) Received: from BG-LT6221.marvell.com ([122.172.254.64]) by smtp.gmail.com with ESMTPSA id g17sm12021885pge.9.2020.08.24.17.29.25 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Aug 2020 17:29:28 -0700 (PDT) Date: Tue, 25 Aug 2020 05:59:18 +0530 From: Linu Cherian To: Mathieu Poirier Subject: Re: [PATCH V3] coresight: Make sysFS functional on topologies with per core sink Message-ID: <20200825002917.GA60@BG-LT6221.marvell.com> References: <20200811022842.20129-1-lcherian@marvell.com> <20200820170259.GA3933623@xps15> <20200822131828.GA77@BG-LT6221.marvell.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200824_202936_412324_2DC2B2FE X-CRM114-Status: GOOD ( 20.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Coresight ML , Mike Leach , linux-arm-kernel , Linu Cherian , "Suzuki K. Poulose" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mathieu, On Mon Aug 24, 2020 at 08:46:33AM -0600, Mathieu Poirier wrote: > On Sat, 22 Aug 2020 at 07:18, Linu Cherian wrote: > > > > Hi Mathieu, > > > > > > diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c > > > > index 1a3169e69bb1..25041d2654e3 100644 > > > > --- a/drivers/hwtracing/coresight/coresight-etm-perf.c > > > > +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c > > > > @@ -223,7 +223,7 @@ static void *etm_setup_aux(struct perf_event *event, void **pages, > > > > id = (u32)event->attr.config2; > > > > sink = coresight_get_sink_by_id(id); > > > > } else { > > > > - sink = coresight_get_enabled_sink(true); > > > > + sink = coresight_get_enabled_sink(NULL, true); > > > > > > It is time for this subsystem to move out of the prehistoric age. Please remove > > > the call to coresight_get_enabled_sink() entirely. In the change log you can > > > write that selecting a sink from sysfs is deprecated when using the perf > > > interface. I will personally refactor the code if someone complains that it > > > broke their user space. > > > > I forgot to mention... Please do two patches, one that removes > coresight_get_enabled_sink() from etm_setup_aux() and another one for > the reset of your changes. Yeah. Sure. -- Linu cherian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel