From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5985CC433E1 for ; Tue, 25 Aug 2020 07:27:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1A10A20706 for ; Tue, 25 Aug 2020 07:27:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="0DYajN8n" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A10A20706 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gE43py02xeg9V4zbQWQbtoF35Ct1+Qlu4gXQCOs74pU=; b=0DYajN8ncQC/P4LcJSbNdUc4B z9xRDsl6+TysTsZMRxaE5yiBAOYebh879NC+82BtGrsbYLke0fOW0AzfG3QnlS/QuO0azqms0Rhrm r6Kaxwp5SL9H0rs4Ic1684Am/Z/rBTjV/kFGsRjBxNdeI8r7Ecd193AL7MfKPQg3RS5XBs83LCNXC H/XlnY1Wq7iRVI39NmO47SbGObCEklDmWl2Oip1KT5BPyGH7YMGkCzsspVHVWGkc2Be1leF2xD3bp fMKRYocs6QA+DsD/OF/UGqdVfQpgkYA34gQbkTaydIUqDNYdlXEHwj20DKAouk50H8DO/d8Wvhl/E 5P2E4+nOA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kATL1-00064E-HW; Tue, 25 Aug 2020 07:25:47 +0000 Received: from mail-wr1-f67.google.com ([209.85.221.67]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kATKw-00061u-RW; Tue, 25 Aug 2020 07:25:43 +0000 Received: by mail-wr1-f67.google.com with SMTP id b17so10833916wru.2; Tue, 25 Aug 2020 00:25:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2UDn8nshmtelV8H6R+gegKh3+mv7xE3Ee9qPVJXzBko=; b=gsYkhC7shiPjzUoppIQ3Cw5k9lwx9V8FO/3j4zXtO5bwaEoPcmkAYpoKK66eystARd 7zRMCf7xSIkkontDqWfC0jivbMDZIGDviDrHoVh4rgC31rTjxC6+/hUFMreeGclMowFF fvWmJd9+gVthTamMCw/WA06cmWFzZERq+LLa5hdEvqfR2ugEuUjSk0eMEJYlvO+dn5p/ gvdUJFsckBF0ws5figKZDKdnDDHWZSvHbWldrB6QUklHDBzVJhFEQkf+wa3SIo5Jy0u1 jVWzuDEDm3t0rutJDAcNGVmoG5XpUgzZrZIctVxvCF/yGCrxJtcOZN7iTdUxTSEdHwGR Qacg== X-Gm-Message-State: AOAM53049Ur0ofa0aDaMCU8sOvu2eCDHQkooNfRyTaQOubhKmNaX6Fo1 K+6ic/QuFToZvxEzTDxKbPA= X-Google-Smtp-Source: ABdhPJzAtbLQMnecXqAvMsqz572yNqZJ5Dk8OpUuLTfB3ohjDCMwvv1x50yQZ9ondRCQBmNzjHwp/A== X-Received: by 2002:adf:9224:: with SMTP id 33mr9207502wrj.24.1598340341132; Tue, 25 Aug 2020 00:25:41 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id f10sm3717581wmj.37.2020.08.25.00.25.39 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 25 Aug 2020 00:25:40 -0700 (PDT) Date: Tue, 25 Aug 2020 09:25:37 +0200 From: "krzk@kernel.org" To: "Vaittinen, Matti" , "robh+dt@kernel.org" Subject: Re: [PATCH 03/16] arm64: dts: imx8mm-beacon-som.dtsi: Align regulator names with schema Message-ID: <20200825072537.GA5914@kozik-lap> References: <20200824190701.8447-1-krzk@kernel.org> <20200824190701.8447-3-krzk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200825_032542_904370_2B32425D X-CRM114-Status: GOOD ( 27.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "daniel.baluta@nxp.com" , "devicetree@vger.kernel.org" , "festevam@gmail.com" , "vigneshr@ti.com" , "Anson.Huang@nxp.com" , "aford173@gmail.com" , "s.hauer@pengutronix.de" , "linux-kernel@vger.kernel.org" , "richard@nod.at" , "linux-mtd@lists.infradead.org" , "linux-imx@nxp.com" , "kernel@pengutronix.de" , "miquel.raynal@bootlin.com" , "han.xu@nxp.com" , "lee.jones@linaro.org" , "yibin.gong@nxp.com" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "jun.li@nxp.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 25, 2020 at 06:51:33AM +0000, Vaittinen, Matti wrote: > Hello Krzysztof, > > Just some questions - please ignore if I misunderstood the impact of > the change. > > On Mon, 2020-08-24 at 21:06 +0200, Krzysztof Kozlowski wrote: > > Device tree schema expects regulator names to be lowercase. This > > fixes > > dtbs_check warnings like: > > > > arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dt.yaml: pmic@4b: > > regulators:LDO1:regulator-name:0: 'LDO1' does not match '^ldo[1-6]$' > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > .../boot/dts/freescale/imx8mn-ddr4-evk.dts | 22 +++++++++------ > > ---- > > 1 file changed, 11 insertions(+), 11 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts > > b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts > > index a1e5483dbbbe..299caed5d46e 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts > > +++ b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts > > @@ -60,7 +60,7 @@ > > > > regulators { > > buck1_reg: BUCK1 { > > - regulator-name = "BUCK1"; > > + regulator-name = "buck1"; > > I am not against this change but I would expect seeing some other > patches too? I guess this will change the regulator name in regulator > core, right? So maybe I am mistaken but it looks to me this change is > visible in suppliers, sysfs and debugfs too? Thus changing this sounds > a bit like asking for a nose bleed :) Am I right that the impact of > this change has been thoroughly tested? Are there any other patches > (that I have not seen) related to this change? Oh, crap, the names of regulators in the driver are lowercase, but they use of_match_ptr for upper case. Seriously, why making a binding which is contradictory to the driver implementation on the first day? The driver goes with binding, right? One expects uppercase, other lowercase... And tell me, what is now the ABI? The binding or the incorrect implementation? > > > regulator-min-microvolt = <700000>; > > regulator-max-microvolt = <1300000>; > > regulator-boot-on; > > @@ -69,7 +69,7 @@ > > }; > > > > buck2_reg: BUCK2 { > > - regulator-name = "BUCK2"; > > + regulator-name = "buck2"; > > regulator-min-microvolt = <700000>; > > regulator-max-microvolt = <1300000>; > > regulator-boot-on; > > @@ -79,14 +79,14 @@ > > > > buck3_reg: BUCK3 { > > // BUCK5 in datasheet > > - regulator-name = "BUCK3"; > > + regulator-name = "buck3"; > > regulator-min-microvolt = <700000>; > > regulator-max-microvolt = <1350000>; > > }; > > > > buck4_reg: BUCK4 { > > // BUCK6 in datasheet > > - regulator-name = "BUCK4"; > > + regulator-name = "buck4"; > > regulator-min-microvolt = <3000000>; > > regulator-max-microvolt = <3300000>; > > regulator-boot-on; > > @@ -95,7 +95,7 @@ > > > > buck5_reg: BUCK5 { > > // BUCK7 in datasheet > > - regulator-name = "BUCK5"; > > + regulator-name = "buck5"; > > What I see in bd718x7-regulator.c for LDO6 desc is: > > /* LDO6 is supplied by buck5 */ > .supply_name = "buck5", > > So, is this change going to change the supply-chain for the board? Is > this intended? (Or am I mistaken on what is the impact of regulator- > name property?) The names will take regulator names from the driver. The problem is with matching the of_node. Dear Rob, Maybe you have an idea how to fix this driver-binding ABI incompatibility? Or better just leave it? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel