From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83C06C433E1 for ; Tue, 25 Aug 2020 07:52:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 50B3B206EB for ; Tue, 25 Aug 2020 07:52:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="C1bGH5jZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 50B3B206EB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YpMgx/lorP4DldNEUsQ1vyjXIVJZtUo7MpI5nZP5S+U=; b=C1bGH5jZMl9kZS7x2G3bAfWKk SWupD47UCN/UDZqNOEvidq2/zUrE4yNgma31ze27DolSb9Sg2i6FPMw37uA988umrZjdhhKwS+ZVF OdJKqGjM7UGzOen9M0FK+aIojciSn3ziL63eI245sy+b2+3SQx6lPMyzg3M2fw/xfyHV94cKg2+Jg BMWRXbQJHuOsS5XbBQSDdnCUTzpOtDKCakRAv2VfEXBTJmcL/0L72PQAup12jcE+ZyudiJBgQpP48 HowpGqUMSY7KLxMJRQCieM85yPWeH9zYX0TkiDiDjD13BMmJm2qqEMLoCwmB6iU/wgMzgW1YhQbry 3nA7Lj7tQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kATjE-0008FI-DW; Tue, 25 Aug 2020 07:50:48 +0000 Received: from mail-wr1-f66.google.com ([209.85.221.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kATj8-0008Du-Qo; Tue, 25 Aug 2020 07:50:43 +0000 Received: by mail-wr1-f66.google.com with SMTP id p17so6017379wrj.8; Tue, 25 Aug 2020 00:50:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zDClTj1s5N+7to7OhV01SAjKraKRfpn6FyxoNR9IkEU=; b=H6SD42Lke4LRl63G9d0wHYAwtt70aIdH+em1iIwKM4mvNYj35jdBqhvYiv+BgKuUar U1BHfmdUsJ8ISeeuVpxmddxlHLV5bInhbE9nWmcAsd4cSHbG9xxhnLbB6egd1jc/P70e QjHYZYT0NelVrH0mnhPNF2JCTj3MSygChGjkh5P5VZioOlMM3VwfDhaXGEECWDlQBc17 Ip5PoIlyxCYNCFOH0JfxIQvlOcs/dPUsvm9gO672OoZtikyz6S11Tl63+mRJ0woztTCw 6JKZ14pH7GZYk61bds1oDtq0cmUbprm0mqgEEyQebtOslkJXxtuDAzlHdl2BY1QtpjOM gIRg== X-Gm-Message-State: AOAM530gL652UH8v5bbZVroRNjHftpFM6GK/A2BBJx9a6BHknFCkM2gt f964nSgHfdF4fgO1BllX8QwMZn/8W0ADVw== X-Google-Smtp-Source: ABdhPJz4Djn1xXgFIG+eLnd2hHpypc7Vf0VfaQwoafVN0wzGR0eJoRGVKcMj9sJTv9d70FoXI70fpA== X-Received: by 2002:a5d:5589:: with SMTP id i9mr9269809wrv.127.1598341841452; Tue, 25 Aug 2020 00:50:41 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id v9sm17639149wru.37.2020.08.25.00.50.39 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 25 Aug 2020 00:50:40 -0700 (PDT) Date: Tue, 25 Aug 2020 09:50:38 +0200 From: "krzk@kernel.org" To: "Vaittinen, Matti" , "robh+dt@kernel.org" Subject: Re: [PATCH 03/16] arm64: dts: imx8mm-beacon-som.dtsi: Align regulator names with schema Message-ID: <20200825075038.GA10148@kozik-lap> References: <20200824190701.8447-1-krzk@kernel.org> <20200824190701.8447-3-krzk@kernel.org> <20200825072537.GA5914@kozik-lap> <20200825074500.GA19323@kozik-lap> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200825074500.GA19323@kozik-lap> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200825_035042_898148_30A13ECB X-CRM114-Status: GOOD ( 34.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "daniel.baluta@nxp.com" , "devicetree@vger.kernel.org" , "festevam@gmail.com" , "vigneshr@ti.com" , "Anson.Huang@nxp.com" , "aford173@gmail.com" , "s.hauer@pengutronix.de" , "linux-kernel@vger.kernel.org" , "richard@nod.at" , "linux-mtd@lists.infradead.org" , "linux-imx@nxp.com" , "kernel@pengutronix.de" , "miquel.raynal@bootlin.com" , "han.xu@nxp.com" , "lee.jones@linaro.org" , "yibin.gong@nxp.com" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "jun.li@nxp.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 25, 2020 at 09:45:00AM +0200, krzk@kernel.org wrote: > On Tue, Aug 25, 2020 at 09:25:37AM +0200, krzk@kernel.org wrote: > > On Tue, Aug 25, 2020 at 06:51:33AM +0000, Vaittinen, Matti wrote: > > > Hello Krzysztof, > > > > > > Just some questions - please ignore if I misunderstood the impact of > > > the change. > > > > > > On Mon, 2020-08-24 at 21:06 +0200, Krzysztof Kozlowski wrote: > > > > Device tree schema expects regulator names to be lowercase. This > > > > fixes > > > > dtbs_check warnings like: > > > > > > > > arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dt.yaml: pmic@4b: > > > > regulators:LDO1:regulator-name:0: 'LDO1' does not match '^ldo[1-6]$' > > > > > > > > Signed-off-by: Krzysztof Kozlowski > > > > --- > > > > .../boot/dts/freescale/imx8mn-ddr4-evk.dts | 22 +++++++++------ > > > > ---- > > > > 1 file changed, 11 insertions(+), 11 deletions(-) > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts > > > > b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts > > > > index a1e5483dbbbe..299caed5d46e 100644 > > > > --- a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts > > > > @@ -60,7 +60,7 @@ > > > > > > > > regulators { > > > > buck1_reg: BUCK1 { > > > > - regulator-name = "BUCK1"; > > > > + regulator-name = "buck1"; > > > > > > I am not against this change but I would expect seeing some other > > > patches too? I guess this will change the regulator name in regulator > > > core, right? So maybe I am mistaken but it looks to me this change is > > > visible in suppliers, sysfs and debugfs too? Thus changing this sounds > > > a bit like asking for a nose bleed :) Am I right that the impact of > > > this change has been thoroughly tested? Are there any other patches > > > (that I have not seen) related to this change? > > > > Oh, crap, the names of regulators in the driver are lowercase, but they > > use of_match_ptr for upper case. Seriously, why making a binding which > > is contradictory to the driver implementation on the first day? > > > > The driver goes with binding, right? One expects uppercase, other > > lowercase... > > > > And tell me, what is now the ABI? The binding or the incorrect > > implementation? > > Wait, my mistake. I got confused by my own change. The node name stays > the same, so of_match will be correct. > > The driver internally already uses lowercase names. > > Everything looks good. I will just double check whether the constraints > did not change on the board after boot. Constraints look good. > > > > > > > > > > regulator-min-microvolt = <700000>; > > > > regulator-max-microvolt = <1300000>; > > > > regulator-boot-on; > > > > @@ -69,7 +69,7 @@ > > > > }; > > > > > > > > buck2_reg: BUCK2 { > > > > - regulator-name = "BUCK2"; > > > > + regulator-name = "buck2"; > > > > regulator-min-microvolt = <700000>; > > > > regulator-max-microvolt = <1300000>; > > > > regulator-boot-on; > > > > @@ -79,14 +79,14 @@ > > > > > > > > buck3_reg: BUCK3 { > > > > // BUCK5 in datasheet > > > > - regulator-name = "BUCK3"; > > > > + regulator-name = "buck3"; > > > > regulator-min-microvolt = <700000>; > > > > regulator-max-microvolt = <1350000>; > > > > }; > > > > > > > > buck4_reg: BUCK4 { > > > > // BUCK6 in datasheet > > > > - regulator-name = "BUCK4"; > > > > + regulator-name = "buck4"; > > > > regulator-min-microvolt = <3000000>; > > > > regulator-max-microvolt = <3300000>; > > > > regulator-boot-on; > > > > @@ -95,7 +95,7 @@ > > > > > > > > buck5_reg: BUCK5 { > > > > // BUCK7 in datasheet > > > > - regulator-name = "BUCK5"; > > > > + regulator-name = "buck5"; > > > > > > What I see in bd718x7-regulator.c for LDO6 desc is: > > > > > > /* LDO6 is supplied by buck5 */ > > > .supply_name = "buck5", > > > > > > So, is this change going to change the supply-chain for the board? Is > > > this intended? (Or am I mistaken on what is the impact of regulator- > > > name property?) > > Good point, let me check the supplies. This patch actually fixes the supplies which before were not working because of case mismatch. Before: regulator use open bypass opmode voltage current min max --------------------------------------------------------------------------------------- regulator-dummy 4 5 0 unknown 0mV 0mA 0mV 0mV LDO6 1 0 0 unknown 1200mV 0mA 900mV 1800mV BUCK1 1 0 0 unknown 850mV 0mA 700mV 1300mV BUCK2 2 1 0 unknown 1000mV 0mA 700mV 1300mV cpu0-cpu 1 0mA 1000mV 1000mV BUCK3 1 0 0 unknown 975mV 0mA 700mV 1350mV BUCK4 1 0 0 unknown 3300mV 0mA 3000mV 3300mV BUCK5 1 0 0 unknown 1800mV 0mA 1605mV 1995mV BUCK6 1 0 0 unknown 1200mV 0mA 800mV 1400mV LDO1 1 0 0 unknown 1800mV 0mA 1600mV 1900mV LDO2 1 0 0 unknown 800mV 0mA 800mV 900mV LDO3 1 0 0 unknown 1800mV 0mA 1800mV 3300mV LDO4 1 0 0 unknown 900mV 0mA 900mV 1800mV ldo5 1 4 0 unknown 1800mV 0mA 1800mV 1800mV After: regulator use open bypass opmode voltage current min max --------------------------------------------------------------------------------------- buck1 1 0 0 unknown 850mV 0mA 700mV 1300mV buck2 2 1 0 unknown 850mV 0mA 700mV 1300mV cpu0-cpu 1 0mA 850mV 850mV buck3 1 0 0 unknown 975mV 0mA 700mV 1350mV buck4 1 0 0 unknown 3300mV 0mA 3000mV 3300mV buck5 2 1 0 unknown 1800mV 0mA 1605mV 1995mV ldo6 1 0 0 unknown 1200mV 0mA 900mV 1800mV buck6 1 0 0 unknown 1200mV 0mA 800mV 1400mV ldo1 1 0 0 unknown 1800mV 0mA 1600mV 1900mV ldo2 1 0 0 unknown 800mV 0mA 800mV 900mV ldo3 1 0 0 unknown 1800mV 0mA 1800mV 3300mV ldo4 1 0 0 unknown 900mV 0mA 900mV 1800mV ldo5 0 0 0 unknown 3300mV 0mA 0mV 0mV Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel