From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67F68C433DF for ; Tue, 25 Aug 2020 11:09:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 279CE2071E for ; Tue, 25 Aug 2020 11:09:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XQrHxg9D" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 279CE2071E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mbNf9Pd/bXf4IWkCUeShayKuz+iDkO+9ZnwX30hTE/g=; b=XQrHxg9DqCcCUE0//xYWrEHht 1et+G3RpsEYeOqcmxsmvslqvuGdRaWyAmEBgk5HcyVTE/ghoLYorLsqg3695+2fLyIGrAxSOTgnpt QjxePFVq4s/laV6S+FfLZMVoKMsZFwxjB8rE52vbrbcEXH7eXLw5cbV9DhWAcCbJVq6n2s5WjnbkW Y88CBQKSYZsVXshruP7wVpPOyQfwGh7wI6go/IkPy+d2Yx+H19AEdj7UuCvRaljA0MhW7TFQ+j6ZG P38Bc71bnh21cBdBbw/XvNiD90STTPM5iS8i7Av5VdhScFGqyJzxIwJbjxKMhrMoWUvkcW8w2q0QJ YzFuQngYA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAWo6-0000xX-JX; Tue, 25 Aug 2020 11:08:02 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAWo4-0000wh-0L for linux-arm-kernel@lists.infradead.org; Tue, 25 Aug 2020 11:08:00 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C544E30E; Tue, 25 Aug 2020 04:07:57 -0700 (PDT) Received: from localhost (unknown [10.1.199.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6672D3F66B; Tue, 25 Aug 2020 04:07:57 -0700 (PDT) Date: Tue, 25 Aug 2020 12:07:56 +0100 From: Ionela Voinescu To: Viresh Kumar Subject: Re: [PATCH v3 3/5] cpufreq: report whether cpufreq supports Frequency Invariance (FI) Message-ID: <20200825110747.GA12506@arm.com> References: <20200824210252.27486-1-ionela.voinescu@arm.com> <20200824210252.27486-4-ionela.voinescu@arm.com> <20200825062709.dlzztu547idco7zw@vireshk-i7> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200825062709.dlzztu547idco7zw@vireshk-i7> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200825_070800_132160_1D1A9E03 X-CRM114-Status: GOOD ( 13.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, catalin.marinas@arm.com, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com, sudeep.holla@arm.com, will@kernel.org, valentin.schneider@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Viresh, On Tuesday 25 Aug 2020 at 11:57:09 (+0530), Viresh Kumar wrote: [..] > > +static inline > > +void enable_cpufreq_freq_invariance(struct cpufreq_driver *driver) > > +{ > > + if (!driver->setpolicy) { > > + static_branch_enable_cpuslocked(&cpufreq_freq_invariance); > > + pr_debug("supports frequency invariance"); > > + } > > +} > > + > > I would rather open-code this int the cpufreq_register_driver() routine as > that's what is done in cpufreq_unregister_driver() as well. > > > +bool cpufreq_supports_freq_invariance(void) > > +{ > > + return static_branch_likely(&cpufreq_freq_invariance); > > +} > > + > > And would keep the definition of the static key with this routine at a single > place. Makes sense and will do! Thank you for the quick review, Ionela. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel