From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B274CC433DF for ; Tue, 25 Aug 2020 22:10:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D05F20706 for ; Tue, 25 Aug 2020 22:10:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bgmLPQyH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D05F20706 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nPxKW0QBZ5hqQSiH2trpq3gTubWfPS5wp1Ov0EaCvAQ=; b=bgmLPQyH8DHncAkXRGVLDGbrU 5tW2WGkW1EiCMggoUiMDoZUk0nw8Db2SWyePxf3pK7Gxh+Gep3utUFPrSC9nofl6xJIOTA3lJ+Z4i 2vEwkP2wIP+yztSTIIeXtuHURXTDNUiEMUbZ9LA8OwnMRH/wCc7tsPPL7RgCHI+uBe074zscYGhqC h6vkhFAk0kzP+PRdgNGAIHUOnL064vk3N6+IN5D4ZdzB54yjmR93907T3PQMTdE+2xrBkQWPLKqFq vO2+td5VDKCWjVGBHXr1LGm6Qa2Vg9I8HiecibLl3SOh10TbniJptbtoyUKjozL/fPXYB1Nifq376 PO+/fTugw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAh83-0001V9-BH; Tue, 25 Aug 2020 22:09:19 +0000 Received: from mail-il1-f193.google.com ([209.85.166.193]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAh80-0001Ub-Kd; Tue, 25 Aug 2020 22:09:17 +0000 Received: by mail-il1-f193.google.com with SMTP id e11so87245ils.10; Tue, 25 Aug 2020 15:09:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BLKrtDPioAUBLdZ6oe5KeScwSDtIqCbNdo8WBPjs1eA=; b=Y8sVSQl1oya5F/nxJvw6rE7QRz/oFyXx3j97pZ7/177oAKvvXpImDu/9iM1GzLlX1e HEdmOFiUg6NlkFhzVRih3R96MimOe82fnpQiudDICxcCoGKJbp+LCyW9DXtd5XHLcDtn ghbm9gFs9K4HxlvPUU9T1+TyNgeQecpjZsyvweH/EBFnpfHMkr09TsF0udW+/yKtLPcn luINq3BGcOZF3Sz6JIEILtDR+Tp6apvphmlajAW/wN9T2aSbxDlC983fWgb5BhsMHYdn YitYk59fvGWc3vJtF2x72N6ipZs22BVtdGK3ko3/XlpXgiLmUAp838WhWglkzJd/uYcR XskA== X-Gm-Message-State: AOAM5303yuKFg+vWBmSPGyRClZ6YK3UVlzLbY/H3NpSP6Kh1RzPNTClD OyIDs5uvQMHSde9cD8ZTfg== X-Google-Smtp-Source: ABdhPJwfitAczHxFgEpj40L+UcJQ4elxja7tGAVv1BecnVUuns4Xh8xcC4bbofLEa/jynI/Aush6KQ== X-Received: by 2002:a92:d646:: with SMTP id x6mr11132185ilp.237.1598393355818; Tue, 25 Aug 2020 15:09:15 -0700 (PDT) Received: from xps15 ([64.188.179.249]) by smtp.gmail.com with ESMTPSA id u89sm199111ili.87.2020.08.25.15.09.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Aug 2020 15:09:14 -0700 (PDT) Received: (nullmailer pid 1429315 invoked by uid 1000); Tue, 25 Aug 2020 22:09:13 -0000 Date: Tue, 25 Aug 2020 16:09:13 -0600 From: Rob Herring To: Cristian Ciocaltea Subject: Re: [PATCH v5 1/3] dt-bindings: interrupt-controller: Add Actions SIRQ controller binding Message-ID: <20200825220913.GA1423455@bogus> References: <6bd99d4a7e50904b57bb3ad050725fbb418874b7.1597852360.git.cristian.ciocaltea@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6bd99d4a7e50904b57bb3ad050725fbb418874b7.1597852360.git.cristian.ciocaltea@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200825_180916_709424_27B2563D X-CRM114-Status: GOOD ( 23.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Jason Cooper , Marc Zyngier , linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Thomas Gleixner , Andreas =?iso-8859-1?Q?F=E4rber?= , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 19, 2020 at 07:37:56PM +0300, Cristian Ciocaltea wrote: > Actions Semi Owl SoCs SIRQ interrupt controller is found in S500, S700 > and S900 SoCs and provides support for handling up to 3 external > interrupt lines. > > Signed-off-by: Cristian Ciocaltea > --- > Changes in v5: > - Updated controller description statements both in the commit message > and the binding doc > > .../actions,owl-sirq.yaml | 68 +++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/actions,owl-sirq.yaml > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/actions,owl-sirq.yaml b/Documentation/devicetree/bindings/interrupt-controller/actions,owl-sirq.yaml > new file mode 100644 > index 000000000000..cf9b7a514e4e > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/actions,owl-sirq.yaml > @@ -0,0 +1,68 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/interrupt-controller/actions,owl-sirq.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Actions Semi Owl SoCs SIRQ interrupt controller > + > +maintainers: > + - Manivannan Sadhasivam > + - Cristian Ciocaltea > + > +description: | > + This interrupt controller is found in the Actions Semi Owl SoCs (S500, S700 > + and S900) and provides support for handling up to 3 external interrupt lines. > + > +properties: > + compatible: > + oneOf: > + - items: > + - enum: > + - actions,s500-sirq > + - actions,s700-sirq > + - actions,s900-sirq > + - const: actions,owl-sirq > + - const: actions,owl-sirq This should be dropped. You should always have the SoC specific compatible. > + > + reg: > + maxItems: 1 > + > + interrupt-controller: true > + > + '#interrupt-cells': > + const: 2 > + description: > + The first cell is the input IRQ number, between 0 and 2, while the second > + cell is the trigger type as defined in interrupt.txt in this directory. > + > + 'actions,ext-interrupts': > + description: | > + Contains the GIC SPI IRQ numbers mapped to the external interrupt > + lines. They shall be specified sequentially from output 0 to 2. > + $ref: /schemas/types.yaml#/definitions/uint32-array > + minItems: 3 > + maxItems: 3 Can't you use 'interrupts' here? > + > +required: > + - compatible > + - reg > + - interrupt-controller > + - '#interrupt-cells' > + - 'actions,ext-interrupts' > + > +additionalProperties: false > + > +examples: > + - | > + sirq: interrupt-controller@b01b0200 { > + compatible = "actions,s500-sirq", "actions,owl-sirq"; > + reg = <0xb01b0200 0x4>; > + interrupt-controller; > + #interrupt-cells = <2>; > + actions,ext-interrupts = <13>, /* SIRQ0 */ > + <14>, /* SIRQ1 */ > + <15>; /* SIRQ2 */ > + }; > + > +... > -- > 2.28.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel