From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Martin Cerveny <M.Cerveny@computer.org>
Cc: linux-arm-kernel@lists.infradead.org,
Chen-Yu Tsai <wens@csie.org>,
linux-crypto@vger.kernel.org, Maxime Ripard <mripard@kernel.org>
Subject: Re: PROBLEM: SHA1 on Allwinner V3s failed
Date: Wed, 26 Aug 2020 13:52:09 +0200 [thread overview]
Message-ID: <20200826115209.GA830@Red> (raw)
In-Reply-To: <alpine.GSO.2.00.2008261256100.29556@dmz.c-home.cz>
On Wed, Aug 26, 2020 at 01:33:20PM +0200, Martin Cerveny wrote:
> Hello.
>
> On Wed, 26 Aug 2020, Corentin Labbe wrote:
> > On Wed, Aug 26, 2020 at 09:52:30AM +0200, Martin Cerveny wrote:
> >> Hello.
> >>
> >> [1.] One line summary of the problem:
> >>
> >> SHA1 on Allwinner V3s failed
> >>
> > Since only SHA1 is failling, could you try to use the "allwinner,sun8i-a33-crypto", just in case V3s has the same SHA1 HW quirck than A33.
>
> Yes. This do the trick. All startup verification passes now.
> Performance (SHA1 with sha1-sun4i-ss) "tcrypt mode=303 sec=1" test output attached.
> So, all seems to be working now. Released new patch with possibility to merge.
>
> https://github.com/mcerveny/linux/commit/e3c76436de3d8cd2b2ddaeadef879a4a4d723bf4
>
> Regards, Martin
For proper solution, a new compatible "allwinner,sun8i-v3s-crypto" should be added instead.
Furthermore it should be added in sun4i-ss-core.s along with a new variant for v3s with .sha1_in_be = True.
The new compatible should also be added in Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml
Regards
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-26 11:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 7:52 PROBLEM: SHA1 on Allwinner V3s failed Martin Cerveny
2020-08-26 9:07 ` Corentin Labbe
2020-08-26 11:33 ` Martin Cerveny
2020-08-26 11:52 ` Corentin Labbe [this message]
2020-08-27 17:22 ` [SOLVED] " Martin Cerveny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200826115209.GA830@Red \
--to=clabbe.montjoie@gmail.com \
--cc=M.Cerveny@computer.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).