From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 930A0C433E1 for ; Wed, 26 Aug 2020 11:53:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 51CF120707 for ; Wed, 26 Aug 2020 11:53:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UQ37op2a"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Fl4slJKu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51CF120707 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Qrg3j5ll+Gc2QGbkDUeN62KYglVJyyFCAnO4lQjcCUU=; b=UQ37op2aGM6IzXM97hR0Ax6h4 flGws2C4EXCbkrmBAr4tXUB300iCJEeCvtZrxTBy5VOAvRloxFn6gN2pGby9pxRVahyatmPS/pvMM kVXGktpih62QGp9FgQ+pE3Q38ttRj72jeZJhkIX/j/jP2aZVrZAihCuxGYwrP6nfmlUmrO2J+7Rim e4brtA4OZ8KUiEvhq/YIxz2dPKpzDIhXJ9c0tlXf6G/3MQuTU5Lse/ucDPjzDQzXS/q5SCY0R0L6E sY5+VMuzIvGcKz8rilLoINTDZxlFwI7l76B06k9CzfotQrVlVl3aE3fH6t9RVhjndnU1bqraAgvTo ewIx95WzA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAtyR-0001Bk-Kb; Wed, 26 Aug 2020 11:52:15 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAtyO-0001BO-DS for linux-arm-kernel@lists.infradead.org; Wed, 26 Aug 2020 11:52:13 +0000 Received: by mail-wm1-x343.google.com with SMTP id t2so1465396wma.0 for ; Wed, 26 Aug 2020 04:52:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pv1UwrcfHZa0qjph5LSIk0g8XgKzUh94wpAXHeKDylU=; b=Fl4slJKuET8CzoZ+aMD2Lw6sOO+PrVFE5RoTrtGJ+Gp/Yt0KvcHe/S33TptLfVFX7v 0xlPFDyq2SPd5XXMNGuYlYL8jTVL3jvsFZESKFg2ZJ2/E4eStHLrdE90aOXOlFuUwRo3 KIaYvfGqYHrAm07oAw43uqI0tYKSDELBqbIPbH9F5o6TLxIv18HForaCXXm3PiuDXTV5 JP+OMTZ1MzAm/VV3oRLvBm+sZFYBrgyUGxC8V4xmmmOCpHUiOLFNZ4gpKjXKbDFj7o0c d2YI4hDLZzmLShKN2dyZ8LgcVgiZRprknYp6Gy7s4nFVvE5DJHnknbpcmIeI7r0BvEaB sC6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pv1UwrcfHZa0qjph5LSIk0g8XgKzUh94wpAXHeKDylU=; b=ON4H5nQe3+1Hku5949gLytvLIdOO0bR/6zfL7LufmpVMI5DAuY2wZX97KJXps/TIyq 4ENcZyZl1W4SimmNC1p2HpGjq4EFUHn/TbhmMDRmuRXEaRZPwToZ+UkIwQH/uOK0ruJJ g6Nw8w2Z8O180DCN3edM1HLLE3n1HZgWutQaC4m+pbELLuZ1/N0ju42LRA14Dfcjuyzm dMOMmQkBwGFzXXPCEy7sTJPBcZxMYT58aIR8SkhqGc95Kqmcmh9Xsn6bGFYVFiBpJRc5 GNxQArdQ5aVyZlpOsJITccr9/vgnHuF3EY6Cczj9iV6qoZie1Ed7nc94bHfYIM1wcAHD InNg== X-Gm-Message-State: AOAM531d3yVB6+LULJCaOKJ6ZxrlUZvmKTYw27ILXK6TzV41ysOuwm4E 52P30ta/UGTcJvpLZHNTQBI= X-Google-Smtp-Source: ABdhPJx3BCxpq5hCIIIwvQ0uWV5EFBefAhPIO/gGlYq7D9ERqs1Sy+S7CgKXEsdRVDjXg7b+yVDQ/g== X-Received: by 2002:a1c:e006:: with SMTP id x6mr7178397wmg.128.1598442731250; Wed, 26 Aug 2020 04:52:11 -0700 (PDT) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id u17sm6329729wrp.81.2020.08.26.04.52.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 04:52:10 -0700 (PDT) Date: Wed, 26 Aug 2020 13:52:09 +0200 From: Corentin Labbe To: Martin Cerveny Subject: Re: PROBLEM: SHA1 on Allwinner V3s failed Message-ID: <20200826115209.GA830@Red> References: <20200826090738.GA6772@Red> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200826_075213_198690_366556E2 X-CRM114-Status: GOOD ( 15.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Chen-Yu Tsai , linux-crypto@vger.kernel.org, Maxime Ripard Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 26, 2020 at 01:33:20PM +0200, Martin Cerveny wrote: > Hello. > > On Wed, 26 Aug 2020, Corentin Labbe wrote: > > On Wed, Aug 26, 2020 at 09:52:30AM +0200, Martin Cerveny wrote: > >> Hello. > >> > >> [1.] One line summary of the problem: > >> > >> SHA1 on Allwinner V3s failed > >> > > Since only SHA1 is failling, could you try to use the "allwinner,sun8i-a33-crypto", just in case V3s has the same SHA1 HW quirck than A33. > > Yes. This do the trick. All startup verification passes now. > Performance (SHA1 with sha1-sun4i-ss) "tcrypt mode=303 sec=1" test output attached. > So, all seems to be working now. Released new patch with possibility to merge. > > https://github.com/mcerveny/linux/commit/e3c76436de3d8cd2b2ddaeadef879a4a4d723bf4 > > Regards, Martin For proper solution, a new compatible "allwinner,sun8i-v3s-crypto" should be added instead. Furthermore it should be added in sun4i-ss-core.s along with a new variant for v3s with .sha1_in_be = True. The new compatible should also be added in Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml Regards _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel