From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21E07C433DF for ; Wed, 26 Aug 2020 14:00:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2F3C214F1 for ; Wed, 26 Aug 2020 14:00:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eonKPAcc"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="AyWGoc8N" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2F3C214F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DitiA6ubxxf4Thblhz07ltt2eLERf0UOeIrE5ClLvT0=; b=eonKPAccTn8qfyUy5h/oiY5+5 v4xkyV952OkVLFrOyZ034q2Au6oo9VmVI8cP8NKJQ/Sz1JYaStN4VY+4cjtwVPnn0ENYLOFNkC8Og AMJle3ORpU83y3gCz9PybYr9Dh96oGqJhjLmHeVfD9rxo+NDPawUvuyMAoCHZhs2kQ1ten5hKnwgR QVANwN6eagrK54YZ5OUcFTGYa3PlAocQmim8xM7oqsQ85wmOtdN8+owPY8mS3vVzLQKx2TEGy4caO t4JloTHxXuh57R2aH5ZaeawhC5noS+uXp9H45KYt4LitLNMcVZaqAPtgR2FsWJ6nFc23dxNgIzse0 6JwwMl33g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAvx7-0002Ly-6o; Wed, 26 Aug 2020 13:59:01 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAvx4-0002LC-33 for linux-arm-kernel@lists.infradead.org; Wed, 26 Aug 2020 13:58:59 +0000 Received: from coco.lan (ip5f5ad5c5.dynamic.kabel-deutschland.de [95.90.213.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E1633208E4; Wed, 26 Aug 2020 13:58:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598450336; bh=YkzcWB73ePr3Oil75zS5HXqhh0BUssf4jCPt3WQXWv0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=AyWGoc8NK5xXU2LyoXkTZSSzMY+framiCGojSBWhjv8qiK67iwx/uPDC3FdRr4wnE MJ+tACUhGnG5HhmyBQ9W/nmL+VDnGRo6rdOT6uM35/3qXJwn9YXwD8Y3GacSeXxv9W gZG8SbjwpzcintC9fQPvyolV9akUUy4BQXgmyauQ= Date: Wed, 26 Aug 2020 15:58:51 +0200 From: Mauro Carvalho Chehab To: Robin Murphy Subject: Re: [PATCH] dtbs: hikey970: add wifi support Message-ID: <20200826155851.72219d24@coco.lan> In-Reply-To: References: X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200826_095858_225068_FC48D2D5 X-CRM114-Status: GOOD ( 23.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Manivannan Sadhasivam , linux-kernel@vger.kernel.org, Wei Xu , linuxarm@huawei.com, Rob Herring , John Stultz , mauro.chehab@huawei.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Wed, 26 Aug 2020 13:41:49 +0100 Robin Murphy escreveu: > On 2020-08-26 06:57, Mauro Carvalho Chehab wrote: > > The dwmmc2 is used on Hikey 970 for WiFi support. The > > hi3670.dtsi adds it, but with status="disabled". > > > > For WiFi to work,it needs to be enabled. While here, add > > the missing properties: > > > > #address-cells = <0x1>; > > #size-cells = <0x0>; > > > > and add > > ti,non-removable > > > > To DT properties, as the WiFi support is on a non-removable slot. > > > > Signed-off-by: Mauro Carvalho Chehab > > --- > > arch/arm64/boot/dts/hisilicon/hi3670-hikey970.dts | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/hisilicon/hi3670-hikey970.dts b/arch/arm64/boot/dts/hisilicon/hi3670-hikey970.dts > > index f218acceec0b..a2b0d2a1d09d 100644 > > --- a/arch/arm64/boot/dts/hisilicon/hi3670-hikey970.dts > > +++ b/arch/arm64/boot/dts/hisilicon/hi3670-hikey970.dts > > @@ -402,6 +402,7 @@ &sd_clk_cfg_func > > > > &dwmmc2 { /* WIFI */ > > bus-width = <0x4>; > > + ti,non-removable; > > Why? This property is only defined for OMAP HSMMC controllers, which > this isn't, and you've already got the proper generic property right > there below. Plus in terms of Linux it will have zero effect, since it's > only parsed by the omap_hsmmc driver anyway. > > > non-removable; > > broken-cd; > > cap-power-off-card; > > @@ -409,8 +410,12 @@ &dwmmc2 { /* WIFI */ > > pinctrl-0 = <&sdio_pmx_func > > &sdio_clk_cfg_func > > &sdio_cfg_func>; > > + status = "ok"; > > Have you noticed the context 6 lines below? > > > + > > /* WL_EN */ > > vmmc-supply = <&wlan_en>; > > + #address-cells = <0x1>; > > + #size-cells = <0x0>; > > These are already present in hi3670.dtsi. AFAICS Wifi support was merged > 18 months ago :/ My mistake! It seems that I need more caffeine today. I wrote this patch for an older Kernel version (4.19). I ended porting it to 5.8, with also required another patch, due to a regression between Kernel 5.7 and 5.8: https://lore.kernel.org/lkml/f0a2cb7ea606f1a284d4c23cbf983da2954ce9b6.1598420968.git.mchehab+huawei@kernel.org/ Thanks, Mauro _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel