From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82616C433E1 for ; Wed, 26 Aug 2020 21:43:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 47C7020738 for ; Wed, 26 Aug 2020 21:43:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="wyyudJ5q"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PyCFzgkN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47C7020738 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tYiJFJT12dyguDNYWZAyqj3U/roazy7X+SE50iU1jq4=; b=wyyudJ5q7cJ4VkTlIoaDaeGrK 3EMxh3vyZp01+mmjZPaGmYmKKOuj5CPFJ82UEzBry0d8EyJNG2nZSfgwAEBmko8WzU8jwcSnndZCq ElP7QPWPnKAh+Jz6g1VOacqBRXNAryVFvf8IOOhGfQ66cH5qPUjMG5RQ0jD3fNRJg54AuhmrPMLsz IVi2FsAWc9KfA/EeEJ/Bh57Uf+Mjm2NsG6oSDOFTk2wwdJnwQzog13d813Ap2mC9LPagERD3ggCq0 fq8Ywz5/JZCv0EnVRa+S9Bcsok2ZIYKEkwfHA4Ms52dOcsBY3WG+NP3BJM/obHSAZ/HxHkBYAX2t2 f4AzxQfpw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kB3Bd-0003CY-10; Wed, 26 Aug 2020 21:42:29 +0000 Received: from mail-ej1-x641.google.com ([2a00:1450:4864:20::641]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kB3Ba-0003Ba-0X; Wed, 26 Aug 2020 21:42:27 +0000 Received: by mail-ej1-x641.google.com with SMTP id d26so4920583ejr.1; Wed, 26 Aug 2020 14:42:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=qkQL+Dz21LFiMHXtvS7buva83SIiDacIGRIi5LVRWg8=; b=PyCFzgkN4OSai9YlhJND550USk3u7FaciC9YgUIZvY0Dh8d5TA0I24RDsNx6i7gQIt 43S8wVNDsP9AW3izt9SO0uBb+igdIKuhEB9S9recizqdcc9vwij9FM3ShhZkWckO1N14 SR+MdGCz0v1X9nSFShTSMQ3QQmsRDPyW5OiIze0AIfebwEKaTXtdGSftF99HKtHuv+Lm xnspvSP0TAOxJb57VIv4Z1fnzrve8CwGT/gdAxHVPtPo2dKgtPUHss9jeXI34ynG/B2Z 5WVyjXhHSfTi6KpxG7FK4HNBW2et8UQeEkghOGdMDQbhZfvIgKymf42g1MrUo2IcMTXz m/bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qkQL+Dz21LFiMHXtvS7buva83SIiDacIGRIi5LVRWg8=; b=RVDwHZ/eqNInmm7FH1lAAtOrp5/frCBiT4rqLtWan04oZVRiixo4df/rCtQd/ZyASL Tf+ckz/Np9Bxlu15suy6KRmOwI9wtZQ0qcfXKdO1H+KEKhVDwVAr+gTrFQEwr09bS6dW E575r1xeYhImGym7g3uXcGf+hkMWjSbAPbVFmkIR3kRZVq4CdTwwKnO2K/s5Jodb+j11 uDOCZEz9dKUOYsHimJjvobpRGbfEamjs9zPoCillsZ0q2+jDdIenFSU1Z0jusqCX0lOU DXoRUNgRYe1gL4E3hU5yioExo2ae9yymZPzmohdgqa1/qo+FjppO7hz7n7hgC+/WDXtF jhHg== X-Gm-Message-State: AOAM532ZMh6RPuLZV8CFifHeAl4GkjhoVHK+EE5uVu4iVhSq46tt8iyz PFrEWKUpceSChvo6kjGFveE= X-Google-Smtp-Source: ABdhPJwDStQ0rjD3Lur2BK6467nAxbWULaSG6srrhmhkiq7NgIt/9VvkrfTyfXgZXbN5LfIVRGWiBA== X-Received: by 2002:a17:906:2349:: with SMTP id m9mr17411173eja.425.1598478143345; Wed, 26 Aug 2020 14:42:23 -0700 (PDT) Received: from BV030612LT ([188.24.159.61]) by smtp.gmail.com with ESMTPSA id ci27sm173363ejc.23.2020.08.26.14.42.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 14:42:22 -0700 (PDT) Date: Thu, 27 Aug 2020 00:42:20 +0300 From: Cristian Ciocaltea To: Rob Herring Subject: Re: [PATCH v5 1/3] dt-bindings: interrupt-controller: Add Actions SIRQ controller binding Message-ID: <20200826214220.GA2444747@BV030612LT> References: <6bd99d4a7e50904b57bb3ad050725fbb418874b7.1597852360.git.cristian.ciocaltea@gmail.com> <20200825220913.GA1423455@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200825220913.GA1423455@bogus> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200826_174226_091646_5029916E X-CRM114-Status: GOOD ( 29.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Jason Cooper , Marc Zyngier , linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Thomas Gleixner , Andreas =?iso-8859-1?Q?F=E4rber?= , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, Thanks for the review! On Tue, Aug 25, 2020 at 04:09:13PM -0600, Rob Herring wrote: > On Wed, Aug 19, 2020 at 07:37:56PM +0300, Cristian Ciocaltea wrote: > > Actions Semi Owl SoCs SIRQ interrupt controller is found in S500, S700 > > and S900 SoCs and provides support for handling up to 3 external > > interrupt lines. > > > > Signed-off-by: Cristian Ciocaltea > > --- > > Changes in v5: > > - Updated controller description statements both in the commit message > > and the binding doc > > > > .../actions,owl-sirq.yaml | 68 +++++++++++++++++++ > > 1 file changed, 68 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/actions,owl-sirq.yaml > > > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/actions,owl-sirq.yaml b/Documentation/devicetree/bindings/interrupt-controller/actions,owl-sirq.yaml > > new file mode 100644 > > index 000000000000..cf9b7a514e4e > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/interrupt-controller/actions,owl-sirq.yaml > > @@ -0,0 +1,68 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/interrupt-controller/actions,owl-sirq.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Actions Semi Owl SoCs SIRQ interrupt controller > > + > > +maintainers: > > + - Manivannan Sadhasivam > > + - Cristian Ciocaltea > > + > > +description: | > > + This interrupt controller is found in the Actions Semi Owl SoCs (S500, S700 > > + and S900) and provides support for handling up to 3 external interrupt lines. > > + > > +properties: > > + compatible: > > + oneOf: > > + - items: > > + - enum: > > + - actions,s500-sirq > > + - actions,s700-sirq > > + - actions,s900-sirq > > + - const: actions,owl-sirq > > + - const: actions,owl-sirq > > This should be dropped. You should always have the SoC specific > compatible. Sure, I will get rid of the 'owl-sirq' compatible. > > + > > + reg: > > + maxItems: 1 > > + > > + interrupt-controller: true > > + > > + '#interrupt-cells': > > + const: 2 > > + description: > > + The first cell is the input IRQ number, between 0 and 2, while the second > > + cell is the trigger type as defined in interrupt.txt in this directory. > > + > > + 'actions,ext-interrupts': > > + description: | > > + Contains the GIC SPI IRQ numbers mapped to the external interrupt > > + lines. They shall be specified sequentially from output 0 to 2. > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > + minItems: 3 > > + maxItems: 3 > > Can't you use 'interrupts' here? This was actually my initial idea, but it might confuse the users since this is not following the parent controller IRQ specs, i.e. the trigger type is set internally by the SIRQ driver, it's not taken from DT. Please see the DTS sample bellow where both devices are on the same level and have GIC as interrupt parent. The 'interrupts' property in the sirq node looks incomplete now. That is why I decided to use a custom name for it, although I'm not sure it's the most relevant one, I am open to any other suggestion. i2c0: i2c@b0170000 { [...] interrupts = ; [...] }; sirq: interrupt-controller@b01b0200 { [...] interrupt-controller; #interrupt-cells = <2>; interrupts = <13>, /* SIRQ0 */ <14>, /* SIRQ1 */ <15>; /* SIRQ2 */ }; Regards, Cristi > > + > > +required: > > + - compatible > > + - reg > > + - interrupt-controller > > + - '#interrupt-cells' > > + - 'actions,ext-interrupts' > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + sirq: interrupt-controller@b01b0200 { > > + compatible = "actions,s500-sirq", "actions,owl-sirq"; > > + reg = <0xb01b0200 0x4>; > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + actions,ext-interrupts = <13>, /* SIRQ0 */ > > + <14>, /* SIRQ1 */ > > + <15>; /* SIRQ2 */ > > + }; > > + > > +... > > -- > > 2.28.0 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel