From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C99AC433E1 for ; Thu, 27 Aug 2020 06:54:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A79D207BC for ; Thu, 27 Aug 2020 06:54:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UjnaBNIf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A79D207BC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mMTOEZt38izgNYT4fZertyKOZXcJbADsuLh26y0c910=; b=UjnaBNIfpbNrrNK2QEeNLxdmH sJ4baurmY+Z+zCDvdhpdiUBMRuhM4cUNdjv/1B0bDrJ1idtXWL53Duo00iKjuSPMBba8m50ItCCQb EpA2ROh56fN7r6YlBkNE6akH9gkSaUjNzhbEnvnPaMVLYlxXD0t8pIah3YkuRBh2iwb1LNgYNll4q +puKkbiEcBYxtRD86knsDYy/6+JZ7gQZgI1WLr1g/pB/5S+1Z6YF5MXK0zeMNRGplFgU8MouwhZzR qBs1EPUgOZ2QOey7Mpec0y6cCLuZpn3M2NhuQ1AE+DuNuq2cuIBzyqTBNIZJ54K6wWq7ZhpB6YF3V fZBq8rfUA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kBBmI-0001OO-7j; Thu, 27 Aug 2020 06:52:54 +0000 Received: from mail-ej1-f68.google.com ([209.85.218.68]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kBBmE-0001MP-9a for linux-arm-kernel@lists.infradead.org; Thu, 27 Aug 2020 06:52:51 +0000 Received: by mail-ej1-f68.google.com with SMTP id e23so5411217ejb.4 for ; Wed, 26 Aug 2020 23:52:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=yjb4IAblmNaYNb4UyN8UvAWwkcCaPYr1YWuJlC155Xw=; b=NP31RBrOeRY0v1SQlJ7wnAeWctxpiFhi5WCG80fnKuU72oLcAjWeT+3kRaYt4h6q/b SxX0YsQLDh8b0kw5QmJqh2yi/zeij2utg4809ORh5jXB75QCFvUR58FDlo7j4XJ7rAO/ yZiBK6P5fexyQD9+6OccUr6r7YoBjPxJpl1nfOFcZncrj/CFL0QcBqf1dLOO6dnHvATT Rv90rqbZns0E3cEdwvJ0Xx4FAU2eVS0q1IcgVhPUb0rsa0fVANMPuX55VAkL6OqfP9u8 MH5Nb1NA5soWYS2ZP2K7CwoHMj+U0J6/9JXSwSmihfDLPR01kaVD3/0AD3E1nN43QwiU LWEA== X-Gm-Message-State: AOAM530sQPMct+cSpnUM1qdcbHhnAjMm0itIjiizClm/vZkh55WbYF39 Mv1m8Ncf4XIzH3G1zNjDV1U= X-Google-Smtp-Source: ABdhPJxFi7OZcJ8tVwLQiriRIQeG6696mgkLPi6JyH7EO4QW9OqOFKyOZ9PPbkYg6qtMEYqAYHQLDw== X-Received: by 2002:a17:906:1404:: with SMTP id p4mr19224149ejc.256.1598511168930; Wed, 26 Aug 2020 23:52:48 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id l25sm1146359ejg.11.2020.08.26.23.52.47 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 26 Aug 2020 23:52:48 -0700 (PDT) Date: Thu, 27 Aug 2020 08:52:46 +0200 From: Krzysztof Kozlowski To: Tang Bin Subject: Re: [PATCH] usb: host: ohci-exynos: Fix error handling in exynos_ohci_probe() Message-ID: <20200827065246.GA17964@kozik-lap> References: <20200826144931.1828-1-tangbin@cmss.chinamobile.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200826144931.1828-1-tangbin@cmss.chinamobile.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200827_025250_583082_E39D742A X-CRM114-Status: GOOD ( 14.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kgene@kernel.org, stern@rowland.harvard.edu, Zhang Shengju , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 26, 2020 at 10:49:31PM +0800, Tang Bin wrote: > If the function platform_get_irq() failed, the negative value > returned will not be detected here. So fix error handling in > exynos_ohci_probe(). And when get irq failed, the function > platform_get_irq() logs an error message, so remove redundant > message here. > > Fixes: 62194244cf87 ("USB: Add Samsung Exynos OHCI diver") > Signed-off-by: Zhang Shengju > Signed-off-by: Tang Bin > --- > drivers/usb/host/ohci-exynos.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel