From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5512C433E1 for ; Thu, 27 Aug 2020 15:26:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D1532080C for ; Thu, 27 Aug 2020 15:26:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Kb2c5bF+"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dZ1UT1Jv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D1532080C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BD+rnbw5KyQz5FB67zjtzErxUgl6xIeC/NPALJITyPk=; b=Kb2c5bF+099jVm2qb4GhJ57oc zm+DXAukQtB48HqTaTyCamYrGu6wH9/uJLTVTYy0Wn3jTe5CjGiIDeIOMhRWDBYXDfvnFJXa1MRMY 3MojbNBRQLUKin0KL6GIoApVyAHMz6i3Vr6UwEZt8C7w+iinTuHVBOO7vEPJW3FXWDzZNdrQvYtDC VeRzSxZSHWhIkGwcKe84HaFMDOaODZEeT0TU7cdorCN9s4DOKskS5fJa44tHwfQzzhDTRAfjrxtwN 0cK2pzuCiAA2/J1n191qHyQZAukJFxcpvzkSOTq3JpEy5BXp6EGir9pK37HnfUzqfXMWaf6gO77UG EaG3tFwxw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kBJlU-0004Rq-VT; Thu, 27 Aug 2020 15:24:37 +0000 Received: from mail-ej1-x644.google.com ([2a00:1450:4864:20::644]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kBJlR-0004RD-4v; Thu, 27 Aug 2020 15:24:34 +0000 Received: by mail-ej1-x644.google.com with SMTP id j25so8192083ejk.9; Thu, 27 Aug 2020 08:24:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RdoDtBKGcqZmEr6XwRvBVpJT6+jSdmIYiVMHvZ2UEtM=; b=dZ1UT1JvUfj8uxpfO5tKZObD9vupZ6VKPHEPWHiIX6/azQ3Xx0wiMpuwNWJrbqQuRF MtFchebdnoYgSKqDE0PxgEUQ2ono+2kbI99Ov7xzOQqnPKNzI68N8AQ9wVOUPW+Rn0e7 sYR5JWw22qj/yPUWFU7yH3afY4qi1ThAZFMX4QPAmju0zzCW9ZQnqMzGiptFdTfuuV3O l7VwkbseTYupt71wVEWopi3mA00+fcQB0ENTmVwqdxeP4dQe5BPNA7jk9FprgWcTqtyR ezQCSepa0hmpM8sRO9RiKBLtNV/WHEM+gxLrIEPK467vYT1vQ6PHqju5+BgSG7sd4VPd /lSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RdoDtBKGcqZmEr6XwRvBVpJT6+jSdmIYiVMHvZ2UEtM=; b=Ab8X1HdUrqZBm1vtHcELRJs7U2xpGNbK4y0Z7kGL6dSs69shJ5mRIF8P2cUF/15yrC Z2I3YWLYqI0KT21k6rP2eZxCI1ND7ZZ0yItxLq63RG4nB8NLybzRkIY5nFXw/UFfeEyl /3IlwPMSTAz/K2HQBn6pa2TI2pMuKrFC1zIgnfJpzvrYueRU3EDh21RgwbLdiO6+n4fD wDFk3cNWRijJRPKuw3EjxmvMZVxF0HgPjFfMeIfKkk8f5C1Rx3A7RZN/A8GdVLGcGcCv pafbySMCm+wujem6YyMwqZAh4Zc2RoXP5bONTRlEh5bAW+AMuOVXN13MpQGeGqCXdl93 PMgg== X-Gm-Message-State: AOAM532M4qrKj2EVGjlittcV/em7sPliN1Fc7SQ244t1ea+YCZK6Kr/5 2EOfW0cGElVfFv86qTorey8= X-Google-Smtp-Source: ABdhPJwE8DVg2X/JWXzdbYoyz5GYUFxkza0BR0PvLwoLKnPpFlRU1KQlEOc3ePw+NgAdF36O9erBYw== X-Received: by 2002:a17:906:1719:: with SMTP id c25mr22373847eje.487.1598541871646; Thu, 27 Aug 2020 08:24:31 -0700 (PDT) Received: from BV030612LT ([188.24.159.61]) by smtp.gmail.com with ESMTPSA id g9sm1742781edk.97.2020.08.27.08.24.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Aug 2020 08:24:30 -0700 (PDT) Date: Thu, 27 Aug 2020 18:24:28 +0300 From: Cristian Ciocaltea To: Marc Zyngier Subject: Re: [PATCH v5 1/3] dt-bindings: interrupt-controller: Add Actions SIRQ controller binding Message-ID: <20200827152428.GA2467154@BV030612LT> References: <6bd99d4a7e50904b57bb3ad050725fbb418874b7.1597852360.git.cristian.ciocaltea@gmail.com> <20200825220913.GA1423455@bogus> <20200826214220.GA2444747@BV030612LT> <20200827100629.GA2451538@BV030612LT> <64580e3b9acada6ff4ae9fdef02ac304@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <64580e3b9acada6ff4ae9fdef02ac304@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200827_112433_241638_FD76F056 X-CRM114-Status: GOOD ( 21.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Jason Cooper , devicetree@vger.kernel.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Thomas Gleixner , Andreas =?iso-8859-1?Q?F=E4rber?= , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marc, On Thu, Aug 27, 2020 at 11:35:06AM +0100, Marc Zyngier wrote: > On 2020-08-27 11:06, Cristian Ciocaltea wrote: > > On Wed, Aug 26, 2020 at 04:48:38PM -0600, Rob Herring wrote: > > > On Wed, Aug 26, 2020 at 3:42 PM Cristian Ciocaltea > > > wrote: > > [...] > > > > Ultimately the GIC trigger type has to be > > > something. Is it fixed or passed thru? If the latter, just use 0 > > > (IRQ_TYPE_NONE) if the GIC trigger mode is not fixed. Having some sort > > > of translation of the trigger is pretty common. > > > > Yes, as explained above, the SIRQ controller performs indeed the > > translation of the incoming signal. So if I understand correctly, your > > suggestion would be to use the following inside the sirq node: > > > > interrupts = , /* SIRQ0 */ > > [...] > > Please don't. If you are describing a GIC interrupt, use a > trigger that actually exists. Given that you have a 1:1 > mapping between input and output, just encode the output > trigger that matches the input. Understood, the only remark here is that internally, the driver will not use this information and instead will continue to rely on the input to properly set the trigger type for the output. The question is if the driver should also emit a warning (or error?) when the trigger type supplied via DT doesn't match the expected value. If yes, we should also clarify what the user is supposed to provide in the controller node: the trigger type before the conversion (the input) or the one after the conversion (the output). > M. > -- > Jazz is not dead. It just smells funny... Thanks, Cristi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel