From: Guenter Roeck <linux@roeck-us.net>
To: cy_huang <u0084500@gmail.com>
Cc: gene_chen@richtek.com, devicetree@vger.kernel.org,
heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
cy_huang@richtek.com, robh+dt@kernel.org,
linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/3] usb typec: mt6360: Rename driver/Kconfig/Makefile from mt6360 to mt636x
Date: Thu, 27 Aug 2020 09:41:31 -0700 [thread overview]
Message-ID: <20200827164131.GA86149@roeck-us.net> (raw)
In-Reply-To: <1598527137-6915-2-git-send-email-u0084500@gmail.com>
On Thu, Aug 27, 2020 at 07:18:56PM +0800, cy_huang wrote:
> From: ChiYuan Huang <cy_huang@richtek.com>
>
> 1. Rename file form tcpci_mt6360.c to tcpci_mt636x.c
> 2. Rename internal function from mt6360 to mt636x, except the register
> definition.
> 3. Change Kconfig/Makefile from MT6360 to MT636X.
>
> Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> ---
> drivers/usb/typec/tcpm/Kconfig | 6 +-
> drivers/usb/typec/tcpm/Makefile | 2 +-
> drivers/usb/typec/tcpm/tcpci_mt6360.c | 212 ----------------------------------
> drivers/usb/typec/tcpm/tcpci_mt636x.c | 212 ++++++++++++++++++++++++++++++++++
> 4 files changed, 216 insertions(+), 216 deletions(-)
> delete mode 100644 drivers/usb/typec/tcpm/tcpci_mt6360.c
> create mode 100644 drivers/usb/typec/tcpm/tcpci_mt636x.c
Maybe Heikki is ok with this change, but I am not, for the reasons
mentioned before. So I won't approve this patch. Note that, either
case, it should be merged with the first patch.
Guenter
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-27 16:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 11:18 [PATCH v3 1/3] usb typec: mt6360: Add support for mt6360 Type-C driver cy_huang
2020-08-27 11:18 ` [PATCH v3 2/3] usb typec: mt6360: Rename driver/Kconfig/Makefile from mt6360 to mt636x cy_huang
2020-08-27 16:41 ` Guenter Roeck [this message]
2020-08-28 5:54 ` ChiYuan Huang
2020-08-27 11:18 ` [PATCH v3 3/3] usb typec: mt6360: Add MT6360 Type-C DT binding documentation cy_huang
2020-08-27 14:00 ` [PATCH v3 1/3] usb typec: mt6360: Add support for mt6360 Type-C driver Heikki Krogerus
2020-08-27 14:51 ` ChiYuan Huang
2020-08-28 9:38 ` Heikki Krogerus
2020-08-28 10:27 ` ChiYuan Huang
2020-08-28 11:57 ` Heikki Krogerus
2020-08-28 12:10 ` Chunfeng Yun
2020-08-28 14:33 ` ChiYuan Huang
2020-08-28 14:48 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827164131.GA86149@roeck-us.net \
--to=linux@roeck-us.net \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=gene_chen@richtek.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=u0084500@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).