From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B795FC433E1 for ; Thu, 27 Aug 2020 19:08:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 81A13207CD for ; Thu, 27 Aug 2020 19:08:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Snx6JVBO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 81A13207CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BCmsTLVqKSfFVffgtMSZ7pBsiFCrRAYcDcv8TmDoQwU=; b=Snx6JVBO32lzSszWPY4G0a1Kn OBdPzJ8NnrOGHrGTabD8yR1yYwvokQvb2ZgBTNcgrz5o7jTXPYIgO/V5O/jY+jBzpPTSVYkLAKvAj +mFnFi93tjifH1j3eh0KZczn36xsJh5xnz4E+xvNzW46+MD7c/kN+xiIIryaHygfkv/I6s8GWg/C9 c47nNx001bdch04ZC6jWiUe/KeCsn0dNCrsxNYWqmKpNsiIIT4zA0hZh1uO/1rfsS/HeCoXhBfIdq MHqOi8exjLqYVC/vxL+n0sn/HQeriGDJkJNbZnAEjRLM6av/6mCOiD5uzEJhoUVZI200QF3FwF6vb LrLRfy+fA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kBNEh-0004Gb-0w; Thu, 27 Aug 2020 19:06:59 +0000 Received: from mail-ej1-f66.google.com ([209.85.218.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kBNEf-0004GA-CN for linux-arm-kernel@lists.infradead.org; Thu, 27 Aug 2020 19:06:58 +0000 Received: by mail-ej1-f66.google.com with SMTP id e23so8355401ejb.4 for ; Thu, 27 Aug 2020 12:06:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=kX9eyuUyhq2QFDZPTT8K+fKfXv//9k/lun1Oefq69vQ=; b=fbSW65YWTtcs+Rf+QwhAPj4VzrFzs+wl8BOSejXz+mTcrtxM2XCGnmKXg44RR6wFfB SQ3ns5hRhoWBUpgsdtxwtgFa81i5KIAlwekwbi0Mmm0ingULzZKIB7TsljdL2ziK0aiY vfW0nNCsr6ZHCQz7FppN5dzo8l5x+KwAFVHF1r6aBShgWkWzjqUtTOaEIlmd+houCv1k cgEp28P25rQVOusNtd2RIaKdewafQkKxr1zUto6WmrqWmuMhqJcucOYhoq1EQXRKiQq7 9/DpWgWTunkGKC67dbju5Aj+jw7spbC7loTH1t4zI4kivrl9mvGVwdIO5aCwVZzrAwDh KKvA== X-Gm-Message-State: AOAM5316AVV2n9+LvOElsYPXcRKQFcA6/bPFCsgtTsf41gHio1rrcCNc 0rSQh7ZmokOt5DITPaZBlws= X-Google-Smtp-Source: ABdhPJwErb1TPe6yej5LwLYtNxfx1kujrjSq4jsHJ5VaVSvbdjyWgjoSXSM2n9G+Y0DfBXVTqlVBtw== X-Received: by 2002:a17:906:37c1:: with SMTP id o1mr22299708ejc.279.1598555215565; Thu, 27 Aug 2020 12:06:55 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id w20sm2629985ejc.77.2020.08.27.12.06.54 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 27 Aug 2020 12:06:54 -0700 (PDT) Date: Thu, 27 Aug 2020 21:06:52 +0200 From: Krzysztof Kozlowski To: Andy Shevchenko Subject: Re: [PATCH v2] iio: adc: stm32: Simplify with dev_err_probe() Message-ID: <20200827190652.GD6196@kozik-lap> References: <20200826161818.20969-1-krzk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200827_150657_468108_204EA445 X-CRM114-Status: GOOD ( 17.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Etienne Carriere , Lars-Peter Clausen , Alexandre Torgue , linux-iio , Peter Meerwald-Stadler , Linux Kernel Mailing List , linux-arm Mailing List , Maxime Coquelin , Hartmut Knaack , Alexandru Ardelean , Fabrice Gasnier , linux-stm32@st-md-mailman.stormreply.com, Jonathan Cameron Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 27, 2020 at 11:27:12AM +0300, Andy Shevchenko wrote: > On Wed, Aug 26, 2020 at 7:19 PM Krzysztof Kozlowski wrote: > > > > Common pattern of handling deferred probe can be simplified with > > dev_err_probe(). Less code and also it prints the error value. > > > > > > > > priv->aclk = devm_clk_get(&pdev->dev, "adc"); > > if (IS_ERR(priv->aclk)) { > > ret = PTR_ERR(priv->aclk); > > - if (ret != -ENOENT) { > > - if (ret != -EPROBE_DEFER) > > - dev_err(&pdev->dev, "Can't get 'adc' clock\n"); > > - return ret; > > - } > > + if (ret != -ENOENT) > > + return dev_err_probe(&pdev->dev, ret, "Can't get 'adc' clock\n"); > > + > > priv->aclk = NULL; > > } > > > > priv->bclk = devm_clk_get(&pdev->dev, "bus"); > > if (IS_ERR(priv->bclk)) { > > ret = PTR_ERR(priv->bclk); > > - if (ret != -ENOENT) { > > - if (ret != -EPROBE_DEFER) > > - dev_err(&pdev->dev, "Can't get 'bus' clock\n"); > > - return ret; > > - } > > + if (ret != -ENOENT) > > + return dev_err_probe(&pdev->dev, ret, "Can't get 'bus' clock\n"); > > + > > priv->bclk = NULL; > > } > > Again, devm_clk_get_optional() and even, if it exists, > devm_clk_bulk_get_optional(). Sure. > > Please, revisit all patches on this topic. I'll check them. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel