From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6477EC433E6 for ; Thu, 27 Aug 2020 23:59:26 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 308EE2074F for ; Thu, 27 Aug 2020 23:59:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="G5OA6BA5"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=gmx.net header.i=@gmx.net header.b="CJQLvcIY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 308EE2074F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gmx.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:Message-Id:References:Subject: In-reply-to:To:From:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WKb75o4G4oHV6NRnKELYORyU2QKvESYNMJhuZjeEMas=; b=G5OA6BA5lokAjViFIvvqt6Yb54 lVy4QOFz8TJhNJMxWyObkr0ngjDPyQglUE9E/IR3w4LJK0hoZ0rSaakyRHCnedovqyAQZNAhiDcC3 stTbC5TIIfSh6noSRFjT9YRCfV/JJdpPT2kJ18ucsHytCJAAdlZQDwex8s/RVKj2GJjEyL1vnxMtp RFO6ktGWrFdzfAqTc9TYYqqvu7s9A3BfESJu1BoUzHQf4LmLiCxOZ7LuQfj0T1vzg1wHIvQW+oWjT 87mlceF958TRRwWDHvxoHRWHU1tTUbK5u4WVIIHIxi5w5OjJaIW/DlBcBta8T22/aPZODWjUM7Upo b9LoWYxA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kBRlw-0000PW-V8; Thu, 27 Aug 2020 23:57:37 +0000 Received: from mout.gmx.net ([212.227.15.15]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kBRlu-0000PA-CL for linux-arm-kernel@lists.infradead.org; Thu, 27 Aug 2020 23:57:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1598572646; bh=1hiWDO5qubwA61FDSyJLXx84okVXi/UAVFmPbOBlmOg=; h=X-UI-Sender-Class:From:To:cc:In-reply-to:Subject:Reply-to: References:Date; b=CJQLvcIYNl5f7rB68Lm/ozqW7LPtbCKEHjMPeYNh12iEr4aqRJwhV0NgS9kKgKwgJ uG+lKuFiBlgPeDuAaFN3R8QZKS2fPpnEMQ1ejScQe+qqjkCmydszmboNZEo3gO1aFE qNGWB/BOQ0AYEXSALjoc4bNiEgEoMznQYrMSPSV4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from corona.crabdance.com ([173.228.106.43]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MIMfW-1kPn8i3Lb2-00EPgL; Fri, 28 Aug 2020 01:51:09 +0200 Received: by corona.crabdance.com (Postfix, from userid 1000) id BC4D489976B; Thu, 27 Aug 2020 16:49:36 -0700 (PDT) From: Stefan Schaeckeler To: Krzysztof Kozlowski , Borislav Petkov , Mauro Carvalho Chehab , Tony Luck , James Morse , Robert Richter , Joel Stanley , Andrew Jeffery , Tero Kristo , "linux-edac@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" In-reply-to: <20200827070743.26628-1-krzk@kernel.org> Subject: Re: [PATCH 1/2] EDAC/aspeed: Fix handling of platform_get_irq() error References: <20200827070743.26628-1-krzk@kernel.org> <0D9EC2D2-C4A0-42E9-94A5-DCFBE7BFEC43@cisco.com> Message-Id: <20200827234936.BC4D489976B@corona.crabdance.com> Date: Thu, 27 Aug 2020 16:49:36 -0700 (PDT) X-Provags-ID: V03:K1:azkzLvPntcmTm1iQW+tTZY0j0Bw8xT/ONekQtE1unQJo5A5nksM 0GJNUHDntBKfW9JMgtHXOgakjgRZ9d8RwKK3LuJjW2SrBGuCcwnSAijTG0S5i8xcdnLb5zj 7F5iRtWFoR1v5GeCwmcM5Xh0GLc1mrCjBLQ6OeRXvWaOIQY+5FyMcDI9fcDSpCObJWsjAO7 obEjJZR8JDf3it+0pJQ6A== X-UI-Out-Filterresults: notjunk:1;V03:K0:3r8q9FeereM=:iigROZm4TZPigfS8J00iuD 1n998GvlIdFYCRXB6N4ynEg0ulALHg042c7cUL4ZGl/Xw8MJBlCXtjydICBaQRdLGNmRLR2+V kpnjzvSE1bJVrrYUcn78z2IxQPuzwrD+h8am3gO+b1Qgtpd+r4Vwv3Al0M+H4x2YPhI0FFgoM /BIoW6GIsjsPVyJRv4DM8nO2CJUD8+EyZW1Rlq4qP5D5EFbo0UbQgpeqZJ4Me1hIOO25+JDnp rpCq+e1ic7XdhEWSoYRAd1tMHOdA2PMyg0YpKpRElp8RLpEx8+cn87NfLsilorbwrrFV9nkMv D+QnGoUvbhDKs1CgA6uKtnypv2nVpIw96d6q2tuC1Kmuk8FWZ0Mk0Y8zHrEfGivNk+IlN6wvf 64bHA5WIJoJsf6/mKJf7YiFrBHA2AwICKGJ2Hrw0AvBmqw+UO1GNToZE+9OGxfj+YDm6Ls+D/ j77IRbblOyCBnxk6hOAcLJ7Xk6G3MRbW00CT/Cwvmi+09Yb57G1oZTkZXSmEO4DJ/yzE8Aqyo AJywwqdl8ItS3PnAYyxlY3GnUCyBZIaDnTHFJdIibBtmpAFOXYROXKPLo3P3uAxrVf0jmKC3h Dcu43PO7QLXFP9+3G75E5j/Oahzfkk/k62ewRfagykxmzZ9k0RQc3/C7ybRM/Y1USWSQgUo5N m9GdP6kW+P9SCLND0JmQJjyvywEEMqCh6drRCh1TG8HtqGAclqPxecKHAn3RzIf3t4rV3q5GY tkHHT45Iw1UGalaDpXy72j49fSSNkLP7huWa4DKNT2cYTo8Ze4WhrcjtZRmL9gqm+s4Wex42W tLpwrxfMovfxEkuGoJNQETYULAZpwCk5FqLGrYIkqC62AunJW7Z3w5s+QuMGZN07iTRGj9Wes 2Zfq90TSvhKYF5ZlY3ql6NCbpFjNNogBTYFPKVOm4sqKoWiKhaZVmw9OWa8CsZV0mnSpSzxvm ENppQzN/wnouvoQnZXavOMsjsydiVtdVup+daL02fNGioL5UT7/RqnMF65VoN1GwMJBb9jWEn rROy5CQ/RSOaln9MocSIffXW+AbW9D1+aoFFSMwNc0uGE5gr46rOfdUPgFfsJs/XByZ6W4gCU +hMClC/C4cZH4DePw8vApRckdAll9chX7HYM6dd1gNdXimG5J9voEMMVzqjbefNYeFQThbjH0 P9oZRB9B89r6HOP6JU6eE7xbf93KQaICKQArGrdVjs3z0bJYei3p+XU85cx0+orKAAmoRvfnD TxS57hg6PcXNqFd9NrGKeBKwVQbg6pCUt5vVfYQ== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200827_195734_635339_8848FA8B X-CRM114-Status: GOOD ( 16.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: schaecsn@gmx.net Cc: Stefan Schaeckeler MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > platform_get_irq() returns -ERRNO on error. In such case comparison > to 0 would pass the check. > > Fixes: 9b7e6242ee4e ("EDAC, aspeed: Add an Aspeed AST2500 EDAC driver") > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Stefan Schaeckeler > --- > drivers/edac/aspeed_edac.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/edac/aspeed_edac.c b/drivers/edac/aspeed_edac.c > index b194658b8b5c..fbec28dc661d 100644 > --- a/drivers/edac/aspeed_edac.c > +++ b/drivers/edac/aspeed_edac.c > @@ -209,8 +209,8 @@ static int config_irq(void *ctx, struct platform_device *pdev) > /* register interrupt handler */ > irq = platform_get_irq(pdev, 0); > dev_dbg(&pdev->dev, "got irq %d\n", irq); > - if (!irq) > - return -ENODEV; > + if (irq < 0) > + return irq; > > rc = devm_request_irq(&pdev->dev, irq, mcr_isr, IRQF_TRIGGER_HIGH, > DRV_NAME, ctx); > -- > 2.17.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel