From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 282E5C433E6 for ; Fri, 28 Aug 2020 08:35:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D4C4E2078A for ; Fri, 28 Aug 2020 08:35:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KWnXHDrU"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="F33cEkQk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D4C4E2078A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zKt9pU4RSJPEIi0x6TRmX4ZXcmuOkDU3nncqROGpLkw=; b=KWnXHDrU+tdP/IKXx2d6dzBIp rm+eH4Pq4+Fiu4RmngzNjXYfQL3OCsJSSu1K7B1cDfRKx85obwRUIa1Zex5zssF9zyQYnBhjmtX3h KsxF3h1vNp2hLKMXXgFed092fZ7/8K6UbcAcgu2pcIIzX+51dEVYtvgoP8s8yyskZMt9wqkWeFHKu RCGqowvBuwKDkuTNh2cWKWwi9fSqpiHuAkSsy5c+RRA9oNJ/G9qV4p/HTadh3UvNcDYlot1lYP+3/ /llHvWt7Ipb7J1wFcgIz6g+WZqOedmuTNkI6xc7v9IrtkgbMhTEqWAiRGBGct7azCr76YydSZ9n+z bVym8OWSw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kBZpU-0003m2-Ah; Fri, 28 Aug 2020 08:33:48 +0000 Received: from mail-ej1-x642.google.com ([2a00:1450:4864:20::642]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kBZpS-0003lU-6C for linux-arm-kernel@lists.infradead.org; Fri, 28 Aug 2020 08:33:47 +0000 Received: by mail-ej1-x642.google.com with SMTP id s19so443900eju.6 for ; Fri, 28 Aug 2020 01:33:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=aWZAytbmX0Vm3i5CPdD+jnsy7n2gqIJ4osAjPvZBaE0=; b=F33cEkQkRfT4GWOH831j1SLO974KU2Qk19Z5cppU8g6UQ736Ncx8i1BbmBvQvKIT30 HBUBXGBQGGPT39+olnEp0xNW2l4DYQmS+N9hhGw8KVudm+A+lfEJcrKQiypZbXo21HcR zIxMFFpXhmC8YFO65TJMRs7ZwiG7xpBSiRBXlqsBTqqdhhDdrYKISEn6QT/af7CehVFf 1LqsSDnZW30suRZ/9eLa7yAohIISXi8WFhKpTFAnwW58Bv9FqFePi0GbIdjbiNW7Y6gp PNgvlR51lAy0YWYUto/Pbh/CjkVRR9NNM7QeSjlWAzFEtJcODCvgiBArQ9W7XByluh4L iKjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=aWZAytbmX0Vm3i5CPdD+jnsy7n2gqIJ4osAjPvZBaE0=; b=fxTkim/+QxoDuVQDfITLV80nc+B1ufmBoFMfdHeG8/jDu0qg4N16lw8WYEnLI6R50R cvfW+4EN7EZIeg2gBYbnLr9k8vHv+CZbGWpkYOtwjwrLrdPAJUg5UQvxZVzNoAgmt568 O0LBd/j0CkBnWteYoRBgJ3PP2LAQSqoibW1z/yhTH4xmucVRjp9cX2Vsdx4Kqi2wsBnk i8gcugqJjc2xuPZWW2CooPahOakd97xyU5bO8JnKof0VkGnq+IiXsMtSXV0i4RQKXwt2 ycPUo0Mi68fO/N3qOZtek8wH6tZ9P23eDLtdycAnRSC4cN1ZC8T5CAdWdNW8nAwwyY8Q F5kw== X-Gm-Message-State: AOAM533pGIZQEyBs3/p4zXdmJTWnAHMWQQj/KIevLV0ptMbqoW+L8PMq mPLBAFd8pn+3F+7ZbRTh5K2crA== X-Google-Smtp-Source: ABdhPJxVMLCYOpD/z5IxTq8PmxExD3cog9AnNXWCZAE7Kgc+uU+vxaRxHYZ5VXmKpSCyoYhFXwkWUg== X-Received: by 2002:a17:906:7f0b:: with SMTP id d11mr730770ejr.116.1598603622909; Fri, 28 Aug 2020 01:33:42 -0700 (PDT) Received: from myrica ([2001:1715:4e26:a7e0:116c:c27a:3e7f:5eaf]) by smtp.gmail.com with ESMTPSA id ci27sm308673ejc.23.2020.08.28.01.33.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Aug 2020 01:33:42 -0700 (PDT) Date: Fri, 28 Aug 2020 10:33:25 +0200 From: Jean-Philippe Brucker To: "Song Bao Hua (Barry Song)" Subject: Re: [PATCH] iommu/arm-smmu-v3: add tracepoints for cmdq_issue_cmdlist Message-ID: <20200828083325.GC3825485@myrica> References: <20200827093351.15244-1-song.bao.hua@hisilicon.com> <20200828074107.GB3825485@myrica> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200828_043346_334703_409C0E69 X-CRM114-Status: GOOD ( 17.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "will@kernel.org" , "iommu@lists.linux-foundation.org" , "robin.murphy@arm.com" , Linuxarm , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 28, 2020 at 07:55:18AM +0000, Song Bao Hua (Barry Song) wrote: > > > > -----Original Message----- > > From: Jean-Philippe Brucker [mailto:jean-philippe@linaro.org] > > Sent: Friday, August 28, 2020 7:41 PM > > To: Song Bao Hua (Barry Song) > > Cc: iommu@lists.linux-foundation.org; linux-arm-kernel@lists.infradead.org; > > robin.murphy@arm.com; will@kernel.org; Linuxarm > > Subject: Re: [PATCH] iommu/arm-smmu-v3: add tracepoints for > > cmdq_issue_cmdlist > > > > Hi, > > > > On Thu, Aug 27, 2020 at 09:33:51PM +1200, Barry Song wrote: > > > cmdq_issue_cmdlist() is the hotspot that uses a lot of time. This > > > patch adds tracepoints for it to help debug. > > > > > > Signed-off-by: Barry Song > > > --- > > > * can furthermore develop an eBPF program to benchmark using this > > > trace > > > > Have you tried using kprobe and kretprobe instead of tracepoints? > > Any noticeable performance drop? > > Yes. Pls read this email. > kprobe overhead and OPTPROBES implementation on ARM64 > https://www.spinics.net/lists/arm-kernel/msg828788.html Thanks for the pointer. I'm asking because I've been working on BPF trampolines (fentry/fexit) for arm64, which reduce the overhead of BPF tracing, and am looking for confirmation that it's needed before spending more time on it. Perhaps OPTPROBE would be a better first step, though, it seems more generic. Thanks, Jean _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel