From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11400C433E7 for ; Sat, 29 Aug 2020 17:43:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DCF1720757 for ; Sat, 29 Aug 2020 17:43:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fjaJsWTK"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oFeXjVAw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DCF1720757 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:To:From:Date: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=RNN3d3hsIpIGGjCf8NdCVvRN20PMLdmvcPLD+/NO1DQ=; b=fjaJsWTKxkNh/DQXqizanU5b9M TXRvhz1mPc3C1F9KCpjlHM4VtkgJr1AX/DOQ5jsK/oYn+QP9nqdpe9nFgMVRUqStsbxe0zO7tcTpt XJQ+LdR4qEIfSLBeL8ez0VmwhZ8wTlNEoUb/VSB+SgoQg8Nq3UXCPMrwy7c+iSiUfgX/G8J0K0zND X92ZRqPzumKvudb9h+DVclZ746T7VCpJ+RM0V1fDBnYxGBorNFQ8uL31vM6ra5Gq3F6qDMopFrerL QBgGM7nTjkp5lRUetAhouTcGIv3efuXtfrcIdA51Ov0CdoklpN2/Dv4Q2XV5R/CiSLFeH6cSjkTO6 AiN/rPaA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kC4re-00059v-3P; Sat, 29 Aug 2020 17:42:06 +0000 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kC4rb-00059Y-PE for linux-arm-kernel@lists.infradead.org; Sat, 29 Aug 2020 17:42:04 +0000 Received: by mail-pg1-x541.google.com with SMTP id 5so2012906pgl.4 for ; Sat, 29 Aug 2020 10:42:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=v0+Y6jCCh/wg/QF1vN3peVwswvjJOdtClUaEODnQziQ=; b=oFeXjVAwrSsrDiXpvBkVKLGo4tCbl62Epz1MfOQSMzS8sQ6rpl2LHbpf/pQq8W68mC oTXIz5IQSy+EQf0kdwftqhfFFh4lXPXhC7TW9KKsqNv3gNfnaPMmIsEjiJKHbaCsndiS J53uLYxbt1mSOX0QfeA42tgjzAG9wd3btizSgcxC4Zd+NAa50m8bjfN1sIApgbPKmBkP G2HWgkjKHYzz8YWNos6xicICQj6D9a0Z5ihabi9rZZ9m9uZmEGpRsmaJL6gFqNenxINY Z8M2DPOjASl+gtr670VNie794YqbKioyR9WjY0Cp+03P0bdbv7stfoBESWNHvc8GSQ1c 5sUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=v0+Y6jCCh/wg/QF1vN3peVwswvjJOdtClUaEODnQziQ=; b=PXB7N9g0iA6nry3+zXKsyulEaQfxY5SXrBCeVJdgr1xXIZW6DtEZXJqjgJny6D0CZm e5VelXjH+N25R265VXeA19CZ0b7QqTZcRe/9DJvpQ4OdR5rn1hPaGdlJqhWcux81m1kq mgH2S9ls6nLbbuzo+/2Syuzzj6CQoVjy4jTRFr0v1Mgu/KR8vCLZGA74dLqjm/CNnxFT faitqvRLwlUXg5XeiG6zy2Awb/ejbWbEKmX4lmOyyiuKtyMGV2rvfqsis9b6pnySvyQo nhldmcAfxgFxZN0JBSJx9c1CIlMSto8t9RSnDV/xy4HP5Vjt//Ha092CYtKj22O2p/Mj B7ww== X-Gm-Message-State: AOAM531AgqZTKyds1WBjDhWOXpBJIDNnEf6u7O4nJUp4Ca+6Tx868ipV ZvKQjMWuTzNTNgg0hHp/Yx4= X-Google-Smtp-Source: ABdhPJyoHhXogLh3qAcZCEpJlOnGD0LhHXv5OxORHg9R4XYGNFGISknfIYc2luHIh0NLe2jeHn+/ig== X-Received: by 2002:a63:1341:: with SMTP id 1mr3110890pgt.144.1598722919806; Sat, 29 Aug 2020 10:41:59 -0700 (PDT) Received: from Kaladin ([49.207.221.164]) by smtp.gmail.com with ESMTPSA id u2sm2591711pjj.57.2020.08.29.10.41.57 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 29 Aug 2020 10:41:59 -0700 (PDT) Date: Sat, 29 Aug 2020 23:11:54 +0530 From: Sumera Priyadarsini To: linus.walleij@linaro.org Subject: [PATCH] bus: arm-integrator-lm: Add of_node_put() before return statement Message-ID: <20200829174154.GA9319@Kaladin> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200829_134203_876640_2EFD792B X-CRM114-Status: GOOD ( 15.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Julia.Lawall@lip6.fr, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Every iteration of for_each_available_child_of_node() decrements the reference count of the previous node, however when control is transferred from the middle of the loop, as in the case of a return or break or goto, there is no decrement thus ultimately resulting in a memory leak. Fix a potential memory leak in arm-integrator-lm.c by inserting of_node_put() before a return statement. Issue found with Coccinelle. Signed-off-by: Sumera Priyadarsini --- drivers/bus/arm-integrator-lm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bus/arm-integrator-lm.c b/drivers/bus/arm-integrator-lm.c index 845b6c43fef8..2344d560b144 100644 --- a/drivers/bus/arm-integrator-lm.c +++ b/drivers/bus/arm-integrator-lm.c @@ -54,6 +54,7 @@ static int integrator_lm_populate(int num, struct device *dev) ret = of_platform_default_populate(child, NULL, dev); if (ret) { dev_err(dev, "failed to populate module\n"); + of_node_put(child); return ret; } } -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel