From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3F59C433E6 for ; Sat, 29 Aug 2020 17:58:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C85552071B for ; Sat, 29 Aug 2020 17:58:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="F65uYLse"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nHvExVGc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C85552071B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:To:From:Date: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=tyrlFI2OLbgv6Eyn5SA8konjabUAjzo8ExpmqqtvKIs=; b=F65uYLseujQhqdws0hWGnysUmT m9jlFZGjxgeqItbATZjKv4+JRiE+O3N+3+4mFdxdAMjmKdENKeQiTiuGRS7F0l6uvx7UEgjSeSjKC 5XofODD8b5eJqQ1p+zEb2IPXpTHFKlkoeeEAq7z1LV4dHlE6pqdQFlU9jzKhr7VIuh23WAOMC+BaX myXUy5hF6VwZyEQ4hk5zO97H6pASvOd4Hg8ZCZEgWVcYwBCJQKWp6Xx9MFw+5KQuTnwLjudEi2SJy 4iQmjC484kLnGfgoALhxZhMHHzquJY2x9OMaucCNRIa4/PhgpYkMwVJyy1u8+H795yRWb5dZqZ7XY ieru/x2g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kC56J-0006EB-9H; Sat, 29 Aug 2020 17:57:15 +0000 Received: from mail-pj1-x1042.google.com ([2607:f8b0:4864:20::1042]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kC56F-0006CQ-Kv for linux-arm-kernel@lists.infradead.org; Sat, 29 Aug 2020 17:57:13 +0000 Received: by mail-pj1-x1042.google.com with SMTP id i13so1025258pjv.0 for ; Sat, 29 Aug 2020 10:57:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=nXrk/kbkqy9ClgLwV0Wr/6W8seRn97oLX3UsuxPWEoY=; b=nHvExVGcx1v5QIMuNToDfBdw5r05ACuQOvQVL0p0Mv7PF5Dv7tkS0/hatJ5fvM7Xe3 2/FqOoQTZ12UciQ1z9PpbYlxgsYqOVHrM6OWCuaq5ic56dZVeMCSDk2TxN7ZtXEsVQjx lD7JOzPS865iRr7U/qypbQwlE9ZiSLukddyuj+cNj7BeiyoXN01+J9s76jAqkT3fFm3S Ogu1na4EKzTVGBQ02b3UHuw/NvWTA2NUgIq81VLOCCHRSva9uD0p+ZrNgxrSAAAcTLPi XkGGcSxok9dAtE0wqyXC2M+wdOcLvsmc1wJ2aKu/iOqh5GYqFnXL/KdMHJ9KfkltZVPS fKVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=nXrk/kbkqy9ClgLwV0Wr/6W8seRn97oLX3UsuxPWEoY=; b=o9Qux+o934irMkKvK4sgN1mvT4onGsPFZV0J5whFFt4jSNb/UGEb/k5FyI69rvz9vj 8WceGd3VHwzLelcRbfJDRJZurKdrY+hrLcVURio9vwXkg3Siai1/lYQxqI69MEIkNhad 597gMh0HGvOWWCE1Ex21piRWhEPvY+Bb+j7y94BSTMZrmHmP/RehztY6yFWZqVkclHWi twcodMzlthmTnFiuFw47G57Sabt8G6BeGQXtAQOQ4GkxWhiZbfl+iJug7Q+b04N3lK2D l5ZF13q08cDs1ikGRCwIBtJ8Wqv1HJRgcT9X7NtF2xbXQDeXk+lYWMaZ9QuEEknVQJi0 TmMg== X-Gm-Message-State: AOAM533FQuf45PxFUJ1d15zuy2BAQm/DRlwabDCQFJ40kj8BJkZMMQAo mlE+i2tOIasRnDOOoP4Flhk= X-Google-Smtp-Source: ABdhPJz8kvXRTnTuh/ujkGXu/cl/rzn4a8toQGh/PurvhJq+27dEU+2ROM4rHVN/5lRrk2Eyk4IRfg== X-Received: by 2002:a17:902:8d82:: with SMTP id v2mr3404174plo.180.1598723829381; Sat, 29 Aug 2020 10:57:09 -0700 (PDT) Received: from Kaladin ([49.207.221.164]) by smtp.gmail.com with ESMTPSA id j13sm3254207pfn.166.2020.08.29.10.57.06 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 29 Aug 2020 10:57:08 -0700 (PDT) Date: Sat, 29 Aug 2020 23:27:04 +0530 From: Sumera Priyadarsini To: linus.walleij@linaro.org Subject: [PATCH] clk: versatile: Add of_node_put() before return statement Message-ID: <20200829175704.GA10998@Kaladin> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200829_135712_151679_4502C024 X-CRM114-Status: GOOD ( 14.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sboyd@kernel.org, mturquette@baylibre.com, linux-kernel@vger.kernel.org, Julia.Lawall@lip6.fr, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Every iteration of for_each_available_child_of_node() decrements the reference count of the previous node, however when control is transferred from the middle of the loop, as in the case of a return or break or goto, there is no decrement thus ultimately resulting in a memory leak. Fix a potential memory leak in clk-impd1.c by inserting of_node_put() before a return statement. Issue found with Coccinelle. Signed-off-by: Sumera Priyadarsini --- drivers/clk/versatile/clk-impd1.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/clk/versatile/clk-impd1.c b/drivers/clk/versatile/clk-impd1.c index ca798249544d..85c395df9c00 100644 --- a/drivers/clk/versatile/clk-impd1.c +++ b/drivers/clk/versatile/clk-impd1.c @@ -109,8 +109,10 @@ static int integrator_impd1_clk_probe(struct platform_device *pdev) for_each_available_child_of_node(np, child) { ret = integrator_impd1_clk_spawn(dev, np, child); - if (ret) + if (ret) { + of_node_put(child); break; + } } return ret; -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel