linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rob Herring <robh+dt@kernel.org>,
	linux-samsung-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Proper ranges for memory controller (exynos5410-smdk5410)
Date: Sun, 30 Aug 2020 16:52:12 +0200	[thread overview]
Message-ID: <20200830145212.GA29592@kozik-lap> (raw)

Hi Rob,

Maybe you could help me here as I am trying to understand where is the
error (cross compiling on ARM):

    $ make exynos_defconfig
    $ make dtbs_check

    arch/arm/boot/dts/exynos5410-smdk5410.dt.yaml: soc: memory-controller@12250000:ranges: [[0, 0, 67108864, 131072, 1, 0, 83886080, 131072, 2, 0, 100663296, 131072, 3, 0, 117440512, 131072]] is not valid under any of the given schemas (Possible causes of the failure):
    arch/arm/boot/dts/exynos5410-smdk5410.dt.yaml: soc: memory-controller@12250000:ranges: [[0, 0, 67108864, 131072, 1, 0, 83886080, 131072, 2, 0, 100663296, 131072, 3, 0, 117440512, 131072]] is not of type 'boolean'
    arch/arm/boot/dts/exynos5410-smdk5410.dt.yaml: soc: memory-controller@12250000:ranges:0: [0, 0, 67108864, 131072, 1, 0, 83886080, 131072, 2, 0, 100663296, 131072, 3, 0, 117440512, 131072] is too long
    From schema: local/lib/python3.6/site-packages/dtschema/schemas/simple-bus.yaml

This is a Exynos SROM memory controller with four banks like this:

arch/arm/boot/dts/exynos5410.dtsi
    376 &sromc {
    377         #address-cells = <2>;
    378         #size-cells = <1>;
    379         ranges = <0 0 0x04000000 0x20000
    380                   1 0 0x05000000 0x20000
    381                   2 0 0x06000000 0x20000
    382                   3 0 0x07000000 0x20000>;
    383 };

Converting it to:
    376 &sromc {
    377         #address-cells = <2>;
    378         #size-cells = <1>;
    379         ranges = <0 0 0x04000000 0x20000>,
    380                  <1 0 0x05000000 0x20000>,
    381                  <2 0 0x06000000 0x20000>,
    382                  <3 0 0x07000000 0x20000>;
    383 };
silences the error although I cannot check whether this even works
(I don't have this HW).  Is it because of simple-bus schema which
expects an array of arrays of 3 to 7 size?

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

                 reply	other threads:[~2020-08-30 14:53 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200830145212.GA29592@kozik-lap \
    --to=krzk@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).