From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5203C433E2 for ; Mon, 31 Aug 2020 00:07:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 94D892076D for ; Mon, 31 Aug 2020 00:07:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PxwyvxG9"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="L/2mPXua" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 94D892076D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=A0VWrfndiCXqHwmoyU1PX82GOZ/ss8pc1GND3aM9U1c=; b=PxwyvxG9UVgL3yOtmOvbI4uHR rPT/b/bBS02P3LNUunjpApus5mG7xc5nYU7WtpWXfyIysqHLbukZO7zcvAe78QNtSsB4uz9chC+/r 2WOSBle+IW6zeIutjK61/j+36jdSatMW5XTEPSMVjHUt66Ipj5FJB4WkT00UAXGQVaXZHwQeJ/71P PBxahsQV4jMUYYBF9W7wOVtXp7R97aHLtIWgGTIGyax8VLlyuupXLbTnGpDf6z/MfH/BGq9G4ZUlk Gn4wv44ujqlt1F/3tWCHudF3TOs2z2f/EKLmCVTBhJQSuc7I26U1neizr0kSt06Qy513EOEuhmdp4 aC6R9H5zw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kCXJZ-0005dL-7v; Mon, 31 Aug 2020 00:04:49 +0000 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kCXJU-0005ZX-K5 for linux-arm-kernel@lists.infradead.org; Mon, 31 Aug 2020 00:04:46 +0000 Received: by mail-pg1-x542.google.com with SMTP id m34so3329334pgl.11 for ; Sun, 30 Aug 2020 17:04:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jUdSvk5J8DTI5Xr+3CE/Zt/bx+WPT72VmT5LjNqwFtM=; b=L/2mPXuaXAvKNhkkTk5J/NKPLUghKUXkDkan9fTIWgOlhEWQFsKYi8Fx1aCHKoN6hb kJ9JODK7tYFEjeu7AhaP9Wlhz8hbqHaT/DRu494hnxcrI7pbU/+sF4QBvgyqJOxYwXRZ 6MnMqdvbjUJ+1FhTKtxlLVdd/odTPuDoHO17bW8jNls+eye/7a2aq8QlXu9l+jzt4pZX fRxfGkgn4kEZwOTE1lx2cq3FhnGqq9iCNiNI3goE4+QgCVz7GGkI98qgh7wmTePjNsQZ HdewTQsTunDTyj5Rd/OjHY4iWSlCaBgbBnppfBu9rc4mWJ304lp4iQio8zKNK/Tc/ySC Vk4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jUdSvk5J8DTI5Xr+3CE/Zt/bx+WPT72VmT5LjNqwFtM=; b=aQo5tIXNJhOMNRcFYGp9FcoRdGAaiiJ5vJ2/0dNquAa/Fgs3uwJJwfSBpdFgFSvHoN Ftk/EV1qgWDnCDPDC0PE//zjqgt1PJfxSL+9CKC2Ol/1tjPVz4o+MQ6nds2bogDgia7A NzDZiuVTpB8mEnjPSoOQ0viMkc5bAILik/ejOihr+WGCPy1elVU/QyuTo+J5+gulXiul cWfuvhmHo8aBFse8BvznSp7rWcv2N/q9c7TnCkjyHHyRimKALBcO8L+06qDKW6guuEvJ 6dAoyK2BerN47wkN+bbZscODjR1Xr3Xh9KrMtrwGkoYEoa3tHT5xvJAQP/ic5I7oiLma 5e+w== X-Gm-Message-State: AOAM532rDL8g4YHhYn1iOl5UvTLcHKjXLgiq+9PfoBdE8kK/mx0vm5nA oCYbhRG7tANL2Kt7gWuhUyRAYw== X-Google-Smtp-Source: ABdhPJxg/ZwGZH6yTleWALtbXSO2u0NTDMXd5PjRa28U19Zb8c97rFw+uArdIPjbOAYHXF3uOOly7Q== X-Received: by 2002:a62:7551:: with SMTP id q78mr948027pfc.140.1598832280504; Sun, 30 Aug 2020 17:04:40 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([2600:3c01::f03c:91ff:fe8a:bb03]) by smtp.gmail.com with ESMTPSA id l13sm5391701pgq.33.2020.08.30.17.04.36 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 30 Aug 2020 17:04:39 -0700 (PDT) Date: Mon, 31 Aug 2020 08:04:32 +0800 From: Leo Yan To: Mathieu Poirier Subject: Re: [PATCH 1/2] perf cs-etm: Fix corrupt data after perf inject from Message-ID: <20200831000432.GA4715@leoy-ThinkPad-X240s> References: <20200819084751.17686-1-leo.yan@linaro.org> <20200827205354.GE22307@xps15> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200827205354.GE22307@xps15> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200830_200445_055339_65CBE6C5 X-CRM114-Status: GOOD ( 30.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Andi Kleen , Al Grant , Suzuki K Poulose , Peter Zijlstra , Adrian Hunter , Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, Alexander Shishkin , Ingo Molnar , Namhyung Kim , Kan Liang , Jiri Olsa , linux-arm-kernel@lists.infradead.org, Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mathieu, On Thu, Aug 27, 2020 at 02:53:54PM -0600, Mathieu Poirier wrote: > Hi Leo and Al, > > On Wed, Aug 19, 2020 at 04:47:50PM +0800, Leo Yan wrote: > > From: Al Grant > > > > Commit 42bbabed09ce ("perf tools: Add hw_idx in struct branch_stack") > > changed the format of branch stacks in perf samples. When samples use > > this new format, a flag must be set in the corresponding event. > > Synthesized branch stacks generated from CoreSight ETM trace were using > > the new format, but not setting the event attribute, leading to > > consumers seeing corrupt data. This patch fixes the issue by setting the > > event attribute to indicate use of the new format. > > > > Fixes: 42bbabed09ce ("perf tools: Add hw_idx in struct branch_stack") > > Signed-off-by: Al Grant > > Reviewed-by: Andrea Brunato > > Signed-off-by: Leo Yan > > --- > > tools/perf/util/cs-etm.c | 9 ++++++++- > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > > diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c > > index c283223fb31f..a2a369e2fbb6 100644 > > --- a/tools/perf/util/cs-etm.c > > +++ b/tools/perf/util/cs-etm.c > > @@ -1344,8 +1344,15 @@ static int cs_etm__synth_events(struct cs_etm_auxtrace *etm, > > attr.sample_type &= ~(u64)PERF_SAMPLE_ADDR; > > } > > > > - if (etm->synth_opts.last_branch) > > + if (etm->synth_opts.last_branch) { > > attr.sample_type |= PERF_SAMPLE_BRANCH_STACK; > > + /* > > + * We don't use the hardware index, but the sample generation > > + * code uses the new format branch_stack with this field, > > + * so the event attributes must indicate that it's present. > > + */ > > + attr.branch_sample_type |= PERF_SAMPLE_BRANCH_HW_INDEX; > > + } > > I've see this patch before... I thought it had been merged - what happened? This patch before has been sent by Al to CoreSight mailing list but has not sent to LKML, this is why I resent it to LKML in case it's missed. Thanks, Leo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel