From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EE13C433E2 for ; Mon, 31 Aug 2020 06:36:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED137206B5 for ; Mon, 31 Aug 2020 06:36:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EUC7osea"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GJ8cF7PT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED137206B5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zkWDBdxsfhqKHgmABSMiBXccytmLEc5LTrINSa9LvR4=; b=EUC7oseaf0j0DXNVzUk0ESCmd BAJuS3VzgKm4KGatbyA9XgPnp29bvYWeH99+/q2qiqCji3Ejd7mPPwWDoCukR2cmb0wO/Ra7RPOmG W9o+zHjXn5NE0taLqeOKRugUoZ+xUSdtHlWvhle3A/X+H8/vn/U/711EVoYQpLiGYiX14BJ1HaQIW /lqc3oK1uPFdW+reRgASpCFuk2sWf97pEc5e/PnyNvZZ9Xw9t2GXJd7gb7w3vgUtfOx4dr6+M48hT 1EJqSsVLzbMVCQUCTBMmKtVM/a8ftyCsO/Y9z9jcZlC3pR0aI8lZCI7J929le+37lTXUFw+CbBSBL jNBd8zgmQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kCdOj-0004nM-SG; Mon, 31 Aug 2020 06:34:33 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kCdOh-0004mi-4V for linux-arm-kernel@lists.infradead.org; Mon, 31 Aug 2020 06:34:32 +0000 Received: by mail-wm1-x343.google.com with SMTP id s13so4268068wmh.4 for ; Sun, 30 Aug 2020 23:34:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ZP1iGX70R6WBiUNO1tOXFyMcuHcjl1P18JgeTI2dD4c=; b=GJ8cF7PTYPGqReRtR4re5LgMZeUffjNB2POodeR5VWXtozhKn1QnVm9UGIGIV/YDGn ECBu6Ltxw/XVa/OG3q/hSDF/cr+L26H5usMZQW7NC4tHUeoVUH+X5a1csICElBJWDXWD xjJoW/3lKtyLLjDx/53+ZgW9pPYDJ2allVLRY4aWJTfTiE0VNdODR2Lh/Zbx5X+3RsxJ A7+Hlzv1lQfF/H3InZltg1ePkJcbEfF1a8y7DgL2xCLAzfhhuyA5Hr+C5cJQEjq6gaZb pIYQhjUPMmOKyYSlJMNT9+jSpvpgwLjjEgiBWOjhEQ9O04H1IVlg36iBUqoe83jl+ipQ stxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZP1iGX70R6WBiUNO1tOXFyMcuHcjl1P18JgeTI2dD4c=; b=Uhd4L7yCN7ReXabA+j2kPtPa4C7qsK/YLXMOXbmcCDiBepc1mnteHlmhbaW8x6Qi/+ OAXgNm4KqL1dic1WCHgByjbiqUeg77NKkCHBPvyhepJu+7IPKgLEnbV4u/dEPYV5LlZ4 NzArucJy3d6nWRS0peWX/novm2G3AcYe0+NslEjjCyoi+MRfUWPGCj0hb8dYKHrDwEDY zPSRHtTYJdQB18hMOdR5PYhhAnUQrmSK+IOy+ffbkM6eGTNHLY0hnmrklAbfHnlEmjJx kQeCVN3ckcj4rpUuCnkqKBfYa7d5zsd2vzzJX3Jqz5sSS0z0pY6d6JSh4+Go71SCL2ku 4MRA== X-Gm-Message-State: AOAM531li+JFq6KZbjvg8e0kBwtCSzy/vgNSWQJJxfZsC0tlQaF9gZjM +U2m0T9Bbt58ts6wveEYyp8= X-Google-Smtp-Source: ABdhPJzF0UppAc4MASa721wAZz4ZjrCxQwb20+xfqZzysOU4TggFFq5EbI81tQEF4nDVs7iIdOjAQQ== X-Received: by 2002:a1c:4054:: with SMTP id n81mr269837wma.81.1598855668861; Sun, 30 Aug 2020 23:34:28 -0700 (PDT) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id f6sm11682451wme.32.2020.08.30.23.34.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Aug 2020 23:34:28 -0700 (PDT) Date: Mon, 31 Aug 2020 08:34:26 +0200 From: Corentin Labbe To: Martin Cerveny Subject: Re: [PATCH] ARM: dts: sun8i: v3s: Enable crypto engine Message-ID: <20200831063426.GA18853@Red> References: <20200827180027.6254-1-m.cerveny@computer.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200827180027.6254-1-m.cerveny@computer.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200831_023431_253041_1EB0BBBB X-CRM114-Status: GOOD ( 21.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, herbert@gondor.apana.org.au, linux-kernel@vger.kernel.org, mripard@kernel.org, wens@csie.org, robh+dt@kernel.org, linux-crypto@vger.kernel.org, davem@davemloft.net, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 27, 2020 at 08:00:27PM +0200, Martin Cerveny wrote: > V3S contains crypto engine that is compatible with "sun4i-ss". > > Tested-by: Martin Cerveny > Signed-off-by: Martin Cerveny > --- > .../bindings/crypto/allwinner,sun4i-a10-crypto.yaml | 5 ++++- > arch/arm/boot/dts/sun8i-v3s.dtsi | 10 ++++++++++ > drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c | 7 +++++++ > 3 files changed, 21 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml b/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml > index fc823572b..180efd13a 100644 > --- a/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml > +++ b/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml > @@ -25,6 +25,7 @@ properties: > - const: allwinner,sun4i-a10-crypto > - items: > - const: allwinner,sun8i-a33-crypto > + - const: allwinner,sun8i-v3s-crypto > > reg: > maxItems: 1 > @@ -59,7 +60,9 @@ if: > properties: > compatible: > contains: > - const: allwinner,sun6i-a31-crypto > + oneOf: > + - const: allwinner,sun6i-a31-crypto > + - const: allwinner,sun8i-v3s-crypto > > then: > required: > diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi b/arch/arm/boot/dts/sun8i-v3s.dtsi > index e5312869c..4fec84c40 100644 > --- a/arch/arm/boot/dts/sun8i-v3s.dtsi > +++ b/arch/arm/boot/dts/sun8i-v3s.dtsi > @@ -234,6 +234,16 @@ > #size-cells = <0>; > }; > > + crypto: crypto@1c15000 { > + compatible = "allwinner,sun8i-v3s-crypto"; > + reg = <0x01c15000 0x1000>; > + interrupts = ; > + clocks = <&ccu CLK_BUS_CE>, <&ccu CLK_CE>; > + clock-names = "ahb", "mod"; > + resets = <&ccu RST_BUS_CE>; > + reset-names = "ahb"; > + }; > + > usb_otg: usb@1c19000 { > compatible = "allwinner,sun8i-h3-musb"; > reg = <0x01c19000 0x0400>; > diff --git a/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c b/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c > index a2b67f7f8..d24496cac 100644 > --- a/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c > +++ b/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c > @@ -31,6 +31,10 @@ static const struct ss_variant ss_a33_variant = { > .sha1_in_be = true, > }; > > +static const struct ss_variant ss_v3s_variant = { > + .sha1_in_be = true, > +}; > + > static struct sun4i_ss_alg_template ss_algs[] = { > { .type = CRYPTO_ALG_TYPE_AHASH, > .mode = SS_OP_MD5, > @@ -505,6 +509,9 @@ static const struct of_device_id a20ss_crypto_of_match_table[] = { > { .compatible = "allwinner,sun8i-a33-crypto", > .data = &ss_a33_variant > }, > + { .compatible = "allwinner,sun8i-v3s-crypto", > + .data = &ss_v3s_variant > + }, > {} > }; > MODULE_DEVICE_TABLE(of, a20ss_crypto_of_match_table); > -- > 2.17.1 > You should split at least drivers/crypto and the dts part, as drivers/crypto patchs are merged via the cryptodev tree and dts/doc will be merged via the sunxi tree. And ideally split patch in 3, the doc, the dts and the crypto. See how I added the same for A33 in: https://lore.kernel.org/linux-arm-kernel/20191120152833.20443-1-clabbe.montjoie@gmail.com/ Anyway the content is good. Acked-by: Corentin Labbe Thanks _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel