From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8127DC433E6 for ; Mon, 31 Aug 2020 08:20:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F21F207BB for ; Mon, 31 Aug 2020 08:20:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Iud+6wck" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F21F207BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mEye6nMNL8ybLuBSfPXsqs/aYGzJU4pnn9FIE/Hpigc=; b=Iud+6wckq996RyZTF5KsAkP29 LRgXzNgmP8NbWsqXAn4dIOhnjWgZBkCcPUyjdsOP0PUOL5IXyL7b1JD809DJCI0uYMETv4Fk92e2B UvQ9d4glDgokf1C5xrz6f7pT4XFcVqCpYWS3fLc7GpHocMcjimUMzC69Xb4VNTeWcukcRoeipz6o7 XtuYqdTQwrxZ1orHMZDKVeI8+jRaGYQc46wyLBHRDc/FGu/r6fx77o72RwI8tyw/l6zAhFOvB0IHO SeXWiCtS1LRSsmqHGl79GLwRKN7vNlloKelwPHdDGfoSDBNP+ipfdal+xYmxMCUUETo2rTvAnjBC6 d07L6668Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kCf21-0001vB-LB; Mon, 31 Aug 2020 08:19:13 +0000 Received: from mail-ej1-f65.google.com ([209.85.218.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kCf1z-0001uq-HI for linux-arm-kernel@lists.infradead.org; Mon, 31 Aug 2020 08:19:12 +0000 Received: by mail-ej1-f65.google.com with SMTP id d11so7236440ejt.13 for ; Mon, 31 Aug 2020 01:19:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Cqrk1bBlfTS3BPtOTE3s4vilkxanbVUMadQ6BMq95XQ=; b=MZRvOJNujL90ePIu7kJIEHqfTk2h0PCK9GCny8N2QHLECZK0UvOiDLXhZpqBmfuasp GukgDz1R2yQB82Nq5nlzvUOWvLedmXTcL9GQPtJNju/v9k4Hk/YAAtwqSxZTa3bzlugp JYOAOdCx4gF7Vo2EbSJNGJ06OSL3KSi/UL7l/HUZ/kA0bv7ThKeybk3+ZcU9DZdepk5c A7al2x32J3F88Wic6AymL6mfZFwoNKdYr5bj/kWNN4CZlue3pFwa3rN7ljqkVb7YiJfU 8UNV3An9lU7x2TLochrv6qPvuOb0cAaObycg0B06wrpcCA+5urpzUp9+g4ArWJCRg42m iGyQ== X-Gm-Message-State: AOAM5321f2/IV4ubiNnzccQNhQJI/7XS7g5oTDc7rzY1aUWnCI5hY3/+ Yhw5qjTJJIlA1ycF2sTF5qM= X-Google-Smtp-Source: ABdhPJwZmYA5QBVdQf3hNtCbKsFlHcp5sGv8ZbmLIZ97Vr6lwstZRZcAMaFR7D7zA37ZpKOOmXJ5ug== X-Received: by 2002:a17:906:180b:: with SMTP id v11mr47877eje.427.1598861949932; Mon, 31 Aug 2020 01:19:09 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id d2sm7482261ejm.19.2020.08.31.01.19.08 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 31 Aug 2020 01:19:09 -0700 (PDT) Date: Mon, 31 Aug 2020 10:19:06 +0200 From: Krzysztof Kozlowski To: Marek Szyprowski Subject: Re: [RFT 3/4] ARM: dts: exynos: Move CMU assigned ISP clocks to buses in Exynos3250 Message-ID: <20200831081906.GA11513@kozik-lap> References: <20200829172532.29358-1-krzk@kernel.org> <20200829172532.29358-3-krzk@kernel.org> <6ed67a82-0f29-7384-203d-dcb2e58c5a8d@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6ed67a82-0f29-7384-203d-dcb2e58c5a8d@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200831_041911_617188_F0BBB5EC X-CRM114-Status: GOOD ( 25.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Bartlomiej Zolnierkiewicz , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Sylwester Nawrocki , Rob Herring , Thierry Reding , Kukjin Kim , Daniel Vetter , Sam Ravnborg , Hoegeun Kwon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 31, 2020 at 10:11:02AM +0200, Marek Szyprowski wrote: > Hi Krzysztof, > > On 29.08.2020 19:25, Krzysztof Kozlowski wrote: > > Commit 52005dece527 ("ARM: dts: Add assigned clock parents to CMU node > > for exynos3250") added assigned clocks under Clock Management Unit to > > fix hangs when accessing ISP registers. > > > > This is not the place for it as CMU does not have a required "clocks" > > property: > > > > arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml: clock-controller@10030000: 'clocks' is a dependency of 'assigned-clocks' > > > > Signed-off-by: Krzysztof Kozlowski > > > > --- > > > > Not tested and I wonder whether actually correct. For example, what will > > happen if devfreq (exynos-bus) is not built in? > > > > Could someone verify it? > > Sorry, but this patch is not correct. Those clocks has noting with > bus-freq. The assigned clocks property should stay where it is. Maybe > one need to fix the schemas for dts verification. Those clocks has to be > set (and so generic clock framework does) according to the assigned > clocks properties once the clock controller is instantiated. > > The only alternative would be to add exynos-subcmu variant to properly > link CMU with the ISP power domain, but assuming that there is no Exynos > 3250 ISP driver in mainline (and probably never will be), it is safe to > keep those clocks sourced from 24MHz crystal. Thanks for the clarification. Another solution to silence the warning could be to add a "clocks" property for FIN_PLL, although the driver actually does not take it. This is the only remaining dtschema check warning on Exynos3250 so it would be nice to at least silence it. My goal is to have all them schema-correct, or as close as possible (for Exynos4 the camera node is a trouble). Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel